From 742de50c5ec01f93cf0e193a8a131cbd913cb787 Mon Sep 17 00:00:00 2001 From: Volker Hilsheimer Date: Mon, 2 Nov 2020 14:58:31 +0100 Subject: Address API review comments for QInput/QPointingDevice - Give default constructor an optional parent, as is standard for QObjects - remove default for QObject parent from inheritance constructor - make QPointingDeviceUniqueId comparison inline, remove superfluous inline of hidden friends - mark read only properties as CONSTANT - remove bit-size from enum types; they are stored in the private, and there are just a few instances; no need to save a few bytes at the expense of performance and code cleanliness Change-Id: Ie7d4a587362714e9d3bc41447cef786bbdb382c6 Reviewed-by: Shawn Rutledge --- src/gui/kernel/qevent.cpp | 8 -------- 1 file changed, 8 deletions(-) (limited to 'src/gui/kernel/qevent.cpp') diff --git a/src/gui/kernel/qevent.cpp b/src/gui/kernel/qevent.cpp index 0c3b631608..7db77f5ee5 100644 --- a/src/gui/kernel/qevent.cpp +++ b/src/gui/kernel/qevent.cpp @@ -5327,14 +5327,6 @@ qint64 QPointingDeviceUniqueId::numericId() const noexcept (\c true) or not (\c false). */ -/*! - \internal -*/ -bool QPointingDeviceUniqueId::equals(QPointingDeviceUniqueId other) const noexcept -{ - return numericId() == other.numericId(); -} - /*! \relates QPointingDeviceUniqueId \since 5.8 -- cgit v1.2.3