From 15f1fe587d35cb3a10ce7e24b8572c6483e4ea34 Mon Sep 17 00:00:00 2001 From: Vadim Zakondyrin Date: Sat, 17 Nov 2012 10:10:51 +0700 Subject: Fixed memory leak in assign operator of QOpenGLBuffer Change-Id: I47f9128b54770bae7a63f82bf66ca16144b67c55 Reviewed-by: Lars Knoll --- src/gui/opengl/qopenglbuffer.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/gui/opengl') diff --git a/src/gui/opengl/qopenglbuffer.cpp b/src/gui/opengl/qopenglbuffer.cpp index f84bbcbaa5..11c85f8f25 100644 --- a/src/gui/opengl/qopenglbuffer.cpp +++ b/src/gui/opengl/qopenglbuffer.cpp @@ -209,8 +209,10 @@ QOpenGLBuffer &QOpenGLBuffer::operator=(const QOpenGLBuffer &other) { if (d_ptr != other.d_ptr) { other.d_ptr->ref.ref(); - if (!d_ptr->ref.deref()) + if (!d_ptr->ref.deref()) { destroy(); + delete d_ptr; + } d_ptr = other.d_ptr; } return *this; -- cgit v1.2.3