From 1dd8b5ceec3a1cde987372a7f993c07f30e5af95 Mon Sep 17 00:00:00 2001 From: Laszlo Agocs Date: Thu, 27 Apr 2023 13:16:29 +0200 Subject: rhi: Make it a QPA-style private but semi-public API qrhi.h, qshader.h, qshaderdescription.h (and qshaderbaker.h from shadertools; done separately) become "RHI APIs", following the concept of QPA APIs. Mirror completely what is done for QPA headers, but using the "rhi" prefix for the headers. This involves updating syncqt to handle the new category of headers. (a note on the regex: matching everything starting with "qrhi" is not acceptable due to incorrectly matching existing and future headers, hence specifying the four header names explicitly) There is going to be one difference to QPA: the documentation for everything RHI is going to be public and part of the regular docs, not hidden with \internal. In addition to the header renaming and adding the comments and documentation notes and warnings, there is one significant change here: there is no longer a need to do API-specific includes, such as qrhid3d11[_p].h, qrhivulkan[_p].h, etc. These are simply merged into a single header that is then included from qrhi.h. This means that users within Qt, and any future applications can just do #include (or rhi/qshader.h if the QRhi stuff is not relevant), no other headers are needed. There are no changes to functionality in this patch. Only the documentation is expanded, quite a lot, to eliminate all qdoc warnings and make the generated API docs complete. An example, with a quite extensive doc page is added as well. Task-number: QTBUG-113331 Change-Id: I91c749826348f14320cb335b1c83e9d1ea2b1d8b Reviewed-by: Volker Hilsheimer Reviewed-by: Qt CI Bot --- src/gui/painting/qbackingstoredefaultcompositor_p.h | 2 +- src/gui/painting/qbackingstorerhisupport.cpp | 11 ----------- src/gui/painting/qbackingstorerhisupport_p.h | 2 +- 3 files changed, 2 insertions(+), 13 deletions(-) (limited to 'src/gui/painting') diff --git a/src/gui/painting/qbackingstoredefaultcompositor_p.h b/src/gui/painting/qbackingstoredefaultcompositor_p.h index d69c17f98f..839fa61c73 100644 --- a/src/gui/painting/qbackingstoredefaultcompositor_p.h +++ b/src/gui/painting/qbackingstoredefaultcompositor_p.h @@ -16,7 +16,7 @@ // #include -#include +#include QT_BEGIN_NAMESPACE diff --git a/src/gui/painting/qbackingstorerhisupport.cpp b/src/gui/painting/qbackingstorerhisupport.cpp index 05329d61c5..15fea26d16 100644 --- a/src/gui/painting/qbackingstorerhisupport.cpp +++ b/src/gui/painting/qbackingstorerhisupport.cpp @@ -8,20 +8,9 @@ #if QT_CONFIG(opengl) #include #include -#include -#endif - -#ifdef Q_OS_WIN -#include -#include -#endif - -#if defined(Q_OS_MACOS) || defined(Q_OS_IOS) -#include #endif #if QT_CONFIG(vulkan) -#include #include #endif diff --git a/src/gui/painting/qbackingstorerhisupport_p.h b/src/gui/painting/qbackingstorerhisupport_p.h index c8aa8f46ea..39ce36c680 100644 --- a/src/gui/painting/qbackingstorerhisupport_p.h +++ b/src/gui/painting/qbackingstorerhisupport_p.h @@ -19,7 +19,7 @@ #include #include #include -#include +#include #include QT_BEGIN_NAMESPACE -- cgit v1.2.3