From 0ab9188ad7ff019747cea7800a7455e709f3bf43 Mon Sep 17 00:00:00 2001 From: Konstantin Ritt Date: Sat, 22 Feb 2014 00:15:13 +0200 Subject: Rename some QTextEngine members to reflect their meaning formats() -> formatCollection() additionalFormats -> formats QTextEngine has three different code paths: in context of QTextDocument, additionalFormats are currently _additional_ formats; though in QTextLayout, they are the only formats in use; and the QRawFont-related path shares the QTextLayout's behavior. This is a preparation step to consolidating these three into a single one. Change-Id: I427ccc3c2f672ce090899bb0a0995972315daafa Reviewed-by: Eskil Abrahamsen Blomfeldt --- src/gui/text/qtextengine_p.h | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) (limited to 'src/gui/text/qtextengine_p.h') diff --git a/src/gui/text/qtextengine_p.h b/src/gui/text/qtextengine_p.h index 14670249a1..29aa9597db 100644 --- a/src/gui/text/qtextengine_p.h +++ b/src/gui/text/qtextengine_p.h @@ -505,10 +505,10 @@ public: void freeMemory(); int findItem(int strPos) const; - inline QTextFormatCollection *formats() const { + inline QTextFormatCollection *formatCollection() const { if (block.docHandle()) return block.docHandle()->formatCollection(); - return specialData ? specialData->formats.data() : 0; + return specialData ? specialData->formatCollection.data() : 0; } QTextCharFormat format(const QScriptItem *si) const; inline QAbstractTextDocumentLayout *docLayout() const { @@ -578,10 +578,11 @@ public: inline QString preeditAreaText() const { return specialData ? specialData->preeditText : QString(); } void setPreeditArea(int position, const QString &text); - inline bool hasFormats() const { return block.docHandle() || (specialData && !specialData->addFormats.isEmpty()); } - inline QList additionalFormats() const - { return specialData ? specialData->addFormats : QList(); } - void setAdditionalFormats(const QList &formatList); + inline bool hasFormats() const + { return block.docHandle() || (specialData && !specialData->formats.isEmpty()); } + inline QList formats() const + { return specialData ? specialData->formats : QList(); } + void setFormats(const QList &formats); private: static void init(QTextEngine *e); @@ -589,15 +590,15 @@ private: struct SpecialData { int preeditPosition; QString preeditText; - QList addFormats; + QList formats; QVector resolvedFormats; // only used when no docHandle is available - QScopedPointer formats; + QScopedPointer formatCollection; }; SpecialData *specialData; - void indexAdditionalFormats(); - void resolveAdditionalFormats() const; + void indexFormats(); + void resolveFormats() const; public: bool atWordSeparator(int position) const; -- cgit v1.2.3