From d31bc5cbf9ac8abba82aec6d8974cf74ee3d2faa Mon Sep 17 00:00:00 2001 From: Timur Pocheptsov Date: Tue, 19 Apr 2016 09:33:27 +0200 Subject: QNetworkReplyImplPrivate - potential nullptr dereference Found by Coverity, CID 11351. If we check 'if (backend)' at one line, not clear why we do 'if (bakcend->canResume())' two lines above without any test. Also, 'delete backend' is noop if backend is nullptr, so ... even this 'if (backend)' is ... not needed. Change-Id: I7a46ce04baeb9251debb7b246954911df58880ca Reviewed-by: Edward Welbourne Reviewed-by: Timur Pocheptsov --- src/network/access/qnetworkreplyimpl.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'src/network/access') diff --git a/src/network/access/qnetworkreplyimpl.cpp b/src/network/access/qnetworkreplyimpl.cpp index 7961a1dbae..86896c2eca 100644 --- a/src/network/access/qnetworkreplyimpl.cpp +++ b/src/network/access/qnetworkreplyimpl.cpp @@ -1100,21 +1100,17 @@ bool QNetworkReplyImplPrivate::migrateBackend() return true; // Backend does not support resuming download. - if (!backend->canResume()) + if (backend && !backend->canResume()) return false; state = QNetworkReplyPrivate::Reconnecting; - if (backend) { - delete backend; - backend = 0; - } - cookedHeaders.clear(); rawHeaders.clear(); preMigrationDownloaded = bytesDownloaded; + delete backend; backend = manager->d_func()->findBackend(operation, request); if (backend) { -- cgit v1.2.3