From 9b67d89c24666d405dd00e63bb56c924738aa002 Mon Sep 17 00:00:00 2001 From: Konstantin Ritt Date: Fri, 23 Jan 2015 13:05:12 +0400 Subject: Pass params of shareable type by const-ref rather than by value ...where passing them by value was not intentional. Change-Id: Ifd5036d57b41fddeeacfbd3f5890881605b80647 Reviewed-by: Shawn Rutledge Reviewed-by: Thiago Macieira --- src/network/socket/qsocks5socketengine.cpp | 4 ++-- src/network/socket/qsocks5socketengine_p.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'src/network/socket') diff --git a/src/network/socket/qsocks5socketengine.cpp b/src/network/socket/qsocks5socketengine.cpp index 2a23642f26..bdeee4195c 100644 --- a/src/network/socket/qsocks5socketengine.cpp +++ b/src/network/socket/qsocks5socketengine.cpp @@ -438,13 +438,13 @@ bool QSocks5Authenticator::continueAuthenticate(QTcpSocket *socket, bool *comple return true; } -bool QSocks5Authenticator::seal(const QByteArray buf, QByteArray *sealedBuf) +bool QSocks5Authenticator::seal(const QByteArray &buf, QByteArray *sealedBuf) { *sealedBuf = buf; return true; } -bool QSocks5Authenticator::unSeal(const QByteArray sealedBuf, QByteArray *buf) +bool QSocks5Authenticator::unSeal(const QByteArray &sealedBuf, QByteArray *buf) { *buf = sealedBuf; return true; diff --git a/src/network/socket/qsocks5socketengine_p.h b/src/network/socket/qsocks5socketengine_p.h index 185d973e06..c97b0e89ce 100644 --- a/src/network/socket/qsocks5socketengine_p.h +++ b/src/network/socket/qsocks5socketengine_p.h @@ -149,8 +149,8 @@ public: virtual bool beginAuthenticate(QTcpSocket *socket, bool *completed); virtual bool continueAuthenticate(QTcpSocket *socket, bool *completed); - virtual bool seal(const QByteArray buf, QByteArray *sealedBuf); - virtual bool unSeal(const QByteArray sealedBuf, QByteArray *buf); + virtual bool seal(const QByteArray &buf, QByteArray *sealedBuf); + virtual bool unSeal(const QByteArray &sealedBuf, QByteArray *buf); virtual bool unSeal(QTcpSocket *sealedSocket, QByteArray *buf); virtual QString errorString() { return QString(); } -- cgit v1.2.3