From 9b67d89c24666d405dd00e63bb56c924738aa002 Mon Sep 17 00:00:00 2001 From: Konstantin Ritt Date: Fri, 23 Jan 2015 13:05:12 +0400 Subject: Pass params of shareable type by const-ref rather than by value ...where passing them by value was not intentional. Change-Id: Ifd5036d57b41fddeeacfbd3f5890881605b80647 Reviewed-by: Shawn Rutledge Reviewed-by: Thiago Macieira --- src/network/access/qftp.cpp | 8 ++++---- src/network/access/qnetworkcookiejar.cpp | 4 ++-- src/network/kernel/qhostinfo.cpp | 2 +- src/network/kernel/qhostinfo_p.h | 2 +- src/network/socket/qsocks5socketengine.cpp | 4 ++-- src/network/socket/qsocks5socketengine_p.h | 4 ++-- 6 files changed, 12 insertions(+), 12 deletions(-) (limited to 'src/network') diff --git a/src/network/access/qftp.cpp b/src/network/access/qftp.cpp index badcb5b021..bb89eece4b 100644 --- a/src/network/access/qftp.cpp +++ b/src/network/access/qftp.cpp @@ -225,8 +225,8 @@ private: class QFtpCommand { public: - QFtpCommand(QFtp::Command cmd, QStringList raw, const QByteArray &ba); - QFtpCommand(QFtp::Command cmd, QStringList raw, QIODevice *dev = 0); + QFtpCommand(QFtp::Command cmd, const QStringList &raw, const QByteArray &ba); + QFtpCommand(QFtp::Command cmd, const QStringList &raw, QIODevice *dev = 0); ~QFtpCommand(); int id; @@ -246,14 +246,14 @@ public: QBasicAtomicInt QFtpCommand::idCounter = Q_BASIC_ATOMIC_INITIALIZER(1); -QFtpCommand::QFtpCommand(QFtp::Command cmd, QStringList raw, const QByteArray &ba) +QFtpCommand::QFtpCommand(QFtp::Command cmd, const QStringList &raw, const QByteArray &ba) : command(cmd), rawCmds(raw), is_ba(true) { id = idCounter.fetchAndAddRelaxed(1); data.ba = new QByteArray(ba); } -QFtpCommand::QFtpCommand(QFtp::Command cmd, QStringList raw, QIODevice *dev) +QFtpCommand::QFtpCommand(QFtp::Command cmd, const QStringList &raw, QIODevice *dev) : command(cmd), rawCmds(raw), is_ba(false) { id = idCounter.fetchAndAddRelaxed(1); diff --git a/src/network/access/qnetworkcookiejar.cpp b/src/network/access/qnetworkcookiejar.cpp index f5c97aeaae..3cefb28f68 100644 --- a/src/network/access/qnetworkcookiejar.cpp +++ b/src/network/access/qnetworkcookiejar.cpp @@ -130,7 +130,7 @@ void QNetworkCookieJar::setAllCookies(const QList &cookieList) d->allCookies = cookieList; } -static inline bool isParentPath(QString path, QString reference) +static inline bool isParentPath(const QString &path, const QString &reference) { if (path.startsWith(reference)) { //The cookie-path and the request-path are identical. @@ -149,7 +149,7 @@ static inline bool isParentPath(QString path, QString reference) return false; } -static inline bool isParentDomain(QString domain, QString reference) +static inline bool isParentDomain(const QString &domain, const QString &reference) { if (!reference.startsWith(QLatin1Char('.'))) return domain == reference; diff --git a/src/network/kernel/qhostinfo.cpp b/src/network/kernel/qhostinfo.cpp index 2912c6fef3..d2dc7c4850 100644 --- a/src/network/kernel/qhostinfo.cpp +++ b/src/network/kernel/qhostinfo.cpp @@ -431,7 +431,7 @@ void QHostInfo::setErrorString(const QString &str) \sa hostName() */ -QHostInfoRunnable::QHostInfoRunnable(QString hn, int i) : toBeLookedUp(hn), id(i) +QHostInfoRunnable::QHostInfoRunnable(const QString &hn, int i) : toBeLookedUp(hn), id(i) { setAutoDelete(true); } diff --git a/src/network/kernel/qhostinfo_p.h b/src/network/kernel/qhostinfo_p.h index 5400b18b37..74cfe2a9aa 100644 --- a/src/network/kernel/qhostinfo_p.h +++ b/src/network/kernel/qhostinfo_p.h @@ -145,7 +145,7 @@ private: class QHostInfoRunnable : public QRunnable { public: - QHostInfoRunnable (QString hn, int i); + QHostInfoRunnable(const QString &hn, int i); void run() Q_DECL_OVERRIDE; QString toBeLookedUp; diff --git a/src/network/socket/qsocks5socketengine.cpp b/src/network/socket/qsocks5socketengine.cpp index 2a23642f26..bdeee4195c 100644 --- a/src/network/socket/qsocks5socketengine.cpp +++ b/src/network/socket/qsocks5socketengine.cpp @@ -438,13 +438,13 @@ bool QSocks5Authenticator::continueAuthenticate(QTcpSocket *socket, bool *comple return true; } -bool QSocks5Authenticator::seal(const QByteArray buf, QByteArray *sealedBuf) +bool QSocks5Authenticator::seal(const QByteArray &buf, QByteArray *sealedBuf) { *sealedBuf = buf; return true; } -bool QSocks5Authenticator::unSeal(const QByteArray sealedBuf, QByteArray *buf) +bool QSocks5Authenticator::unSeal(const QByteArray &sealedBuf, QByteArray *buf) { *buf = sealedBuf; return true; diff --git a/src/network/socket/qsocks5socketengine_p.h b/src/network/socket/qsocks5socketengine_p.h index 185d973e06..c97b0e89ce 100644 --- a/src/network/socket/qsocks5socketengine_p.h +++ b/src/network/socket/qsocks5socketengine_p.h @@ -149,8 +149,8 @@ public: virtual bool beginAuthenticate(QTcpSocket *socket, bool *completed); virtual bool continueAuthenticate(QTcpSocket *socket, bool *completed); - virtual bool seal(const QByteArray buf, QByteArray *sealedBuf); - virtual bool unSeal(const QByteArray sealedBuf, QByteArray *buf); + virtual bool seal(const QByteArray &buf, QByteArray *sealedBuf); + virtual bool unSeal(const QByteArray &sealedBuf, QByteArray *buf); virtual bool unSeal(QTcpSocket *sealedSocket, QByteArray *buf); virtual QString errorString() { return QString(); } -- cgit v1.2.3