From 171938ce1aa9ddcf948f99948881987d1c41620f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Samuel=20R=C3=B8dal?= Date: Tue, 27 Nov 2012 10:25:34 +0100 Subject: Commented confusing QWriteLocker use in QGLTextureCache::getTexture(). Task-number: QTBUG-22560 Change-Id: Idd3948455e8415473a407f66b628418c0d87898d Reviewed-by: Gabriel de Dietrich --- src/opengl/qgl_p.h | 1 + 1 file changed, 1 insertion(+) (limited to 'src/opengl/qgl_p.h') diff --git a/src/opengl/qgl_p.h b/src/opengl/qgl_p.h index 7154545eb5..df099ea281 100644 --- a/src/opengl/qgl_p.h +++ b/src/opengl/qgl_p.h @@ -504,6 +504,7 @@ int QGLTextureCache::maxCost() QGLTexture* QGLTextureCache::getTexture(QGLContext *ctx, qint64 key) { + // Can't be a QReadLocker since QCache::object() modifies the cache (reprioritizes the object) QWriteLocker locker(&m_lock); const QGLTextureCacheKey cacheKey = {key, QGLContextPrivate::contextGroup(ctx)}; return m_cache.object(cacheKey); -- cgit v1.2.3