From f4ad5ede58dd4e431d8fe8f93293934aa7094a78 Mon Sep 17 00:00:00 2001 From: Martin Smith Date: Tue, 22 Nov 2016 10:31:12 +0100 Subject: doc: clangqdoc must always see GL typedefs QT_NO_OPENGL must not be defined when running clangqdoc because there are opengl elements that must be documented. That means clang will see uses of GLxxx, which might not be included on some platforms. For example, clang must parse the declaration for class QOpenGLFramebufferObject, which uses GLuint, GLenum, and GLbitfield, because there is documentation to be published for that class in qopenglframebufferobject.cpp. This change uses Q_CLANG_QDOC to first undef the needed GLxxx types and then provide suitable typedefs for them. This technique is also used in qglshader.h. This works for macOS, but is it the right way to solve the problem? This change also removes some \overload commands, because they shouldn't be used on constructors. And some \fn commands that are made unnecessary by upgrading to clang. Change-Id: I4ac658e951b3f2011698005f0238d4dea85fc403 Reviewed-by: Martin Smith --- src/opengl/qglshaderprogram.h | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'src/opengl') diff --git a/src/opengl/qglshaderprogram.h b/src/opengl/qglshaderprogram.h index 3ce88197d2..dfdef44b54 100644 --- a/src/opengl/qglshaderprogram.h +++ b/src/opengl/qglshaderprogram.h @@ -46,6 +46,17 @@ #include #include +#if defined(Q_CLANG_QDOC) +#undef GLfloat +typedef double GLfloat; +#undef GLint +typedef int GLint; +#undef GLuint +typedef unsigned int GLuint; +#undef GLenum +typedef unsigned int GLenum; +#endif + QT_BEGIN_NAMESPACE -- cgit v1.2.1