From 2f521438ebe5306d97b24a530ed4dc025b12052b Mon Sep 17 00:00:00 2001
From: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
Date: Fri, 7 Feb 2020 07:53:17 +0100
Subject: DirectWrite font db: Fix writing system detection

The implementation here was accidentally missing from the
first commit. We use the OS/2 table for determining the writing system
support as intended by the font designer, and fall back to actually
checking the Unicode ranges if the table should be missing.

Change-Id: Ibfdf76c27f3a94eda2142b3e269a1ca30d4bc045
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
---
 .../fontdatabases/mac/qcoretextfontdatabase.mm     | 12 +----
 .../windows/qwindowsdirectwritefontdatabase.cpp    | 51 +++++++++++++++++-----
 2 files changed, 42 insertions(+), 21 deletions(-)

(limited to 'src/platformsupport')

diff --git a/src/platformsupport/fontdatabases/mac/qcoretextfontdatabase.mm b/src/platformsupport/fontdatabases/mac/qcoretextfontdatabase.mm
index 894919a1c8..bc55efd23d 100644
--- a/src/platformsupport/fontdatabases/mac/qcoretextfontdatabase.mm
+++ b/src/platformsupport/fontdatabases/mac/qcoretextfontdatabase.mm
@@ -268,17 +268,7 @@ static void getFontDescription(CTFontDescriptorRef font, FontDescription *fd)
                     Q_UNREACHABLE();
                 Q_ASSERT(length >= 86);
             }
-            quint32 unicodeRange[4] = {
-                qFromBigEndian<quint32>(os2Table.data() + 42),
-                qFromBigEndian<quint32>(os2Table.data() + 46),
-                qFromBigEndian<quint32>(os2Table.data() + 50),
-                qFromBigEndian<quint32>(os2Table.data() + 54)
-            };
-            quint32 codePageRange[2] = {
-                qFromBigEndian<quint32>(os2Table.data() + 78),
-                qFromBigEndian<quint32>(os2Table.data() + 82)
-            };
-            fd->writingSystems = QPlatformFontDatabase::writingSystemsFromTrueTypeBits(unicodeRange, codePageRange);
+            fd->writingSystems = QPlatformFontDatabase::writingSystemsFromOS2Table(reinterpret_cast<const char *>(os2Table.data()), length);
         }
     }
 
diff --git a/src/platformsupport/fontdatabases/windows/qwindowsdirectwritefontdatabase.cpp b/src/platformsupport/fontdatabases/windows/qwindowsdirectwritefontdatabase.cpp
index 5a1ff935b8..a0483c2413 100644
--- a/src/platformsupport/fontdatabases/windows/qwindowsdirectwritefontdatabase.cpp
+++ b/src/platformsupport/fontdatabases/windows/qwindowsdirectwritefontdatabase.cpp
@@ -40,6 +40,7 @@
 #include "qwindowsdirectwritefontdatabase_p.h"
 #include "qwindowsfontenginedirectwrite_p.h"
 
+#include <QtCore/qendian.h>
 #include <QtCore/qstringbuilder.h>
 #include <QtCore/qvarlengtharray.h>
 
@@ -174,16 +175,6 @@ void QWindowsDirectWriteFontDatabase::populateFamily(const QString &familyName)
                 if (defaultLocaleFamilyName.isEmpty() && englishLocaleFamilyName.isEmpty())
                     englishLocaleFamilyName = familyName;
 
-                QVarLengthArray<DWRITE_UNICODE_RANGE, 64> ranges(QFontDatabase::WritingSystemsCount);
-
-                uint count = 0;
-                if (SUCCEEDED(font1->GetUnicodeRanges(QFontDatabase::WritingSystemsCount, ranges.data(), &count))) {
-                    // ###
-                }
-                QSupportedWritingSystems writingSystems;
-                writingSystems.setSupported(QFontDatabase::Any);
-                writingSystems.setSupported(QFontDatabase::Latin);
-
                 {
                     IDWriteLocalizedStrings *names;
                     if (SUCCEEDED(font1->GetFaceNames(&names))) {
@@ -199,7 +190,47 @@ void QWindowsDirectWriteFontDatabase::populateFamily(const QString &familyName)
 
                         IDWriteFontFace *face = nullptr;
                         if (SUCCEEDED(font->CreateFontFace(&face))) {
+                            QSupportedWritingSystems writingSystems;
+
+                            const void *tableData = nullptr;
+                            UINT32 tableSize;
+                            void *tableContext = nullptr;
+                            BOOL exists;
+                            HRESULT hr = face->TryGetFontTable(qbswap<quint32>(MAKE_TAG('O','S','/','2')),
+                                                               &tableData,
+                                                               &tableSize,
+                                                               &tableContext,
+                                                               &exists);
+                            if (SUCCEEDED(hr) && exists) {
+                                writingSystems = QPlatformFontDatabase::writingSystemsFromOS2Table(reinterpret_cast<const char *>(tableData), tableSize);
+                            } else { // Fall back to checking first character of each Unicode range in font (may include too many writing systems)
+                                quint32 rangeCount;
+                                hr = font1->GetUnicodeRanges(0, nullptr, &rangeCount);
+
+                                if (rangeCount > 0) {
+                                    QVarLengthArray<DWRITE_UNICODE_RANGE, QChar::ScriptCount> ranges(rangeCount);
+
+                                    hr = font1->GetUnicodeRanges(rangeCount, ranges.data(), &rangeCount);
+                                    if (SUCCEEDED(hr)) {
+                                        for (uint i = 0; i < rangeCount; ++i) {
+                                            QChar::Script script = QChar::script(ranges.at(i).first);
+
+                                            Q_GUI_EXPORT QFontDatabase::WritingSystem qt_writing_system_for_script(int script);
+                                            QFontDatabase::WritingSystem writingSystem = qt_writing_system_for_script(script);
+
+                                            if (writingSystem > QFontDatabase::Any && writingSystem < QFontDatabase::WritingSystemsCount)
+                                                writingSystems.setSupported(writingSystem);
+                                        }
+                                    } else {
+                                        const QString errorString = qt_error_string(int(hr));
+                                        qCWarning(lcQpaFonts) << "Failed to get unicode ranges for font" << englishLocaleFamilyName << englishLocaleStyleName << ":" << errorString;
+                                    }
+                                }
+                            }
+
                             if (!englishLocaleStyleName.isEmpty() || defaultLocaleStyleName.isEmpty()) {
+                                qCDebug(lcQpaFonts) << "Font" << englishLocaleFamilyName << englishLocaleStyleName << "supports writing systems:" << writingSystems;
+
                                 QPlatformFontDatabase::registerFont(englishLocaleFamilyName, englishLocaleStyleName, QString(), weight, style, stretch, antialias, scalable, size, fixed, writingSystems, face);
                                 face->AddRef();
                             }
-- 
cgit v1.2.3