From 9b67d89c24666d405dd00e63bb56c924738aa002 Mon Sep 17 00:00:00 2001 From: Konstantin Ritt Date: Fri, 23 Jan 2015 13:05:12 +0400 Subject: Pass params of shareable type by const-ref rather than by value ...where passing them by value was not intentional. Change-Id: Ifd5036d57b41fddeeacfbd3f5890881605b80647 Reviewed-by: Shawn Rutledge Reviewed-by: Thiago Macieira --- src/platformsupport/services/genericunix/qgenericunixservices.cpp | 2 +- src/platformsupport/themes/genericunix/qgenericunixthemes.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'src/platformsupport') diff --git a/src/platformsupport/services/genericunix/qgenericunixservices.cpp b/src/platformsupport/services/genericunix/qgenericunixservices.cpp index 99ca855a28..b59ae431f4 100644 --- a/src/platformsupport/services/genericunix/qgenericunixservices.cpp +++ b/src/platformsupport/services/genericunix/qgenericunixservices.cpp @@ -72,7 +72,7 @@ static inline bool checkExecutable(const QString &candidate, QString *result) return !result->isEmpty(); } -static inline bool detectWebBrowser(QByteArray desktop, +static inline bool detectWebBrowser(const QByteArray &desktop, bool checkBrowserVariable, QString *browser) { diff --git a/src/platformsupport/themes/genericunix/qgenericunixthemes.cpp b/src/platformsupport/themes/genericunix/qgenericunixthemes.cpp index f8ced57553..3fffec0dfd 100644 --- a/src/platformsupport/themes/genericunix/qgenericunixthemes.cpp +++ b/src/platformsupport/themes/genericunix/qgenericunixthemes.cpp @@ -565,7 +565,7 @@ class QGnomeThemePrivate : public QPlatformThemePrivate { public: QGnomeThemePrivate() : fontsConfigured(false) { } - void configureFonts(QString gtkFontName) const + void configureFonts(const QString >kFontName) const { Q_ASSERT(!fontsConfigured); const int split = gtkFontName.lastIndexOf(QChar::Space); -- cgit v1.2.3