From 44e9e7fe199f197fe1e639e5fbcf858f4775d31b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tor=20Arne=20Vestb=C3=B8?= Date: Tue, 25 Nov 2014 15:43:52 +0100 Subject: iOS: Simplify view management in QIOSKeyboardListener We don't need to keep track of the view-controller or add ourselves as a gesture recognizer inside QIOSKeyboardListener. In fact, leaving the call to removeGestureRecognizer in [QIOSKeyboardListener dealloc] will result in QIOSKeyboardListener never being released, as the view that we add the recognizer to will keep a strong reference to the recognizer, so dealloc is never called unless the view is also released, which is unlikely to happen. We now fully control the lifetime of the recognizer. Change-Id: I6755e8cdfcc8f1062314db51aa54a2b7ecd1b967 Reviewed-by: Richard Moe Gustavsen --- src/plugins/platforms/ios/qiosinputcontext.h | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/plugins/platforms/ios/qiosinputcontext.h') diff --git a/src/plugins/platforms/ios/qiosinputcontext.h b/src/plugins/platforms/ios/qiosinputcontext.h index 174c44751c..eb6b04a2ac 100644 --- a/src/plugins/platforms/ios/qiosinputcontext.h +++ b/src/plugins/platforms/ios/qiosinputcontext.h @@ -91,6 +91,8 @@ public: static QIOSInputContext *instance(); private: + UIView* scrollableRootView(); + union { QIOSKeyboardListener *m_keyboardHideGesture; id m_keyboardState; -- cgit v1.2.3