From 3aaa5d6b32130d3eeac872a59a5a44bfb20dfd4a Mon Sep 17 00:00:00 2001 From: J-P Nurmi Date: Mon, 20 Jun 2016 10:35:56 +0200 Subject: Improve QGtk3FontDialogHelper::onAccepted() Call currentFont() only once. It does a conversion from a Pango font description string to a Qt font, so not entirely trivial operation. Change-Id: Ic67b7c5b0874621c51a5cce4766acd4243d3dfde Reviewed-by: Mitch Curtis --- src/plugins/platformthemes/gtk3/qgtk3dialoghelpers.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/plugins/platformthemes') diff --git a/src/plugins/platformthemes/gtk3/qgtk3dialoghelpers.cpp b/src/plugins/platformthemes/gtk3/qgtk3dialoghelpers.cpp index 488ae16123..fa92e49673 100644 --- a/src/plugins/platformthemes/gtk3/qgtk3dialoghelpers.cpp +++ b/src/plugins/platformthemes/gtk3/qgtk3dialoghelpers.cpp @@ -588,9 +588,10 @@ QFont QGtk3FontDialogHelper::currentFont() const void QGtk3FontDialogHelper::onAccepted() { - emit currentFontChanged(currentFont()); + const QFont font = currentFont(); + emit currentFontChanged(font); emit accept(); - emit fontSelected(currentFont()); + emit fontSelected(font); } void QGtk3FontDialogHelper::applyOptions() -- cgit v1.2.3