From 29fca29d1c448d563162e3daabb21f6e877ff07c Mon Sep 17 00:00:00 2001 From: Huang Jie Date: Tue, 3 Nov 2020 13:57:37 +0800 Subject: Reduce the scope of variables in bindInValues() The scope of the variables 'bind', 'field', 'i' can be reduced if the variable 'meta' is a null pointer. So declare the variables when the variable 'meta' is valid. Change-Id: I599406c034168dd73799c69dfb9c5e676861cdf2 Reviewed-by: Andy Shaw --- src/plugins/sqldrivers/mysql/qsql_mysql.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'src/plugins/sqldrivers') diff --git a/src/plugins/sqldrivers/mysql/qsql_mysql.cpp b/src/plugins/sqldrivers/mysql/qsql_mysql.cpp index 04a2df9ac5..7d945f23fc 100644 --- a/src/plugins/sqldrivers/mysql/qsql_mysql.cpp +++ b/src/plugins/sqldrivers/mysql/qsql_mysql.cpp @@ -317,15 +317,14 @@ void QMYSQLResultPrivate::bindBlobs() bool QMYSQLResultPrivate::bindInValues() { - MYSQL_BIND *bind; - char *field; - int i = 0; - if (!meta) meta = mysql_stmt_result_metadata(stmt); if (!meta) return false; + MYSQL_BIND *bind; + char *field; + int i = 0; fields.resize(mysql_num_fields(meta)); inBinds = new MYSQL_BIND[fields.size()]; -- cgit v1.2.3