From 825f98815683faea06144ab0262129b0367798ee Mon Sep 17 00:00:00 2001
From: Liang Qi <liang.qi@qt.io>
Date: Tue, 2 Oct 2018 12:59:24 +0200
Subject: Modernize the "textcodec" feature

Also clean up QTextCodec usage in qmake build and some includes
of qtextcodec.h.

Change-Id: I0475b82690024054add4e85a8724c8ea3adcf62a
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
---
 src/plugins/sqldrivers/mysql/qsql_mysql.cpp | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

(limited to 'src/plugins/sqldrivers')

diff --git a/src/plugins/sqldrivers/mysql/qsql_mysql.cpp b/src/plugins/sqldrivers/mysql/qsql_mysql.cpp
index 5a100b8075..49bceb88a0 100644
--- a/src/plugins/sqldrivers/mysql/qsql_mysql.cpp
+++ b/src/plugins/sqldrivers/mysql/qsql_mysql.cpp
@@ -48,7 +48,9 @@
 #include <qsqlquery.h>
 #include <qsqlrecord.h>
 #include <qstringlist.h>
+#if QT_CONFIG(textcodec)
 #include <qtextcodec.h>
+#endif
 #include <qvector.h>
 #include <qfile.h>
 #include <qdebug.h>
@@ -82,7 +84,7 @@ class QMYSQLDriverPrivate : public QSqlDriverPrivate
 
 public:
     QMYSQLDriverPrivate() : QSqlDriverPrivate(), mysql(0),
-#ifndef QT_NO_TEXTCODEC
+#if QT_CONFIG(textcodec)
         tc(QTextCodec::codecForLocale()),
 #else
         tc(0),
@@ -96,7 +98,7 @@ public:
 
 static inline QString toUnicode(QTextCodec *tc, const char *str)
 {
-#ifdef QT_NO_TEXTCODEC
+#if !QT_CONFIG(textcodec)
     Q_UNUSED(tc);
     return QString::fromLatin1(str);
 #else
@@ -106,7 +108,7 @@ static inline QString toUnicode(QTextCodec *tc, const char *str)
 
 static inline QString toUnicode(QTextCodec *tc, const char *str, int length)
 {
-#ifdef QT_NO_TEXTCODEC
+#if !QT_CONFIG(textcodec)
     Q_UNUSED(tc);
     return QString::fromLatin1(str, length);
 #else
@@ -116,7 +118,7 @@ static inline QString toUnicode(QTextCodec *tc, const char *str, int length)
 
 static inline QByteArray fromUnicode(QTextCodec *tc, const QString &str)
 {
-#ifdef QT_NO_TEXTCODEC
+#if !QT_CONFIG(textcodec)
     Q_UNUSED(tc);
     return str.toLatin1();
 #else
@@ -251,7 +253,7 @@ public:
     bool preparedQuery;
 };
 
-#ifndef QT_NO_TEXTCODEC
+#if QT_CONFIG(textcodec)
 static QTextCodec* codec(MYSQL* mysql)
 {
 #if MYSQL_VERSION_ID >= 32321
@@ -261,7 +263,7 @@ static QTextCodec* codec(MYSQL* mysql)
 #endif
     return QTextCodec::codecForLocale();
 }
-#endif // QT_NO_TEXTCODEC
+#endif // textcodec
 
 static QSqlError qMakeError(const QString& err, QSqlError::ErrorType type,
                             const QMYSQLDriverPrivate* p)
@@ -1199,7 +1201,7 @@ QMYSQLDriver::QMYSQLDriver(MYSQL * con, QObject * parent)
     init();
     if (con) {
         d->mysql = (MYSQL *) con;
-#ifndef QT_NO_TEXTCODEC
+#if QT_CONFIG(textcodec)
         d->tc = codec(con);
 #endif
         setOpen(true);
@@ -1428,14 +1430,14 @@ bool QMYSQLDriver::open(const QString& db,
     if (mysql_get_client_version() >= 50503 && mysql_get_server_version(d->mysql) >= 50503) {
         // force the communication to be utf8mb4 (only utf8mb4 supports 4-byte characters)
         mysql_set_character_set(d->mysql, "utf8mb4");
-#ifndef QT_NO_TEXTCODEC
+#if QT_CONFIG(textcodec)
         d->tc = QTextCodec::codecForName("UTF-8");
 #endif
     } else
     {
         // force the communication to be utf8
         mysql_set_character_set(d->mysql, "utf8");
-#ifndef QT_NO_TEXTCODEC
+#if QT_CONFIG(textcodec)
         d->tc = codec(d->mysql);
 #endif
     }
-- 
cgit v1.2.3


From 521a85395da1a2728902816c072ec46bcb0ad380 Mon Sep 17 00:00:00 2001
From: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Date: Fri, 1 Dec 2017 20:13:08 +0100
Subject: configure: actually resolve libraries into full filepaths

this considerably speeds up failures, as no doomed build is attempted,
and produces more reliable results, as no second lookup (which would be
subject to environment changes) is done any more during the build.

in principle, this also opens up possibilities like selecting specific
variants of dependencies, automatically extracting rpaths, etc.

qt_helper_lib.prf also needs to create fully resolved library names now.

Change-Id: I65f13564b635433030e40fa017427bbc72d1c130
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
---
 src/plugins/sqldrivers/configure.pri | 50 +++++++++++++-----------------------
 1 file changed, 18 insertions(+), 32 deletions(-)

(limited to 'src/plugins/sqldrivers')

diff --git a/src/plugins/sqldrivers/configure.pri b/src/plugins/sqldrivers/configure.pri
index 24954e9514..747a47e7b8 100644
--- a/src/plugins/sqldrivers/configure.pri
+++ b/src/plugins/sqldrivers/configure.pri
@@ -1,29 +1,16 @@
 # custom tests
 
-defineReplace(filterLibraryPath) {
-    str = $${1}
-    for (l, QMAKE_DEFAULT_LIBDIRS): \
-        str -= "-L$$l"
-
-    return($$str)
-}
-
 defineTest(qtConfLibrary_psqlConfig) {
     pg_config = $$config.input.psql_config
     isEmpty(pg_config): \
         pg_config = $$qtConfFindInPath("pg_config")
     !win32:!isEmpty(pg_config) {
         qtRunLoggedCommand("$$pg_config --libdir", libdir)|return(false)
+        !qtConfResolvePathLibs($${1}.libs, $$libdir, -lpq): \
+            return(false)
         qtRunLoggedCommand("$$pg_config --includedir", includedir)|return(false)
-        libdir -= $$QMAKE_DEFAULT_LIBDIRS
-        libs =
-        !isEmpty(libdir): libs += "-L$$libdir"
-        libs += "-lpq"
-        $${1}.libs = $$libs
-        includedir -= $$QMAKE_DEFAULT_INCDIRS
-        $${1}.includedir = $$includedir
-        export($${1}.libs)
-        export($${1}.includedir)
+        !qtConfResolvePathIncs($${1}.includedir, $$includedir): \
+            return(false)
         return(true)
     }
     qtLog("pg_config not found.")
@@ -34,8 +21,9 @@ defineTest(qtConfLibrary_psqlEnv) {
     # Respect PSQL_LIBS if set
     PSQL_LIBS = $$getenv(PSQL_LIBS)
     !isEmpty(PSQL_LIBS) {
-        eval($${1}.libs = $$PSQL_LIBS)
-        export($${1}.libs)
+        eval(libs = $$PSQL_LIBS)
+        !qtConfResolveLibs($${1}.libs, $$libs): \
+            return(false)
     } else {
         !qtConfLibrary_inline($$1, $$2): \
             return(false)
@@ -58,7 +46,6 @@ defineTest(qtConfLibrary_mysqlConfig) {
         qtRunLoggedCommand("$$mysql_config $$query", libs)|return(false)
         qtRunLoggedCommand("$$mysql_config --include", includedir)|return(false)
         eval(libs = $$libs)
-        libs = $$filterLibraryPath($$libs)
         # -rdynamic should not be returned by mysql_config, but is on RHEL 6.6
         libs -= -rdynamic
         equals($${1}.cleanlibs, true) {
@@ -69,16 +56,15 @@ defineTest(qtConfLibrary_mysqlConfig) {
             }
             libs = $$cleanlibs
         }
-        $${1}.libs = $$libs
+        !qtConfResolveLibs($${1}.libs, $$libs): \
+            return(false)
         eval(rawincludedir = $$includedir)
         rawincludedir ~= s/^-I//g
         includedir =
         for (id, rawincludedir): \
             includedir += $$clean_path($$id)
-        includedir -= $$QMAKE_DEFAULT_INCDIRS
-        $${1}.includedir = $$includedir
-        export($${1}.libs)
-        export($${1}.includedir)
+        !qtConfResolvePathIncs($${1}.includedir, $$includedir): \
+            return(false)
         return(true)
     }
     qtLog("mysql_config not found.")
@@ -86,14 +72,14 @@ defineTest(qtConfLibrary_mysqlConfig) {
 }
 
 defineTest(qtConfLibrary_sybaseEnv) {
-    libs =
+    libdir =
     sybase = $$getenv(SYBASE)
     !isEmpty(sybase): \
-        libs += "-L$${sybase}/lib"
-    eval(libs += $$getenv(SYBASE_LIBS))
-    !isEmpty(libs) {
-        $${1}.libs = $$libs
-        export($${1}.libs)
-    }
+        libdir += $${sybase}/lib
+    eval(libs = $$getenv(SYBASE_LIBS))
+    isEmpty(libs): \
+        libs = $$eval($${1}.libs)
+    !qtConfResolvePathLibs($${1}.libs, $$libdir, $$libs): \
+        return(false)
     return(true)
 }
-- 
cgit v1.2.3


From 97d8be10cd97cf997286ed0ca0a5d8b360fa942e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Vr=C3=A1til?= <dvratil@kde.org>
Date: Sat, 1 Dec 2018 17:56:41 +0100
Subject: MySQL: Free the results when QSqlQuery::finished() is called

Calling mysql_stmt_free_result() frees the results of the last
executed query while keeping the prepared statement valid. This
allows to keep around prepared QSqlQueries without the overhead
of keeping all the results in memory.

Change-Id: I4589e90857cc4e9a6f9612799bfca967a67e2ab2
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Andy Shaw <andy.shaw@qt.io>
---
 src/plugins/sqldrivers/mysql/qsql_mysql.cpp | 10 ++++++++++
 1 file changed, 10 insertions(+)

(limited to 'src/plugins/sqldrivers')

diff --git a/src/plugins/sqldrivers/mysql/qsql_mysql.cpp b/src/plugins/sqldrivers/mysql/qsql_mysql.cpp
index f2ae3fbc47..80c0c9c522 100644
--- a/src/plugins/sqldrivers/mysql/qsql_mysql.cpp
+++ b/src/plugins/sqldrivers/mysql/qsql_mysql.cpp
@@ -197,6 +197,7 @@ protected:
     QSqlRecord record() const override;
     void virtual_hook(int id, void *data) override;
     bool nextResult() override;
+    void detachFromResultSet() override;
 
 #if MYSQL_VERSION_ID >= 40108
     bool prepare(const QString &stmt) override;
@@ -804,6 +805,15 @@ int QMYSQLResult::numRowsAffected()
     return d->rowsAffected;
 }
 
+void QMYSQLResult::detachFromResultSet()
+{
+    Q_D(QMYSQLResult);
+
+    if (d->preparedQuery) {
+        mysql_stmt_free_result(d->stmt);
+    }
+}
+
 QVariant QMYSQLResult::lastInsertId() const
 {
     Q_D(const QMYSQLResult);
-- 
cgit v1.2.3


From 19d7bd3d638c8962343927a161ce3f1cfdcb3e6a Mon Sep 17 00:00:00 2001
From: Sergio Martins <iamsergio@gmail.com>
Date: Thu, 29 Nov 2018 13:23:00 +0000
Subject: Fix a couple of unused QStrings

This is needed so we can add Q_WARN_UNUSED to QString.
The xcb one might even be a bug.

Change-Id: Ia2d2563bdd10aa747014410df4990597969f4634
Reviewed-by: Gatis Paeglis <gatis.paeglis@qt.io>
Reviewed-by: Andy Shaw <andy.shaw@qt.io>
---
 src/plugins/sqldrivers/odbc/qsql_odbc.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/plugins/sqldrivers')

diff --git a/src/plugins/sqldrivers/odbc/qsql_odbc.cpp b/src/plugins/sqldrivers/odbc/qsql_odbc.cpp
index 1fbbcd0ef1..7f98efccba 100644
--- a/src/plugins/sqldrivers/odbc/qsql_odbc.cpp
+++ b/src/plugins/sqldrivers/odbc/qsql_odbc.cpp
@@ -345,7 +345,7 @@ static QSqlError qMakeError(const QString& err, QSqlError::ErrorType type,
 {
     int nativeCode = -1;
     QString message = qODBCWarn(p, &nativeCode);
-    return QSqlError(QLatin1String("QODBC3: ") + err, qODBCWarn(p), type,
+    return QSqlError(QLatin1String("QODBC3: ") + err, message, type,
                      nativeCode != -1 ? QString::number(nativeCode) : QString());
 }
 
-- 
cgit v1.2.3


From e80bf655e922e9864f8843b5e7bbb47019a6d95a Mon Sep 17 00:00:00 2001
From: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Date: Thu, 7 Dec 2017 19:30:07 +0100
Subject: configure: verify header presence against sources

in addition to the actual library resolution, also resolve the headers
belonging to the library, to validate the include path, and possibly
ensure that the right version of the library is present.

the "include" entries were moved out of the "test" objects, and renamed
to "headers". this cleanly permits libraries without compile tests.

the headers were not put into the sources, because the variance among
the includes is generally orthogonal to the variance among the
libraries.

note that this - like the library resolution - provides no support for
darwin frameworks. consequently, the opengl libraries are excluded from
the conversion on darwin.

similarly, wasm is excluded (centrally), because emcc is magic and would
need advanced wizardry to be dealt with.

Change-Id: Ib390c75371efa2badcfec9b74274047ce67c3e5a
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
---
 src/plugins/sqldrivers/configure.json | 33 ++++++++++++++-------------------
 src/plugins/sqldrivers/configure.pri  |  4 ++--
 2 files changed, 16 insertions(+), 21 deletions(-)

(limited to 'src/plugins/sqldrivers')

diff --git a/src/plugins/sqldrivers/configure.json b/src/plugins/sqldrivers/configure.json
index 4802d3b04d..cd20eef1df 100644
--- a/src/plugins/sqldrivers/configure.json
+++ b/src/plugins/sqldrivers/configure.json
@@ -39,9 +39,8 @@
     "libraries": {
         "db2": {
             "label": "DB2 (IBM)",
-            "test": {
-                "include": [ "sqlcli.h", "sqlcli1.h" ]
-            },
+            "test": {},
+            "headers": [ "sqlcli.h", "sqlcli1.h" ],
             "sources": [
                 { "libs": "-ldb2cli", "condition": "config.win32" },
                 { "libs": "-ldb2", "condition": "!config.win32" }
@@ -49,9 +48,8 @@
         },
         "ibase": {
             "label": "InterBase",
-            "test": {
-                "include": "ibase.h"
-            },
+            "test": {},
+            "headers": "ibase.h",
             "sources": [
                 { "libs": "-lgds32_ms", "condition": "config.win32" },
                 { "libs": "-lgds", "condition": "!config.win32" }
@@ -65,9 +63,9 @@
                     "#  include <windows.h>",
                     "#endif"
                 ],
-                "include": "mysql.h",
                 "main": "mysql_get_client_version();"
             },
+            "headers": "mysql.h",
             "sources": [
                 { "type": "mysqlConfig", "query": "--libs_r", "cleanlibs": true },
                 { "type": "mysqlConfig", "query": "--libs", "cleanlibs": true },
@@ -81,12 +79,12 @@
         "psql": {
             "label": "PostgreSQL",
             "test": {
-                "include": "libpq-fe.h",
                 "main": [
                     "PQescapeBytea(0, 0, 0);",
                     "PQunescapeBytea(0, 0);"
                 ]
             },
+            "headers": "libpq-fe.h",
             "sources": [
                 { "type": "pkgConfig", "args": "libpq" },
                 { "type": "psqlConfig" },
@@ -96,9 +94,8 @@
         },
         "tds": {
             "label": "TDS (Sybase)",
-            "test": {
-                "include": [ "sybfront.h", "sybdb.h" ]
-            },
+            "test": {},
+            "headers": [ "sybfront.h", "sybdb.h" ],
             "sources": [
                 { "type": "sybaseEnv", "libs": "-lNTWDBLIB", "condition": "config.win32" },
                 { "type": "sybaseEnv", "libs": "-lsybdb", "condition": "!config.win32" }
@@ -106,9 +103,8 @@
         },
         "oci": {
             "label": "OCI (Oracle)",
-            "test": {
-                "include": "oci.h"
-            },
+            "test": {},
+            "headers": "oci.h",
             "sources": [
                 { "libs": "-loci", "condition": "config.win32" },
                 { "libs": "-lclntsh", "condition": "!config.win32" }
@@ -122,12 +118,12 @@
                     "#  include <windows.h>",
                     "#endif"
                 ],
-                "include": [ "sql.h", "sqlext.h" ],
                 "main": [
                     "SQLHANDLE env;",
                     "SQLAllocHandle(SQL_HANDLE_ENV, SQL_NULL_HANDLE, &env);"
                 ]
             },
+            "headers": [ "sql.h", "sqlext.h" ],
             "sources": [
                 { "libs": "-lodbc32", "condition": "config.win32" },
                 { "libs": "-liodbc", "condition": "config.darwin" },
@@ -136,9 +132,8 @@
         },
         "sqlite2": {
             "label": "SQLite (version 2)",
-            "test": {
-                "include": "sqlite.h"
-            },
+            "test": {},
+            "headers": "sqlite.h",
             "sources": [
                 "-lsqlite"
             ]
@@ -147,9 +142,9 @@
             "label": "SQLite (version 3)",
             "export": "sqlite",
             "test": {
-                "include": "sqlite3.h",
                 "main": "sqlite3_open_v2(0, 0, 0, 0);"
             },
+            "headers": "sqlite3.h",
             "sources": [
                 { "type": "pkgConfig", "args": "sqlite3" },
                 "-lsqlite3"
diff --git a/src/plugins/sqldrivers/configure.pri b/src/plugins/sqldrivers/configure.pri
index 747a47e7b8..84c8114c7b 100644
--- a/src/plugins/sqldrivers/configure.pri
+++ b/src/plugins/sqldrivers/configure.pri
@@ -9,7 +9,7 @@ defineTest(qtConfLibrary_psqlConfig) {
         !qtConfResolvePathLibs($${1}.libs, $$libdir, -lpq): \
             return(false)
         qtRunLoggedCommand("$$pg_config --includedir", includedir)|return(false)
-        !qtConfResolvePathIncs($${1}.includedir, $$includedir): \
+        !qtConfResolvePathIncs($${1}.includedir, $$includedir, $$2): \
             return(false)
         return(true)
     }
@@ -63,7 +63,7 @@ defineTest(qtConfLibrary_mysqlConfig) {
         includedir =
         for (id, rawincludedir): \
             includedir += $$clean_path($$id)
-        !qtConfResolvePathIncs($${1}.includedir, $$includedir): \
+        !qtConfResolvePathIncs($${1}.includedir, $$includedir, $$2): \
             return(false)
         return(true)
     }
-- 
cgit v1.2.3


From 3a74a3b5a644ac196942c717d31cd5f8438f3c0b Mon Sep 17 00:00:00 2001
From: Christian Ehrlicher <ch.ehrlicher@gmx.de>
Date: Thu, 20 Dec 2018 09:13:26 +0100
Subject: QSQL: add support for PostgreSQL 11

Add support for PostgreSQL 11 by adding QPSQLDriver::Version11 and use
it in qMakePSQLVersion().

[ChangeLog][QSQL][PostgreSQL] Added support for PostgreSQL 11

Fixes: QTBUG-71642
Change-Id: Ie3cd3a81fd00084b587457b91b4e92c2e7001172
Reviewed-by: Andy Shaw <andy.shaw@qt.io>
Reviewed-by: Robert Szefner <robertsz27@interia.pl>
---
 src/plugins/sqldrivers/psql/qsql_psql.cpp | 4 +++-
 src/plugins/sqldrivers/psql/qsql_psql_p.h | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

(limited to 'src/plugins/sqldrivers')

diff --git a/src/plugins/sqldrivers/psql/qsql_psql.cpp b/src/plugins/sqldrivers/psql/qsql_psql.cpp
index bf0493b0c3..7ad9db1ea8 100644
--- a/src/plugins/sqldrivers/psql/qsql_psql.cpp
+++ b/src/plugins/sqldrivers/psql/qsql_psql.cpp
@@ -1060,8 +1060,10 @@ static QPSQLDriver::Protocol qMakePSQLVersion(int vMaj, int vMin)
     }
     case 10:
         return QPSQLDriver::Version10;
+    case 11:
+        return QPSQLDriver::Version11;
     default:
-        if (vMaj > 10)
+        if (vMaj > 11)
             return QPSQLDriver::UnknownLaterVersion;
         break;
     }
diff --git a/src/plugins/sqldrivers/psql/qsql_psql_p.h b/src/plugins/sqldrivers/psql/qsql_psql_p.h
index 2873a9f851..7e1849d857 100644
--- a/src/plugins/sqldrivers/psql/qsql_psql_p.h
+++ b/src/plugins/sqldrivers/psql/qsql_psql_p.h
@@ -92,6 +92,7 @@ public:
         Version9_5 = 21,
         Version9_6 = 22,
         Version10 = 23,
+        Version11 = 24,
         UnknownLaterVersion = 100000
     };
 
-- 
cgit v1.2.3


From 8551b7d93ce3767b2cebb0d442e72d8ad450539e Mon Sep 17 00:00:00 2001
From: Christian Ehrlicher <ch.ehrlicher@gmx.de>
Date: Thu, 20 Dec 2018 09:51:30 +0100
Subject: QSQL: cleanup/modernize PostgreSQL plugin

Cleanup/modernize the PostgreSQL plugin
 - use nullptr
 - use range-based for loop
 - use QStringLiteral or QByteArray::fromRawData instead
   QLatin1String/QString::fromLatin1 where possible
 - use QRegularExpression instead QRegExp
 - use QQueue instead QList
 - uppercase SQL keywords

Change-Id: Ie22be1538328ff1e2b663066ede96741d271e050
Reviewed-by: Andy Shaw <andy.shaw@qt.io>
---
 src/plugins/sqldrivers/psql/main.cpp      |   8 +-
 src/plugins/sqldrivers/psql/qsql_psql.cpp | 167 ++++++++++++++++--------------
 src/plugins/sqldrivers/psql/qsql_psql_p.h |   4 +-
 3 files changed, 94 insertions(+), 85 deletions(-)

(limited to 'src/plugins/sqldrivers')

diff --git a/src/plugins/sqldrivers/psql/main.cpp b/src/plugins/sqldrivers/psql/main.cpp
index c5d546f6ff..a0862a238a 100644
--- a/src/plugins/sqldrivers/psql/main.cpp
+++ b/src/plugins/sqldrivers/psql/main.cpp
@@ -61,11 +61,9 @@ QPSQLDriverPlugin::QPSQLDriverPlugin()
 
 QSqlDriver* QPSQLDriverPlugin::create(const QString &name)
 {
-    if (name == QLatin1String("QPSQL") || name == QLatin1String("QPSQL7")) {
-        QPSQLDriver* driver = new QPSQLDriver();
-        return driver;
-    }
-    return 0;
+    if (name == QLatin1String("QPSQL") || name == QLatin1String("QPSQL7"))
+        return new QPSQLDriver;
+    return nullptr;
 }
 
 QT_END_NAMESPACE
diff --git a/src/plugins/sqldrivers/psql/qsql_psql.cpp b/src/plugins/sqldrivers/psql/qsql_psql.cpp
index 7ad9db1ea8..9fc9317da6 100644
--- a/src/plugins/sqldrivers/psql/qsql_psql.cpp
+++ b/src/plugins/sqldrivers/psql/qsql_psql.cpp
@@ -42,7 +42,7 @@
 #include <qcoreapplication.h>
 #include <qvariant.h>
 #include <qdatetime.h>
-#include <qregexp.h>
+#include <qregularexpression.h>
 #include <qsqlerror.h>
 #include <qsqlfield.h>
 #include <qsqlindex.h>
@@ -54,6 +54,8 @@
 #include <QtSql/private/qsqlresult_p.h>
 #include <QtSql/private/qsqldriver_p.h>
 
+#include <queue>
+
 #include <libpq-fe.h>
 #include <pg_config.h>
 
@@ -147,10 +149,10 @@ class QPSQLDriverPrivate final : public QSqlDriverPrivate
     Q_DECLARE_PUBLIC(QPSQLDriver)
 public:
     QPSQLDriverPrivate() : QSqlDriverPrivate(),
-        connection(0),
+        connection(nullptr),
         isUtf8(false),
         pro(QPSQLDriver::Version6),
-        sn(0),
+        sn(nullptr),
         pendingNotifyCheck(false),
         hasBackslashEscape(false),
         stmtCount(0),
@@ -187,11 +189,13 @@ public:
 
 void QPSQLDriverPrivate::appendTables(QStringList &tl, QSqlQuery &t, QChar type)
 {
-    QString query = QString::fromLatin1("select pg_class.relname, pg_namespace.nspname from pg_class "
-                                        "left join pg_namespace on (pg_class.relnamespace = pg_namespace.oid) "
-                                        "where (pg_class.relkind = '%1') and (pg_class.relname !~ '^Inv') "
-                                        "and (pg_class.relname !~ '^pg_') "
-                                        "and (pg_namespace.nspname != 'information_schema')").arg(type);
+    const QString query =
+            QStringLiteral("SELECT pg_class.relname, pg_namespace.nspname FROM pg_class "
+                           "LEFT JOIN pg_namespace ON (pg_class.relnamespace = pg_namespace.oid) "
+                           "WHERE (pg_class.relkind = '") + type +
+            QStringLiteral("') AND (pg_class.relname !~ '^Inv') "
+                           "AND (pg_class.relname !~ '^pg_') "
+                           "AND (pg_namespace.nspname != 'information_schema')");
     t.exec(query);
     while (t.next()) {
         QString schema = t.value(1).toString();
@@ -294,10 +298,10 @@ public:
     Q_DECLARE_SQLDRIVER_PRIVATE(QPSQLDriver)
     QPSQLResultPrivate(QPSQLResult *q, const QPSQLDriver *drv)
       : QSqlResultPrivate(q, drv),
-        result(0),
+        result(nullptr),
+        stmtId(InvalidStatementId),
         currentSize(-1),
         canFetchMoreRows(false),
-        stmtId(InvalidStatementId),
         preparedQueriesEnabled(false)
     { }
 
@@ -305,12 +309,12 @@ public:
     void deallocatePreparedStmt();
 
     PGresult *result;
-    QList<PGresult*> nextResultSets;
+    std::queue<PGresult*> nextResultSets;
+    QString preparedStmtId;
+    StatementId stmtId;
     int currentSize;
     bool canFetchMoreRows;
-    StatementId stmtId;
     bool preparedQueriesEnabled;
-    QString preparedStmtId;
 
     bool processResults();
 };
@@ -423,7 +427,7 @@ static QVariant::Type qDecodePSQLType(int t)
 
 void QPSQLResultPrivate::deallocatePreparedStmt()
 {
-    const QString stmt = QLatin1String("DEALLOCATE ") + preparedStmtId;
+    const QString stmt = QStringLiteral("DEALLOCATE ") + preparedStmtId;
     PGresult *result = drv_d_func()->exec(stmt);
 
     if (PQresultStatus(result) != PGRES_COMMAND_OK)
@@ -460,8 +464,10 @@ void QPSQLResult::cleanup()
     if (d->result)
         PQclear(d->result);
     d->result = nullptr;
-    while (!d->nextResultSets.isEmpty())
-        PQclear(d->nextResultSets.takeFirst());
+    while (!d->nextResultSets.empty()) {
+        PQclear(d->nextResultSets.front());
+        d->nextResultSets.pop();
+    }
     if (d->stmtId != InvalidStatementId) {
         if (d->drv_d_func())
             d->drv_d_func()->finishQuery(d->stmtId);
@@ -622,7 +628,11 @@ bool QPSQLResult::nextResult()
 
     if (d->result)
         PQclear(d->result);
-    d->result = d->nextResultSets.isEmpty() ? nullptr : d->nextResultSets.takeFirst();
+    d->result = nullptr;
+    if (!d->nextResultSets.empty()) {
+        d->result = d->nextResultSets.front();
+        d->nextResultSets.pop();
+    }
     return d->processResults();
 }
 
@@ -646,9 +656,9 @@ QVariant QPSQLResult::data(int i)
         return d->drv_d_func()->isUtf8 ? QString::fromUtf8(val) : QString::fromLatin1(val);
     case QVariant::LongLong:
         if (val[0] == '-')
-            return QString::fromLatin1(val).toLongLong();
+            return QByteArray::fromRawData(val, qstrlen(val)).toLongLong();
         else
-            return QString::fromLatin1(val).toULongLong();
+            return QByteArray::fromRawData(val, qstrlen(val)).toULongLong();
     case QVariant::Int:
         return atoi(val);
     case QVariant::Double: {
@@ -754,7 +764,7 @@ bool QPSQLResult::reset (const QString& query)
     if (!isForwardOnly()) {
         // Fetch all result sets right away
         while (PGresult *nextResultSet = d->drv_d_func()->getResult(d->stmtId))
-            d->nextResultSets.append(nextResultSet);
+            d->nextResultSets.push(nextResultSet);
     }
     return d->processResults();
 }
@@ -768,7 +778,8 @@ int QPSQLResult::size()
 int QPSQLResult::numRowsAffected()
 {
     Q_D(const QPSQLResult);
-    return QString::fromLatin1(PQcmdTuples(d->result)).toInt();
+    const char *tuples = PQcmdTuples(d->result);
+    return QByteArray::fromRawData(tuples, qstrlen(tuples)).toInt();
 }
 
 QVariant QPSQLResult::lastInsertId() const
@@ -777,7 +788,7 @@ QVariant QPSQLResult::lastInsertId() const
     if (d->drv_d_func()->pro >= QPSQLDriver::Version8_1) {
         QSqlQuery qry(driver()->createResult());
         // Most recent sequence value obtained from nextval
-        if (qry.exec(QLatin1String("SELECT lastval();")) && qry.next())
+        if (qry.exec(QStringLiteral("SELECT lastval();")) && qry.next())
             return qry.value(0);
     } else if (isActive()) {
         Oid id = PQoidValue(d->result);
@@ -868,15 +879,13 @@ static QString qCreateParamString(const QVector<QVariant> &boundValues, const QS
 
     QString params;
     QSqlField f;
-    for (int i = 0; i < boundValues.count(); ++i) {
-        const QVariant &val = boundValues.at(i);
-
+    for (const QVariant &val : boundValues) {
         f.setType(val.type());
         if (val.isNull())
             f.clear();
         else
             f.setValue(val);
-        if(!params.isNull())
+        if (!params.isNull())
             params.append(QLatin1String(", "));
         params.append(driver->formatValue(f));
     }
@@ -886,7 +895,7 @@ static QString qCreateParamString(const QVector<QVariant> &boundValues, const QS
 QString qMakePreparedStmtId()
 {
     static QBasicAtomicInt qPreparedStmtCount = Q_BASIC_ATOMIC_INITIALIZER(0);
-    QString id = QLatin1String("qpsqlpstmt_") + QString::number(qPreparedStmtCount.fetchAndAddRelaxed(1) + 1, 16);
+    QString id = QStringLiteral("qpsqlpstmt_") + QString::number(qPreparedStmtCount.fetchAndAddRelaxed(1) + 1, 16);
     return id;
 }
 
@@ -902,7 +911,7 @@ bool QPSQLResult::prepare(const QString &query)
         d->deallocatePreparedStmt();
 
     const QString stmtId = qMakePreparedStmtId();
-    const QString stmt = QString::fromLatin1("PREPARE %1 AS ").arg(stmtId).append(d->positionalToNamedBinding(query));
+    const QString stmt = QStringLiteral("PREPARE %1 AS ").arg(stmtId).append(d->positionalToNamedBinding(query));
 
     PGresult *result = d->drv_d_func()->exec(stmt);
 
@@ -930,9 +939,9 @@ bool QPSQLResult::exec()
     QString stmt;
     const QString params = qCreateParamString(boundValues(), driver());
     if (params.isEmpty())
-        stmt = QString::fromLatin1("EXECUTE %1").arg(d->preparedStmtId);
+        stmt = QStringLiteral("EXECUTE %1").arg(d->preparedStmtId);
     else
-        stmt = QString::fromLatin1("EXECUTE %1 (%2)").arg(d->preparedStmtId, params);
+        stmt = QStringLiteral("EXECUTE %1 (%2)").arg(d->preparedStmtId, params);
 
     d->stmtId = d->drv_d_func()->sendQuery(stmt);
     if (d->stmtId == InvalidStatementId) {
@@ -948,7 +957,7 @@ bool QPSQLResult::exec()
     if (!isForwardOnly()) {
         // Fetch all result sets right away
         while (PGresult *nextResultSet = d->drv_d_func()->getResult(d->stmtId))
-            d->nextResultSets.append(nextResultSet);
+            d->nextResultSets.push(nextResultSet);
     }
     return d->processResults();
 }
@@ -994,7 +1003,7 @@ void QPSQLDriverPrivate::detectBackslashEscape()
         hasBackslashEscape = true;
     } else {
         hasBackslashEscape = false;
-        PGresult* result = exec(QLatin1String("SELECT '\\\\' x"));
+        PGresult* result = exec(QStringLiteral("SELECT '\\\\' x"));
         int status = PQresultStatus(result);
         if (status == PGRES_COMMAND_OK || status == PGRES_TUPLES_OK)
             if (QString::fromLatin1(PQgetvalue(result, 0, 0)) == QLatin1String("\\"))
@@ -1072,20 +1081,21 @@ static QPSQLDriver::Protocol qMakePSQLVersion(int vMaj, int vMin)
 
 static QPSQLDriver::Protocol qFindPSQLVersion(const QString &versionString)
 {
-    const QRegExp rx(QStringLiteral("(\\d+)(?:\\.(\\d+))?"));
-    if (rx.indexIn(versionString) != -1) {
+    const QRegularExpression rx(QStringLiteral("(\\d+)(?:\\.(\\d+))?"));
+    const QRegularExpressionMatch match = rx.match(versionString);
+    if (match.hasMatch()) {
         // Beginning with PostgreSQL version 10, a major release is indicated by
         // increasing the first part of the version, e.g. 10 to 11.
         // Before version 10, a major release was indicated by increasing either
         // the first or second part of the version number, e.g. 9.5 to 9.6.
-        int vMaj = rx.cap(1).toInt();
+        int vMaj = match.capturedRef(1).toInt();
         int vMin;
         if (vMaj >= 10) {
             vMin = 0;
         } else {
-            if (rx.cap(2).isEmpty())
+            if (match.capturedRef(2).isEmpty())
                 return QPSQLDriver::VersionUnknown;
-            vMin = rx.cap(2).toInt();
+            vMin = match.capturedRef(2).toInt();
         }
         return qMakePSQLVersion(vMaj, vMin);
     }
@@ -1096,7 +1106,7 @@ static QPSQLDriver::Protocol qFindPSQLVersion(const QString &versionString)
 QPSQLDriver::Protocol QPSQLDriverPrivate::getPSQLVersion()
 {
     QPSQLDriver::Protocol serverVersion = QPSQLDriver::Version6;
-    PGresult* result = exec("select version()");
+    PGresult* result = exec("SELECT version()");
     int status = PQresultStatus(result);
     if (status == PGRES_COMMAND_OK || status == PGRES_TUPLES_OK) {
         serverVersion = qFindPSQLVersion(
@@ -1355,8 +1365,8 @@ QStringList QPSQLDriver::tables(QSql::TableType type) const
     if (type & QSql::Views)
         const_cast<QPSQLDriverPrivate*>(d)->appendTables(tl, t, QLatin1Char('v'));
     if (type & QSql::SystemTables) {
-        t.exec(QLatin1String("select relname from pg_class where (relkind = 'r') "
-                "and (relname like 'pg_%') "));
+        t.exec(QStringLiteral("SELECT relname FROM pg_class WHERE (relkind = 'r') "
+                              "AND (relname LIKE 'pg_%') "));
         while (t.next())
             tl.append(t.value(0).toString());
     }
@@ -1394,20 +1404,20 @@ QSqlIndex QPSQLDriver::primaryIndex(const QString& tablename) const
     else
         schema = std::move(schema).toLower();
 
-    QString stmt = QLatin1String("SELECT pg_attribute.attname, pg_attribute.atttypid::int, "
-                                 "pg_class.relname "
-                                 "FROM pg_attribute, pg_class "
-                                 "WHERE %1 pg_class.oid IN "
-                                 "(SELECT indexrelid FROM pg_index WHERE indisprimary = true AND indrelid IN "
-                                 "(SELECT oid FROM pg_class WHERE relname = '%2')) "
-                                 "AND pg_attribute.attrelid = pg_class.oid "
-                                 "AND pg_attribute.attisdropped = false "
-                                 "ORDER BY pg_attribute.attnum");
+    QString stmt = QStringLiteral("SELECT pg_attribute.attname, pg_attribute.atttypid::int, "
+                                  "pg_class.relname "
+                                  "FROM pg_attribute, pg_class "
+                                  "WHERE %1 pg_class.oid IN "
+                                  "(SELECT indexrelid FROM pg_index WHERE indisprimary = true AND indrelid IN "
+                                  "(SELECT oid FROM pg_class WHERE relname = '%2')) "
+                                  "AND pg_attribute.attrelid = pg_class.oid "
+                                  "AND pg_attribute.attisdropped = false "
+                                  "ORDER BY pg_attribute.attnum");
     if (schema.isEmpty())
-        stmt = stmt.arg(QLatin1String("pg_table_is_visible(pg_class.oid) AND"));
+        stmt = stmt.arg(QStringLiteral("pg_table_is_visible(pg_class.oid) AND"));
     else
-        stmt = stmt.arg(QString::fromLatin1("pg_class.relnamespace = (select oid from "
-                                        "pg_namespace where pg_namespace.nspname = '%1') AND").arg(schema));
+        stmt = stmt.arg(QStringLiteral("pg_class.relnamespace = (SELECT oid FROM "
+                                       "pg_namespace WHERE pg_namespace.nspname = '%1') AND").arg(schema));
 
     i.exec(stmt.arg(tbl));
     while (i.isActive() && i.next()) {
@@ -1438,23 +1448,23 @@ QSqlRecord QPSQLDriver::record(const QString& tablename) const
     else
         schema = std::move(schema).toLower();
 
-    QString stmt = QLatin1String("select pg_attribute.attname, pg_attribute.atttypid::int, "
-                                 "pg_attribute.attnotnull, pg_attribute.attlen, pg_attribute.atttypmod, "
-                                 "pg_attrdef.adsrc "
-                                 "from pg_class, pg_attribute "
-                                 "left join pg_attrdef on (pg_attrdef.adrelid = "
-                                 "pg_attribute.attrelid and pg_attrdef.adnum = pg_attribute.attnum) "
-                                 "where %1 "
-                                 "and pg_class.relname = '%2' "
-                                 "and pg_attribute.attnum > 0 "
-                                 "and pg_attribute.attrelid = pg_class.oid "
-                                 "and pg_attribute.attisdropped = false "
-                                 "order by pg_attribute.attnum");
+    QString stmt = QStringLiteral("SELECT pg_attribute.attname, pg_attribute.atttypid::int, "
+                                  "pg_attribute.attnotnull, pg_attribute.attlen, pg_attribute.atttypmod, "
+                                  "pg_attrdef.adsrc "
+                                  "FROM pg_class, pg_attribute "
+                                  "LEFT JOIN pg_attrdef ON (pg_attrdef.adrelid = "
+                                  "pg_attribute.attrelid AND pg_attrdef.adnum = pg_attribute.attnum) "
+                                  "WHERE %1 "
+                                  "AND pg_class.relname = '%2' "
+                                  "AND pg_attribute.attnum > 0 "
+                                  "AND pg_attribute.attrelid = pg_class.oid "
+                                  "AND pg_attribute.attisdropped = false "
+                                  "ORDER BY pg_attribute.attnum");
     if (schema.isEmpty())
-        stmt = stmt.arg(QLatin1String("pg_table_is_visible(pg_class.oid)"));
+        stmt = stmt.arg(QStringLiteral("pg_table_is_visible(pg_class.oid)"));
     else
-        stmt = stmt.arg(QString::fromLatin1("pg_class.relnamespace = (select oid from "
-                                            "pg_namespace where pg_namespace.nspname = '%1')").arg(schema));
+        stmt = stmt.arg(QStringLiteral("pg_class.relnamespace = (SELECT oid FROM "
+                                            "pg_namespace WHERE pg_namespace.nspname = '%1')").arg(schema));
 
     QSqlQuery query(createResult());
     query.exec(stmt.arg(tbl));
@@ -1496,9 +1506,10 @@ inline void assignSpecialPsqlFloatValue(FloatType val, QString *target)
 QString QPSQLDriver::formatValue(const QSqlField &field, bool trimStrings) const
 {
     Q_D(const QPSQLDriver);
+    const auto nullStr = [](){ return QStringLiteral("NULL"); };
     QString r;
     if (field.isNull()) {
-        r = QLatin1String("NULL");
+        r = nullStr();
     } else {
         switch (int(field.type())) {
         case QVariant::DateTime:
@@ -1507,14 +1518,14 @@ QString QPSQLDriver::formatValue(const QSqlField &field, bool trimStrings) const
                 // we force the value to be considered with a timezone information, and we force it to be UTC
                 // this is safe since postgresql stores only the UTC value and not the timezone offset (only used
                 // while parsing), so we have correct behavior in both case of with timezone and without tz
-                r = QLatin1String("TIMESTAMP WITH TIME ZONE ") + QLatin1Char('\'') +
-                        QLocale::c().toString(field.value().toDateTime().toUTC(), QLatin1String("yyyy-MM-ddThh:mm:ss.zzz")) +
+                r = QStringLiteral("TIMESTAMP WITH TIME ZONE ") + QLatin1Char('\'') +
+                        QLocale::c().toString(field.value().toDateTime().toUTC(), QStringLiteral("yyyy-MM-ddThh:mm:ss.zzz")) +
                         QLatin1Char('Z') + QLatin1Char('\'');
             } else {
-                r = QLatin1String("NULL");
+                r = nullStr();
             }
 #else
-            r = QLatin1String("NULL");
+            r = nullStr();
 #endif // datestring
             break;
         case QVariant::Time:
@@ -1524,19 +1535,19 @@ QString QPSQLDriver::formatValue(const QSqlField &field, bool trimStrings) const
             } else
 #endif
             {
-                r = QLatin1String("NULL");
+                r = nullStr();
             }
             break;
         case QVariant::String:
             r = QSqlDriver::formatValue(field, trimStrings);
             if (d->hasBackslashEscape)
-                r.replace(QLatin1String("\\"), QLatin1String("\\\\"));
+                r.replace(QLatin1Char('\\'), QLatin1String("\\\\"));
             break;
         case QVariant::Bool:
             if (field.value().toBool())
-                r = QLatin1String("TRUE");
+                r = QStringLiteral("TRUE");
             else
-                r = QLatin1String("FALSE");
+                r = QStringLiteral("FALSE");
             break;
         case QVariant::ByteArray: {
             QByteArray ba(field.value().toByteArray());
@@ -1615,7 +1626,7 @@ bool QPSQLDriver::subscribeToNotification(const QString &name)
         // Add the name to the list of subscriptions here so that QSQLDriverPrivate::exec knows
         // to check for notifications immediately after executing the LISTEN
         d->seid << name;
-        QString query = QLatin1String("LISTEN ") + escapeIdentifier(name, QSqlDriver::TableName);
+        QString query = QStringLiteral("LISTEN ") + escapeIdentifier(name, QSqlDriver::TableName);
         PGresult *result = d->exec(query);
         if (PQresultStatus(result) != PGRES_COMMAND_OK) {
             d->seid.removeLast();
@@ -1651,7 +1662,7 @@ bool QPSQLDriver::unsubscribeFromNotification(const QString &name)
         return false;
     }
 
-    QString query = QLatin1String("UNLISTEN ") + escapeIdentifier(name, QSqlDriver::TableName);
+    QString query = QStringLiteral("UNLISTEN ") + escapeIdentifier(name, QSqlDriver::TableName);
     PGresult *result = d->exec(query);
     if (PQresultStatus(result) != PGRES_COMMAND_OK) {
         setLastError(qMakeError(tr("Unable to unsubscribe"), QSqlError::StatementError, d, result));
diff --git a/src/plugins/sqldrivers/psql/qsql_psql_p.h b/src/plugins/sqldrivers/psql/qsql_psql_p.h
index 7e1849d857..4f372346c6 100644
--- a/src/plugins/sqldrivers/psql/qsql_psql_p.h
+++ b/src/plugins/sqldrivers/psql/qsql_psql_p.h
@@ -96,8 +96,8 @@ public:
         UnknownLaterVersion = 100000
     };
 
-    explicit QPSQLDriver(QObject *parent=0);
-    explicit QPSQLDriver(PGconn *conn, QObject *parent=0);
+    explicit QPSQLDriver(QObject *parent = nullptr);
+    explicit QPSQLDriver(PGconn *conn, QObject *parent = nullptr);
     ~QPSQLDriver();
     bool hasFeature(DriverFeature f) const override;
     bool open(const QString & db,
-- 
cgit v1.2.3


From 461ef575bcf778ba24b0be6b775098d4b80ae5e1 Mon Sep 17 00:00:00 2001
From: Andy Shaw <andy.shaw@qt.io>
Date: Tue, 16 Jan 2018 09:54:01 +0100
Subject: Always escape the table names when creating the SQL statement

Since some databases are case sensitive if part of the query is quoted,
then we should ensure that all instances of the table name are escaped
unless the test is delibrately testing the non-escaped case.

As a result, this commit also removes some expected failures pertaining
to PostgreSQL and also adds an entry to the list of tables being dropped
when a test is finished.

[ChangeLog][Sql][PostgreSQL] QSqlDatabase is now stricter about table
names when used with record() and primaryIndex(). If the tablename was
not quoted when it was created, then the table name passed to record()
and primaryIndex() needs to be in lower case so that PostgreSQL is
able to find it.

Fixes: QTBUG-65788
Change-Id: Id1f54cb66b761c39edf858501b730ede7eec1fd3
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
---
 src/plugins/sqldrivers/mysql/qsql_mysql.cpp |  2 +-
 src/plugins/sqldrivers/psql/qsql_psql.cpp   | 24 ++++--------------------
 2 files changed, 5 insertions(+), 21 deletions(-)

(limited to 'src/plugins/sqldrivers')

diff --git a/src/plugins/sqldrivers/mysql/qsql_mysql.cpp b/src/plugins/sqldrivers/mysql/qsql_mysql.cpp
index 80c0c9c522..febbe58506 100644
--- a/src/plugins/sqldrivers/mysql/qsql_mysql.cpp
+++ b/src/plugins/sqldrivers/mysql/qsql_mysql.cpp
@@ -1551,7 +1551,7 @@ QSqlIndex QMYSQLDriver::primaryIndex(const QString& tablename) const
     QSqlQuery i(createResult());
     QString stmt(QLatin1String("show index from %1;"));
     QSqlRecord fil = record(tablename);
-    i.exec(stmt.arg(tablename));
+    i.exec(stmt.arg(escapeIdentifier(tablename, QSqlDriver::TableName)));
     while (i.isActive() && i.next()) {
         if (i.value(2).toString() == QLatin1String("PRIMARY")) {
             idx.append(fil.field(i.value(4).toString()));
diff --git a/src/plugins/sqldrivers/psql/qsql_psql.cpp b/src/plugins/sqldrivers/psql/qsql_psql.cpp
index 9fc9317da6..49b793ce38 100644
--- a/src/plugins/sqldrivers/psql/qsql_psql.cpp
+++ b/src/plugins/sqldrivers/psql/qsql_psql.cpp
@@ -1393,16 +1393,8 @@ QSqlIndex QPSQLDriver::primaryIndex(const QString& tablename) const
     QString tbl = tablename;
     QString schema;
     qSplitTableName(tbl, schema);
-
-    if (isIdentifierEscaped(tbl, QSqlDriver::TableName))
-        tbl = stripDelimiters(tbl, QSqlDriver::TableName);
-    else
-        tbl = std::move(tbl).toLower();
-
-    if (isIdentifierEscaped(schema, QSqlDriver::TableName))
-        schema = stripDelimiters(schema, QSqlDriver::TableName);
-    else
-        schema = std::move(schema).toLower();
+    schema = stripDelimiters(schema, QSqlDriver::TableName);
+    tbl = stripDelimiters(tbl, QSqlDriver::TableName);
 
     QString stmt = QStringLiteral("SELECT pg_attribute.attname, pg_attribute.atttypid::int, "
                                   "pg_class.relname "
@@ -1437,16 +1429,8 @@ QSqlRecord QPSQLDriver::record(const QString& tablename) const
     QString tbl = tablename;
     QString schema;
     qSplitTableName(tbl, schema);
-
-    if (isIdentifierEscaped(tbl, QSqlDriver::TableName))
-        tbl = stripDelimiters(tbl, QSqlDriver::TableName);
-    else
-        tbl = std::move(tbl).toLower();
-
-    if (isIdentifierEscaped(schema, QSqlDriver::TableName))
-        schema = stripDelimiters(schema, QSqlDriver::TableName);
-    else
-        schema = std::move(schema).toLower();
+    schema = stripDelimiters(schema, QSqlDriver::TableName);
+    tbl = stripDelimiters(tbl, QSqlDriver::TableName);
 
     QString stmt = QStringLiteral("SELECT pg_attribute.attname, pg_attribute.atttypid::int, "
                                   "pg_attribute.attnotnull, pg_attribute.attlen, pg_attribute.atttypmod, "
-- 
cgit v1.2.3


From 52c0bb59945f5068c84238619411078a1c67620f Mon Sep 17 00:00:00 2001
From: Robert Szefner <r.szefner@hydro-partner.pl>
Date: Mon, 11 Mar 2019 00:23:31 +0100
Subject: QPSQL: Use qstrtod() function for string to double conversion

A change to qstrtod() will give us a small performance improvement.
Because the qstrtod() function does not correctly parse the NaN values,
an appropriate check condition for NaN has been added.
Also changed code structure so now the double conversion function
is called only in one place.

Task-number: QTBUG-65748
Change-Id: I49d40e5157e79cc5fce35db4c4272d1ccd270c6b
Reviewed-by: Andy Shaw <andy.shaw@qt.io>
---
 src/plugins/sqldrivers/psql/qsql_psql.cpp | 44 +++++++++++++++++--------------
 1 file changed, 24 insertions(+), 20 deletions(-)

(limited to 'src/plugins/sqldrivers')

diff --git a/src/plugins/sqldrivers/psql/qsql_psql.cpp b/src/plugins/sqldrivers/psql/qsql_psql.cpp
index 49b793ce38..fe4bb4b464 100644
--- a/src/plugins/sqldrivers/psql/qsql_psql.cpp
+++ b/src/plugins/sqldrivers/psql/qsql_psql.cpp
@@ -53,6 +53,7 @@
 #include <qlocale.h>
 #include <QtSql/private/qsqlresult_p.h>
 #include <QtSql/private/qsqldriver_p.h>
+#include <QtCore/private/qlocale_tools_p.h>
 
 #include <queue>
 
@@ -663,27 +664,30 @@ QVariant QPSQLResult::data(int i)
         return atoi(val);
     case QVariant::Double: {
         if (ptype == QNUMERICOID) {
-            if (numericalPrecisionPolicy() != QSql::HighPrecision) {
-                QVariant retval;
-                bool convert;
-                double dbl=QString::fromLatin1(val).toDouble(&convert);
-                if (numericalPrecisionPolicy() == QSql::LowPrecisionInt64)
-                    retval = (qlonglong)dbl;
-                else if (numericalPrecisionPolicy() == QSql::LowPrecisionInt32)
-                    retval = (int)dbl;
-                else if (numericalPrecisionPolicy() == QSql::LowPrecisionDouble)
-                    retval = dbl;
-                if (!convert)
-                    return QVariant();
-                return retval;
-            }
-            return QString::fromLatin1(val);
+            if (numericalPrecisionPolicy() == QSql::HighPrecision)
+                return QString::fromLatin1(val);
+        }
+        bool ok;
+        double dbl = qstrtod(val, nullptr, &ok);
+        if (!ok) {
+            if (qstricmp(val, "NaN") == 0)
+                dbl = qQNaN();
+            else if (qstricmp(val, "Infinity") == 0)
+                dbl = qInf();
+            else if (qstricmp(val, "-Infinity") == 0)
+                dbl = -qInf();
+            else
+                return QVariant();
+        }
+        if (ptype == QNUMERICOID) {
+            if (numericalPrecisionPolicy() == QSql::LowPrecisionInt64)
+                return QVariant((qlonglong)dbl);
+            else if (numericalPrecisionPolicy() == QSql::LowPrecisionInt32)
+                return QVariant((int)dbl);
+            else if (numericalPrecisionPolicy() == QSql::LowPrecisionDouble)
+                return QVariant(dbl);
         }
-        if (qstricmp(val, "Infinity") == 0)
-            return qInf();
-        if (qstricmp(val, "-Infinity") == 0)
-            return -qInf();
-        return QString::fromLatin1(val).toDouble();
+        return dbl;
     }
     case QVariant::Date:
         if (val[0] == '\0') {
-- 
cgit v1.2.3


From 3fa5e637fb45ae6868422494f5a17c0c8fc68ab2 Mon Sep 17 00:00:00 2001
From: Robert Szefner <r.szefner@hydro-partner.pl>
Date: Mon, 11 Mar 2019 22:43:20 +0100
Subject: QPSQL: Fix code formatting

Only whitespace changes.

Change-Id: I474aa1b477be7081b58bd781417861878b207f4e
Reviewed-by: Christian Ehrlicher <ch.ehrlicher@gmx.de>
---
 src/plugins/sqldrivers/psql/qsql_psql.cpp | 51 +++++++++++++++----------------
 src/plugins/sqldrivers/psql/qsql_psql_p.h | 14 ++++-----
 2 files changed, 32 insertions(+), 33 deletions(-)

(limited to 'src/plugins/sqldrivers')

diff --git a/src/plugins/sqldrivers/psql/qsql_psql.cpp b/src/plugins/sqldrivers/psql/qsql_psql.cpp
index fe4bb4b464..6476dd7839 100644
--- a/src/plugins/sqldrivers/psql/qsql_psql.cpp
+++ b/src/plugins/sqldrivers/psql/qsql_psql.cpp
@@ -136,7 +136,7 @@ protected:
     bool nextResult() override;
     QVariant data(int i) override;
     bool isNull(int field) override;
-    bool reset (const QString &query) override;
+    bool reset(const QString &query) override;
     int size() override;
     int numRowsAffected() override;
     QSqlRecord record() const override;
@@ -320,15 +320,15 @@ public:
     bool processResults();
 };
 
-static QSqlError qMakeError(const QString& err, QSqlError::ErrorType type,
-                            const QPSQLDriverPrivate *p, PGresult* result = 0)
+static QSqlError qMakeError(const QString &err, QSqlError::ErrorType type,
+                            const QPSQLDriverPrivate *p, PGresult *result = 0)
 {
     const char *s = PQerrorMessage(p->connection);
     QString msg = p->isUtf8 ? QString::fromUtf8(s) : QString::fromLocal8Bit(s);
     QString errorCode;
     if (result) {
-      errorCode = QString::fromLatin1(PQresultErrorField(result, PG_DIAG_SQLSTATE));
-      msg += QString::fromLatin1("(%1)").arg(errorCode);
+        errorCode = QString::fromLatin1(PQresultErrorField(result, PG_DIAG_SQLSTATE));
+        msg += QString::fromLatin1("(%1)").arg(errorCode);
     }
     return QSqlError(QLatin1String("QPSQL: ") + err, msg, type, errorCode);
 }
@@ -437,7 +437,7 @@ void QPSQLResultPrivate::deallocatePreparedStmt()
     preparedStmtId.clear();
 }
 
-QPSQLResult::QPSQLResult(const QPSQLDriver* db)
+QPSQLResult::QPSQLResult(const QPSQLDriver *db)
     : QSqlResult(*new QPSQLResultPrivate(this, db))
 {
     Q_D(QPSQLResult);
@@ -715,7 +715,7 @@ QVariant QPSQLResult::data(int i)
 #if QT_CONFIG(datestring)
         if (dtval.length() < 10) {
             return QVariant(QDateTime());
-       } else {
+        } else {
             QChar sign = dtval[dtval.size() - 3];
             if (sign == QLatin1Char('-') || sign == QLatin1Char('+')) dtval += QLatin1String(":00");
             return QVariant(QDateTime::fromString(dtval, Qt::ISODate).toLocalTime());
@@ -745,7 +745,7 @@ bool QPSQLResult::isNull(int field)
     return PQgetisnull(d->result, currentRow, field);
 }
 
-bool QPSQLResult::reset (const QString& query)
+bool QPSQLResult::reset(const QString &query)
 {
     Q_D(QPSQLResult);
     cleanup();
@@ -872,7 +872,6 @@ QSqlRecord QPSQLResult::record() const
 void QPSQLResult::virtual_hook(int id, void *data)
 {
     Q_ASSERT(data);
-
     QSqlResult::virtual_hook(id, data);
 }
 
@@ -970,7 +969,7 @@ bool QPSQLResult::exec()
 
 bool QPSQLDriverPrivate::setEncodingUtf8()
 {
-    PGresult* result = exec("SET CLIENT_ENCODING TO 'UNICODE'");
+    PGresult *result = exec("SET CLIENT_ENCODING TO 'UNICODE'");
     int status = PQresultStatus(result);
     PQclear(result);
     return status == PGRES_COMMAND_OK;
@@ -978,7 +977,7 @@ bool QPSQLDriverPrivate::setEncodingUtf8()
 
 void QPSQLDriverPrivate::setDatestyle()
 {
-    PGresult* result = exec("SET DATESTYLE TO 'ISO'");
+    PGresult *result = exec("SET DATESTYLE TO 'ISO'");
     int status =  PQresultStatus(result);
     if (status != PGRES_COMMAND_OK)
         qWarning("%s", PQerrorMessage(connection));
@@ -1007,7 +1006,7 @@ void QPSQLDriverPrivate::detectBackslashEscape()
         hasBackslashEscape = true;
     } else {
         hasBackslashEscape = false;
-        PGresult* result = exec(QStringLiteral("SELECT '\\\\' x"));
+        PGresult *result = exec(QStringLiteral("SELECT '\\\\' x"));
         int status = PQresultStatus(result);
         if (status == PGRES_COMMAND_OK || status == PGRES_TUPLES_OK)
             if (QString::fromLatin1(PQgetvalue(result, 0, 0)) == QLatin1String("\\"))
@@ -1110,7 +1109,7 @@ static QPSQLDriver::Protocol qFindPSQLVersion(const QString &versionString)
 QPSQLDriver::Protocol QPSQLDriverPrivate::getPSQLVersion()
 {
     QPSQLDriver::Protocol serverVersion = QPSQLDriver::Version6;
-    PGresult* result = exec("SELECT version()");
+    PGresult *result = exec("SELECT version()");
     int status = PQresultStatus(result);
     if (status == PGRES_COMMAND_OK || status == PGRES_TUPLES_OK) {
         serverVersion = qFindPSQLVersion(
@@ -1216,12 +1215,12 @@ static QString qQuote(QString s)
     return s;
 }
 
-bool QPSQLDriver::open(const QString & db,
-                        const QString & user,
-                        const QString & password,
-                        const QString & host,
-                        int port,
-                        const QString& connOpts)
+bool QPSQLDriver::open(const QString &db,
+                       const QString &user,
+                       const QString &password,
+                       const QString &host,
+                       int port,
+                       const QString &connOpts)
 {
     Q_D(QPSQLDriver);
     if (isOpen())
@@ -1297,7 +1296,7 @@ bool QPSQLDriver::beginTransaction()
         qWarning("QPSQLDriver::beginTransaction: Database not open");
         return false;
     }
-    PGresult* res = d->exec("BEGIN");
+    PGresult *res = d->exec("BEGIN");
     if (!res || PQresultStatus(res) != PGRES_COMMAND_OK) {
         setLastError(qMakeError(tr("Could not begin transaction"),
                                 QSqlError::TransactionError, d, res));
@@ -1315,7 +1314,7 @@ bool QPSQLDriver::commitTransaction()
         qWarning("QPSQLDriver::commitTransaction: Database not open");
         return false;
     }
-    PGresult* res = d->exec("COMMIT");
+    PGresult *res = d->exec("COMMIT");
 
     bool transaction_failed = false;
 
@@ -1344,7 +1343,7 @@ bool QPSQLDriver::rollbackTransaction()
         qWarning("QPSQLDriver::rollbackTransaction: Database not open");
         return false;
     }
-    PGresult* res = d->exec("ROLLBACK");
+    PGresult *res = d->exec("ROLLBACK");
     if (!res || PQresultStatus(res) != PGRES_COMMAND_OK) {
         setLastError(qMakeError(tr("Could not rollback transaction"),
                                 QSqlError::TransactionError, d, res));
@@ -1387,7 +1386,7 @@ static void qSplitTableName(QString &tablename, QString &schema)
     tablename = tablename.mid(dot + 1);
 }
 
-QSqlIndex QPSQLDriver::primaryIndex(const QString& tablename) const
+QSqlIndex QPSQLDriver::primaryIndex(const QString &tablename) const
 {
     QSqlIndex idx(tablename);
     if (!isOpen())
@@ -1424,7 +1423,7 @@ QSqlIndex QPSQLDriver::primaryIndex(const QString& tablename) const
     return idx;
 }
 
-QSqlRecord QPSQLDriver::record(const QString& tablename) const
+QSqlRecord QPSQLDriver::record(const QString &tablename) const
 {
     QSqlRecord info;
     if (!isOpen())
@@ -1575,7 +1574,7 @@ QString QPSQLDriver::formatValue(const QSqlField &field, bool trimStrings) const
 QString QPSQLDriver::escapeIdentifier(const QString &identifier, IdentifierType) const
 {
     QString res = identifier;
-    if(!identifier.isEmpty() && !identifier.startsWith(QLatin1Char('"')) && !identifier.endsWith(QLatin1Char('"')) ) {
+    if (!identifier.isEmpty() && !identifier.startsWith(QLatin1Char('"')) && !identifier.endsWith(QLatin1Char('"')) ) {
         res.replace(QLatin1Char('"'), QLatin1String("\"\""));
         res.prepend(QLatin1Char('"')).append(QLatin1Char('"'));
         res.replace(QLatin1Char('.'), QLatin1String("\".\""));
@@ -1683,7 +1682,7 @@ void QPSQLDriver::_q_handleNotification(int)
     PQconsumeInput(d->connection);
 
     PGnotify *notify = 0;
-    while((notify = PQnotifies(d->connection)) != 0) {
+    while ((notify = PQnotifies(d->connection)) != 0) {
         QString name(QLatin1String(notify->relname));
         if (d->seid.contains(name)) {
             QString payload;
diff --git a/src/plugins/sqldrivers/psql/qsql_psql_p.h b/src/plugins/sqldrivers/psql/qsql_psql_p.h
index 4f372346c6..99e0b5f60f 100644
--- a/src/plugins/sqldrivers/psql/qsql_psql_p.h
+++ b/src/plugins/sqldrivers/psql/qsql_psql_p.h
@@ -100,18 +100,18 @@ public:
     explicit QPSQLDriver(PGconn *conn, QObject *parent = nullptr);
     ~QPSQLDriver();
     bool hasFeature(DriverFeature f) const override;
-    bool open(const QString & db,
-              const QString & user,
-              const QString & password,
-              const QString & host,
+    bool open(const QString &db,
+              const QString &user,
+              const QString &password,
+              const QString &host,
               int port,
-              const QString& connOpts) override;
+              const QString &connOpts) override;
     bool isOpen() const override;
     void close() override;
     QSqlResult *createResult() const override;
     QStringList tables(QSql::TableType) const override;
-    QSqlIndex primaryIndex(const QString& tablename) const override;
-    QSqlRecord record(const QString& tablename) const override;
+    QSqlIndex primaryIndex(const QString &tablename) const override;
+    QSqlRecord record(const QString &tablename) const override;
 
     Protocol protocol() const;
     QVariant handle() const override;
-- 
cgit v1.2.3


From 2c6593b721f809012e6b93ba4c4428b76e22adb3 Mon Sep 17 00:00:00 2001
From: Robert Szefner <r.szefner@hydro-partner.pl>
Date: Mon, 11 Mar 2019 23:36:26 +0100
Subject: QPSQL: Use nullptr for pointers

Change-Id: I2b61cf0b81550c0878b0f06488a933c4b14e4728
Reviewed-by: Christian Ehrlicher <ch.ehrlicher@gmx.de>
---
 src/plugins/sqldrivers/psql/qsql_psql.cpp | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

(limited to 'src/plugins/sqldrivers')

diff --git a/src/plugins/sqldrivers/psql/qsql_psql.cpp b/src/plugins/sqldrivers/psql/qsql_psql.cpp
index 6476dd7839..c1be91cb22 100644
--- a/src/plugins/sqldrivers/psql/qsql_psql.cpp
+++ b/src/plugins/sqldrivers/psql/qsql_psql.cpp
@@ -321,7 +321,7 @@ public:
 };
 
 static QSqlError qMakeError(const QString &err, QSqlError::ErrorType type,
-                            const QPSQLDriverPrivate *p, PGresult *result = 0)
+                            const QPSQLDriverPrivate *p, PGresult *result = nullptr)
 {
     const char *s = PQerrorMessage(p->connection);
     QString msg = p->isUtf8 ? QString::fromUtf8(s) : QString::fromLocal8Bit(s);
@@ -1249,7 +1249,7 @@ bool QPSQLDriver::open(const QString &db,
         setLastError(qMakeError(tr("Unable to connect"), QSqlError::ConnectionError, d));
         setOpenError(true);
         PQfinish(d->connection);
-        d->connection = 0;
+        d->connection = nullptr;
         return false;
     }
 
@@ -1273,12 +1273,12 @@ void QPSQLDriver::close()
         if (d->sn) {
             disconnect(d->sn, SIGNAL(activated(int)), this, SLOT(_q_handleNotification(int)));
             delete d->sn;
-            d->sn = 0;
+            d->sn = nullptr;
         }
 
         if (d->connection)
             PQfinish(d->connection);
-        d->connection = 0;
+        d->connection = nullptr;
         setOpen(false);
         setOpenError(false);
     }
@@ -1663,7 +1663,7 @@ bool QPSQLDriver::unsubscribeFromNotification(const QString &name)
     if (d->seid.isEmpty()) {
         disconnect(d->sn, SIGNAL(activated(int)), this, SLOT(_q_handleNotification(int)));
         delete d->sn;
-        d->sn = 0;
+        d->sn = nullptr;
     }
 
     return true;
@@ -1681,8 +1681,8 @@ void QPSQLDriver::_q_handleNotification(int)
     d->pendingNotifyCheck = false;
     PQconsumeInput(d->connection);
 
-    PGnotify *notify = 0;
-    while ((notify = PQnotifies(d->connection)) != 0) {
+    PGnotify *notify = nullptr;
+    while ((notify = PQnotifies(d->connection)) != nullptr) {
         QString name(QLatin1String(notify->relname));
         if (d->seid.contains(name)) {
             QString payload;
-- 
cgit v1.2.3


From 41e7b71c410b77a81d09d3cc2e169ffd7975b4d2 Mon Sep 17 00:00:00 2001
From: Kevin Funk <kevin.funk@kdab.com>
Date: Tue, 12 Mar 2019 11:46:26 +0100
Subject: More nullptr usage in headers

Diff generated by running clang-tidy's modernize-use-nullptr checker on
the CMake-based Qt version.

Skipping src/3rdparty, examples/, tests/

Change-Id: Ib182074e2e2fd52f63093f73b3e2e4c0cb7af188
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
---
 src/plugins/sqldrivers/odbc/qsql_odbc_p.h     | 4 ++--
 src/plugins/sqldrivers/sqlite/qsql_sqlite_p.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

(limited to 'src/plugins/sqldrivers')

diff --git a/src/plugins/sqldrivers/odbc/qsql_odbc_p.h b/src/plugins/sqldrivers/odbc/qsql_odbc_p.h
index ea0aa6fc8b..ccd0206f38 100644
--- a/src/plugins/sqldrivers/odbc/qsql_odbc_p.h
+++ b/src/plugins/sqldrivers/odbc/qsql_odbc_p.h
@@ -89,8 +89,8 @@ class Q_EXPORT_SQLDRIVER_ODBC QODBCDriver : public QSqlDriver
     friend class QODBCResultPrivate;
 
 public:
-    explicit QODBCDriver(QObject *parent=0);
-    QODBCDriver(SQLHANDLE env, SQLHANDLE con, QObject * parent=0);
+    explicit QODBCDriver(QObject *parent=nullptr);
+    QODBCDriver(SQLHANDLE env, SQLHANDLE con, QObject * parent=nullptr);
     virtual ~QODBCDriver();
     bool hasFeature(DriverFeature f) const override;
     void close() override;
diff --git a/src/plugins/sqldrivers/sqlite/qsql_sqlite_p.h b/src/plugins/sqldrivers/sqlite/qsql_sqlite_p.h
index 61be4c937f..c7952bca9a 100644
--- a/src/plugins/sqldrivers/sqlite/qsql_sqlite_p.h
+++ b/src/plugins/sqldrivers/sqlite/qsql_sqlite_p.h
@@ -72,8 +72,8 @@ class Q_EXPORT_SQLDRIVER_SQLITE QSQLiteDriver : public QSqlDriver
     Q_OBJECT
     friend class QSQLiteResultPrivate;
 public:
-    explicit QSQLiteDriver(QObject *parent = 0);
-    explicit QSQLiteDriver(sqlite3 *connection, QObject *parent = 0);
+    explicit QSQLiteDriver(QObject *parent = nullptr);
+    explicit QSQLiteDriver(sqlite3 *connection, QObject *parent = nullptr);
     ~QSQLiteDriver();
     bool hasFeature(DriverFeature f) const override;
     bool open(const QString & db,
-- 
cgit v1.2.3


From 1a707be8b4a8e3cb2878cb18ce76c54f9fad9b28 Mon Sep 17 00:00:00 2001
From: Kai Koehne <kai.koehne@qt.io>
Date: Fri, 22 Mar 2019 13:25:57 +0100
Subject: Do not look for pg_config, mysql_config in PATH when cross-compiling

Otherwise it can happen that we pick up the tool for the host system,
which will break compilation.

Users can still pass
 -psql_config /path/to/pg_config

or
 -mysql_config /path/to/mysql_config

manually.

[ChangeLog][QtSql] When cross-compiling pg_config, mysql_config
are not looked up in PATH anymore. Pass -psql_config path/to/pg_config
or -mysql_config path/to/mysql_config to explicitly enable PSQL or
MySQL in this setup.

Fixes: QTBUG-73565
Change-Id: I35ff32322bac69f1575ce6c846a56ac2ae3b8d55
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
---
 src/plugins/sqldrivers/configure.pri | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'src/plugins/sqldrivers')

diff --git a/src/plugins/sqldrivers/configure.pri b/src/plugins/sqldrivers/configure.pri
index 84c8114c7b..be6a930e52 100644
--- a/src/plugins/sqldrivers/configure.pri
+++ b/src/plugins/sqldrivers/configure.pri
@@ -2,7 +2,7 @@
 
 defineTest(qtConfLibrary_psqlConfig) {
     pg_config = $$config.input.psql_config
-    isEmpty(pg_config): \
+    isEmpty(pg_config):!cross_compile: \
         pg_config = $$qtConfFindInPath("pg_config")
     !win32:!isEmpty(pg_config) {
         qtRunLoggedCommand("$$pg_config --libdir", libdir)|return(false)
@@ -33,7 +33,7 @@ defineTest(qtConfLibrary_psqlEnv) {
 
 defineTest(qtConfLibrary_mysqlConfig) {
     mysql_config = $$config.input.mysql_config
-    isEmpty(mysql_config): \
+    isEmpty(mysql_config):!cross_compile: \
         mysql_config = $$qtConfFindInPath("mysql_config")
     !isEmpty(mysql_config) {
         qtRunLoggedCommand("$$mysql_config --version", version)|return(false)
-- 
cgit v1.2.3