From 2356c173b2952f6ab6767abac12a21688324fcc5 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Tue, 12 Dec 2017 11:50:10 +0100 Subject: QPlatformPrintDevice: store QPageSize/QMimeType/int in QList, not QVector This commit pains me, because we want Qt to migrate away from QList, but the QtPrint API stack (all the way to public API, for QPageSize, and int) is formulated in terms of QList, not QVector, so it makes zero sense to store data in QVectors just to convert to QList on every opportunity. Store QMimeType in QList, too, since that's what QtCore uses. Saves 3KiB in text size (0.7% of QtPrintSupport). Change-Id: I71249f60be517cc06973b38d9ccad7a31f348be3 Reviewed-by: Albert Astals Cid Reviewed-by: Lars Knoll --- src/printsupport/kernel/qplatformprintdevice.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/printsupport/kernel/qplatformprintdevice.h') diff --git a/src/printsupport/kernel/qplatformprintdevice.h b/src/printsupport/kernel/qplatformprintdevice.h index 654bb123fb..1cac009660 100644 --- a/src/printsupport/kernel/qplatformprintdevice.h +++ b/src/printsupport/kernel/qplatformprintdevice.h @@ -155,7 +155,7 @@ protected: bool m_supportsCollateCopies; mutable bool m_havePageSizes; - mutable QVector m_pageSizes; + mutable QList m_pageSizes; bool m_supportsCustomPageSizes; @@ -163,7 +163,7 @@ protected: QSize m_maximumPhysicalPageSize; mutable bool m_haveResolutions; - mutable QVector m_resolutions; + mutable QList m_resolutions; mutable bool m_haveInputSlots; mutable QVector m_inputSlots; @@ -179,7 +179,7 @@ protected: #ifndef QT_NO_MIMETYPE mutable bool m_haveMimeTypes; - mutable QVector m_mimeTypes; + mutable QList m_mimeTypes; #endif }; -- cgit v1.2.3