From 5bd5f6ae69d749bc3adef58edc906b9fb46bb7a8 Mon Sep 17 00:00:00 2001 From: John Layt Date: Fri, 25 May 2012 19:28:37 +0100 Subject: QtPrintSupport: Change QPrinterInfo::defaultPrinter() behaviour In Qt4 QPrinterInfo::defaultPrinter() has inconsistant behaviour depending on the platform. On Mac and Unix if no default printer is set in the system then the first available printer is returned. but on Windows it returns a null QPrinterInfo. Currently Qt5 returns the first printer on all platforms, but this causes an inconsistency if you call isDefault() on the returned QPrinterInfo. The apidox is slightly ambiguous, but does seem to imply no printer will be returned if no default is set. The only place in Qt the public api is used is in QPrinter which is coded expecting that defaultPrinter() may return null but for there still to be availablePrinters(). Change-Id: I1bbef8cba259b7d51980a0199e9fd6d5466d921f Reviewed-by: Teemu Katajisto Reviewed-by: John Layt --- src/printsupport/kernel/qprinterinfo.cpp | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/printsupport/kernel/qprinterinfo.cpp') diff --git a/src/printsupport/kernel/qprinterinfo.cpp b/src/printsupport/kernel/qprinterinfo.cpp index fbf2e4de33..dc60d7a50f 100644 --- a/src/printsupport/kernel/qprinterinfo.cpp +++ b/src/printsupport/kernel/qprinterinfo.cpp @@ -69,7 +69,12 @@ QPrinterInfoPrivate QPrinterInfoPrivate::shared_null; The return value should be checked using isNull() before being used, in case there is no default printer. + On some systems it is possible for there to be available printers + but none of them set to be the default printer. + \sa isNull() + \sa isDefault() + \sa availablePrinters() */ /*! -- cgit v1.2.3