From af837734b2259201f126b206bd5299497e080f7b Mon Sep 17 00:00:00 2001 From: Edward Welbourne Date: Thu, 23 Jan 2020 17:55:07 +0100 Subject: Pass QDate and QTime as value classes It's what they are, so const refs are needless burden. In the process, consolidate two of the affected methods (one of which just adds another argument to the other's signature) into one. Change-Id: I80de35ffe078a652d1999889dede0b10302abaa9 Reviewed-by: Thiago Macieira --- src/printsupport/kernel/qcups.cpp | 2 +- src/printsupport/kernel/qcups_p.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/printsupport/kernel') diff --git a/src/printsupport/kernel/qcups.cpp b/src/printsupport/kernel/qcups.cpp index 0fc8cdd1b7..ab9b2889e2 100644 --- a/src/printsupport/kernel/qcups.cpp +++ b/src/printsupport/kernel/qcups.cpp @@ -167,7 +167,7 @@ ppd_option_t *QCUPSSupport::findPpdOption(const char *optionName, QPrintDevice * return nullptr; } -void QCUPSSupport::setJobHold(QPrinter *printer, const JobHoldUntil jobHold, const QTime &holdUntilTime) +void QCUPSSupport::setJobHold(QPrinter *printer, const JobHoldUntil jobHold, QTime holdUntilTime) { const QString jobHoldUntilArgument = jobHoldToString(jobHold, holdUntilTime); if (!jobHoldUntilArgument.isEmpty()) { diff --git a/src/printsupport/kernel/qcups_p.h b/src/printsupport/kernel/qcups_p.h index 57ec281383..4d72230b90 100644 --- a/src/printsupport/kernel/qcups_p.h +++ b/src/printsupport/kernel/qcups_p.h @@ -137,7 +137,7 @@ public: static void clearCupsOption(QPrinter *printer, const QString &option); static void clearCupsOptions(QPrinter *printer); - static void setJobHold(QPrinter *printer, const JobHoldUntil jobHold = NoHold, const QTime &holdUntilTime = QTime()); + static void setJobHold(QPrinter *printer, const JobHoldUntil jobHold = NoHold, QTime holdUntilTime = QTime()); static void setJobBilling(QPrinter *printer, const QString &jobBilling = QString()); static void setJobPriority(QPrinter *printer, int priority = 50); static void setBannerPages(QPrinter *printer, const BannerPage startBannerPage, const BannerPage endBannerPage); @@ -159,7 +159,7 @@ public: struct JobHoldUntilWithTime { - JobHoldUntilWithTime(JobHoldUntil jh = NoHold, const QTime &t = QTime()) + JobHoldUntilWithTime(JobHoldUntil jh = NoHold, QTime t = QTime()) : jobHold(jh), time(t) {} JobHoldUntil jobHold; -- cgit v1.2.3