From 406c8ef6e67da5505c7404a2517a8b4204d7c38a Mon Sep 17 00:00:00 2001 From: Andy Shaw Date: Sat, 30 Mar 2013 19:55:25 +0100 Subject: Move the dbmstype to QSqlDriverPrivate so it can be used for all drivers By moving it to QSqlDriverPrivate we make it easier to check what database is actually connected which is particularly useful for the autotests. Change-Id: I54d1c2c998919c1d54efb1b6ac9303070ece54aa Reviewed-by: Mark Brand --- src/sql/drivers/oci/qsql_oci.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'src/sql/drivers/oci/qsql_oci.cpp') diff --git a/src/sql/drivers/oci/qsql_oci.cpp b/src/sql/drivers/oci/qsql_oci.cpp index b0950110e0..6eb6703ebf 100644 --- a/src/sql/drivers/oci/qsql_oci.cpp +++ b/src/sql/drivers/oci/qsql_oci.cpp @@ -52,6 +52,7 @@ #include #include #include +#include #include #include #include @@ -492,8 +493,9 @@ void QOCIResultPrivate::outValues(QVector &values, IndicatorArray &ind } -struct QOCIDriverPrivate +class QOCIDriverPrivate : public QSqlDriverPrivate { +public: QOCIDriverPrivate(); OCIEnv *env; @@ -511,9 +513,10 @@ struct QOCIDriverPrivate }; QOCIDriverPrivate::QOCIDriverPrivate() - : env(0), svc(0), srvhp(0), authp(0), err(0), transaction(false), serverVersion(-1), - prefetchRows(-1), prefetchMem(QOCI_PREFETCH_MEM) + : QSqlDriverPrivate(), env(0), svc(0), srvhp(0), authp(0), err(0), transaction(false), + serverVersion(-1), prefetchRows(-1), prefetchMem(QOCI_PREFETCH_MEM) { + dbmsType = Oracle; } void QOCIDriverPrivate::allocErrorHandle() @@ -2137,8 +2140,6 @@ QOCIDriver::~QOCIDriver() r = OCIHandleFree(d->env, OCI_HTYPE_ENV); if (r != OCI_SUCCESS) qWarning("Unable to free Environment handle: %d", r); - - delete d; } bool QOCIDriver::hasFeature(DriverFeature f) const -- cgit v1.2.3