From 373d858812a84b48be482dd64ad9d248ab2d5b3c Mon Sep 17 00:00:00 2001 From: Mark Brand Date: Fri, 25 Apr 2014 17:55:04 +0200 Subject: [QtSql][QSqlTableModel] fix failure to refresh in selectRow() Caused by missing braces, leaving the break outside the scope of the if clause. Task-number: QTBUG-38509 Change-Id: I6b0a7f34512a3a9b0fbd790116f81f54f4a91cf0 Reviewed-by: Tobias Koenig Reviewed-by: Mark Brand Reviewed-by: Andy Shaw --- src/sql/models/qsqltablemodel.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/sql/models/qsqltablemodel.cpp') diff --git a/src/sql/models/qsqltablemodel.cpp b/src/sql/models/qsqltablemodel.cpp index 5c73705d4c..0eed6ea4d3 100644 --- a/src/sql/models/qsqltablemodel.cpp +++ b/src/sql/models/qsqltablemodel.cpp @@ -448,9 +448,10 @@ bool QSqlTableModel::selectRow(int row) // Look for changed values. Primary key fields are customarily first // and probably change less often than other fields, so start at the end. for (int f = curValues.count() - 1; f >= 0; --f) { - if (curValues.value(f) != newValues.value(f)) + if (curValues.value(f) != newValues.value(f)) { needsAddingToCache = true; break; + } } } } -- cgit v1.2.3