From c2f26d6d0b70e591c74bf6664e30288a2d63dc9a Mon Sep 17 00:00:00 2001 From: Maks Naumov Date: Sat, 7 Feb 2015 12:10:41 +0200 Subject: Use prefix instead of postfix for iterators The postfix increment(decrement) creates a temp copy of *this before the modification and then returns that copy. It's needed only when using the old iterator and then incrementing it. Change-Id: I7f6702de78f5f987cec3556047e76049b4ee063a Reviewed-by: Konstantin Ritt Reviewed-by: Marc Mutz --- src/sql/models/qsqltablemodel.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/sql') diff --git a/src/sql/models/qsqltablemodel.cpp b/src/sql/models/qsqltablemodel.cpp index e0e700cd01..faecad3771 100644 --- a/src/sql/models/qsqltablemodel.cpp +++ b/src/sql/models/qsqltablemodel.cpp @@ -501,9 +501,10 @@ bool QSqlTableModel::isDirty() const Q_D(const QSqlTableModel); QSqlTableModelPrivate::CacheMap::ConstIterator i = d->cache.constBegin(); const QSqlTableModelPrivate::CacheMap::ConstIterator e = d->cache.constEnd(); - for (; i != e; i++) + for (; i != e; ++i) { if (!i.value().submitted()) return true; + } return false; } -- cgit v1.2.3