From ebe4ab04ca156c64a5c56a6fca877654b451fe3d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9rgio=20Martins?= <sergio.martins@kdab.com>
Date: Wed, 1 Jul 2015 17:23:10 +0100
Subject: Use const-ref in foreach if T is big or non-trivial

Criteria: Linux x86_64, sizeof(T) > 8

Change-Id: I78c2b776ff219fa1ff6632fde17ae25fae66c54e
Reviewed-by: Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
---
 src/tools/qdoc/qdocdatabase.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'src/tools/qdoc/qdocdatabase.cpp')

diff --git a/src/tools/qdoc/qdocdatabase.cpp b/src/tools/qdoc/qdocdatabase.cpp
index 5d815d344f..b0f1758a84 100644
--- a/src/tools/qdoc/qdocdatabase.cpp
+++ b/src/tools/qdoc/qdocdatabase.cpp
@@ -167,7 +167,7 @@ void QDocForest::setSearchOrder(QStringList& t)
     forest_.remove(primaryName);
 
     QMap<QString, Tree*>::iterator i;
-    foreach (QString m, t) {
+    foreach (const QString &m, t) {
         if (primaryName != m) {
             i = forest_.find(m);
             if (i != forest_.end()) {
@@ -1296,7 +1296,7 @@ void QDocDatabase::resolveNamespaces()
         t = forest_.nextTree();
     }
     QList<QString> keys = nmm_.uniqueKeys();
-    foreach (QString s, keys) {
+    foreach (const QString &s, keys) {
         NamespaceNode* ns = 0;
         QList<Node*> nodes = nmm_.values(s);
         int count = nmm_.remove(s);
-- 
cgit v1.2.3