From 1a5c0b26d062a380fef1bb038a9d96cde7556dc6 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Wed, 8 Oct 2014 11:35:24 +0200 Subject: Don't use QStringLiteral in comparisons For QLatin1String, operator== is overloaded, so comparing to a latin-1 (C) string literal is efficient, since strlen() is comparatively fast. OTOH, QStringLiteral, when not using RVO, litters the code with QString dtor calls, which are not inline. Worse, absent lambdas, it even allocates memory. So, just compare using QLatin1String instead. Change-Id: I7af3bf3a67c55dae33ffaf9922d004fa168a3f9c Reviewed-by: Thiago Macieira --- src/tools/qdoc/htmlgenerator.cpp | 2 +- src/tools/rcc/main.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/tools') diff --git a/src/tools/qdoc/htmlgenerator.cpp b/src/tools/qdoc/htmlgenerator.cpp index 0171897a85..32399f11c7 100644 --- a/src/tools/qdoc/htmlgenerator.cpp +++ b/src/tools/qdoc/htmlgenerator.cpp @@ -4439,7 +4439,7 @@ void HtmlGenerator::generateManifestFile(QString manifest, QString element) continue; if (tag.at(0) == '-') continue; - if (tag == QStringLiteral("qt")) + if (tag == QLatin1String("qt")) continue; if (tag.startsWith("example")) continue; diff --git a/src/tools/rcc/main.cpp b/src/tools/rcc/main.cpp index 9970745b10..3c556d76a8 100644 --- a/src/tools/rcc/main.cpp +++ b/src/tools/rcc/main.cpp @@ -182,9 +182,9 @@ int runRcc(int argc, char *argv[]) if (parser.isSet(binaryOption)) library.setFormat(RCCResourceLibrary::Binary); if (parser.isSet(passOption)) { - if (parser.value(passOption) == QStringLiteral("1")) + if (parser.value(passOption) == QLatin1String("1")) library.setFormat(RCCResourceLibrary::Pass1); - else if (parser.value(passOption) == QStringLiteral("2")) + else if (parser.value(passOption) == QLatin1String("2")) library.setFormat(RCCResourceLibrary::Pass2); else errorMsg = QLatin1String("Pass number must be 1 or 2"); -- cgit v1.2.3