From 6284d2cd77971e2b10c6d61572b358cf9b3cf897 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tor=20Arne=20Vestb=C3=B8?= Date: Thu, 5 Jul 2018 15:52:17 +0200 Subject: QWidget: Add note about fixPosIncludesFrame not supporting window states Change-Id: Iee841e7e6552e24f2b62b0c2df5df3c432680eef Reviewed-by: Gatis Paeglis --- src/widgets/kernel/qwidget.cpp | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src/widgets/kernel') diff --git a/src/widgets/kernel/qwidget.cpp b/src/widgets/kernel/qwidget.cpp index 5f1f6d880a..1e249dc191 100644 --- a/src/widgets/kernel/qwidget.cpp +++ b/src/widgets/kernel/qwidget.cpp @@ -7165,6 +7165,12 @@ void QWidget::move(const QPoint &p) // move() was invoked with Qt::WA_WState_Created not set (frame geometry // unknown), that is, crect has a position including the frame. // If we can determine the frame strut, fix that and clear the flag. +// FIXME: This does not play well with window states other than +// Qt::WindowNoState, as we depend on calling setGeometry() on the +// platform window after fixing up the position so that the new +// geometry is reflected in the platform window, but when the frame +// comes in after the window has been shown (e.g. maximized), we're +// not in a position to do that kind of fixup. void QWidgetPrivate::fixPosIncludesFrame() { Q_Q(QWidget); -- cgit v1.2.3