From e1cf5b23481af9e9646f9aeb0e45a46e31e8684d Mon Sep 17 00:00:00 2001 From: Christian Heimlich Date: Mon, 31 Aug 2020 02:01:58 -0400 Subject: Fix redundant emission of editingFinished from QLineEdit with Return key Current implementation of QLineEdit uses the "edited" bit-field flag to prevent unnecessary emissions of editingFinished() when a line edit loses focus but its contents have not changed since the last time the signal was emitted; however, this flag is only cleared when the signal is fired due to focus loss and not when the Return/Enter key is pressed. This causes an unexpected double emission of the signal when focus is lost following a press of the Return/Enter key if the line edit's text was not further altered between the two actions. This change includes the Return/Enter press as a trigger for clearing the "edited" flag to make editingFinished()'s behavior more consistent and expected. Prevents slots in user code from triggering twice in situations where the line edit's current contents have already been handled, but still allows the end-user to force an emission of the signal via Return/Enter. The effect of the "edited" flag on the signals behavior has also been noted in the signal description as it was previously omitted. [ChangeLog][QtWidgets][QLineEdit][Behavior Change] Pressing the Return/Enter key in a QLineEdit will now also prevent editingFinished() from firing due to focus loss if the contents of the line edit have not changed since the last time the signal was emitted. See - https://forum.qt.io/topic/116902/ Change-Id: I11aadd45341337b7852da8cf5802c7c9efdd614d Reviewed-by: Volker Hilsheimer --- src/widgets/widgets/qlineedit_p.h | 1 + 1 file changed, 1 insertion(+) (limited to 'src/widgets/widgets/qlineedit_p.h') diff --git a/src/widgets/widgets/qlineedit_p.h b/src/widgets/widgets/qlineedit_p.h index 049f7a3bdf..936cf2d088 100644 --- a/src/widgets/widgets/qlineedit_p.h +++ b/src/widgets/widgets/qlineedit_p.h @@ -233,6 +233,7 @@ public: #endif void _q_textChanged(const QString &); void _q_clearButtonClicked(); + void _q_controlEditingFinished(); QMargins textMargins; // use effectiveTextMargins() in case of icon. -- cgit v1.2.3