From 8094c8fe184ae10fe8673bc35a16bfe17b7510ff Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Fri, 28 Dec 2012 20:38:19 -0200 Subject: Remove unused function _q_qgraphicsItemSetFlag Clang reports: graphicsview/qgraphicsitem.cpp:1779:13: error: function '_q_qgraphicsItemSetFlag' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration] static void _q_qgraphicsItemSetFlag(QGraphicsItem *item, QGraphicsItem::GraphicsItemFlag flag, ^ According to the public Git history, in Qt 4.5.1 this function was already unused. The only reason it wasn't caught so far is that it is recursive: it calls itself. So it is used... by itself. Change-Id: I6fc6b33cb314b845525dc9315d0ad742e113d5cd Reviewed-by: Andreas Aardal Hanssen Reviewed-by: Olivier Goffart --- src/widgets/graphicsview/qgraphicsitem.cpp | 18 ------------------ 1 file changed, 18 deletions(-) (limited to 'src/widgets') diff --git a/src/widgets/graphicsview/qgraphicsitem.cpp b/src/widgets/graphicsview/qgraphicsitem.cpp index 3ba9b89e34..ec4a1827ef 100644 --- a/src/widgets/graphicsview/qgraphicsitem.cpp +++ b/src/widgets/graphicsview/qgraphicsitem.cpp @@ -1771,24 +1771,6 @@ void QGraphicsItem::setFlag(GraphicsItemFlag flag, bool enabled) setFlags(GraphicsItemFlags(d_ptr->flags) & ~flag); } -/*! - \internal - - Sets the flag \a flag on \a item and all its children, to \a enabled. -*/ -static void _q_qgraphicsItemSetFlag(QGraphicsItem *item, QGraphicsItem::GraphicsItemFlag flag, - bool enabled) -{ - if (item->flags() & flag) { - // If this item already has the correct flag set, we don't have to - // propagate it. - return; - } - item->setFlag(flag, enabled); - foreach (QGraphicsItem *child, item->childItems()) - _q_qgraphicsItemSetFlag(child, flag, enabled); -} - /*! Sets the item flags to \a flags. All flags in \a flags are enabled; all flags not in \a flags are disabled. -- cgit v1.2.3