From 181e96cae2db8ec0b87adc18db1c603bf41fc0ed Mon Sep 17 00:00:00 2001
From: Allan Sandfeld Jensen <allan.jensen@qt.io>
Date: Fri, 12 Jul 2019 10:33:07 +0200
Subject: Remove public d_func from QColorSpace

Replaced with getter in private.

Change-Id: I968eb45052a80b45750213cf6a0c08b5973dfc4d
Reviewed-by: Eirik Aavitsland <eirik.aavitsland@qt.io>
---
 src/gui/image/qpnghandler.cpp    |  5 +++--
 src/gui/painting/qcolorspace.cpp | 14 --------------
 src/gui/painting/qcolorspace.h   |  4 +---
 src/gui/painting/qcolorspace_p.h | 11 +++++++++++
 src/gui/painting/qicc.cpp        |  4 ++--
 5 files changed, 17 insertions(+), 21 deletions(-)

(limited to 'src')

diff --git a/src/gui/image/qpnghandler.cpp b/src/gui/image/qpnghandler.cpp
index cd1c1d5433..4b72888414 100644
--- a/src/gui/image/qpnghandler.cpp
+++ b/src/gui/image/qpnghandler.cpp
@@ -607,7 +607,8 @@ bool QPngHandlerPrivate::readPngHeader()
 #endif
         png_uint_32 profLen;
         png_get_iCCP(png_ptr, info_ptr, &name, &compressionType, &profileData, &profLen);
-        if (!QIcc::fromIccProfile(QByteArray::fromRawData((const char *)profileData, profLen), &colorSpace)) {
+        colorSpace = QColorSpace::fromIccProfile(QByteArray::fromRawData((const char *)profileData, profLen));
+        if (!colorSpace.isValid()) {
             qWarning() << "QPngHandler: Failed to parse ICC profile";
         } else {
             colorSpaceState = Icc;
@@ -677,7 +678,7 @@ bool QPngHandlerPrivate::readPngImage(QImage *outImage)
         // This configuration forces gamma correction and
         // thus changes the output colorspace
         png_set_gamma(png_ptr, 1.0f / gamma, fileGamma);
-        QColorSpacePrivate *csPrivate = colorSpace.d_func();
+        QColorSpacePrivate *csPrivate = QColorSpacePrivate::getWritable(colorSpace);
         csPrivate->transferFunction = QColorSpace::TransferFunction::Gamma;
         csPrivate->gamma = gamma;
         csPrivate->setTransferFunction();
diff --git a/src/gui/painting/qcolorspace.cpp b/src/gui/painting/qcolorspace.cpp
index 881a02ee67..3c336c9fe7 100644
--- a/src/gui/painting/qcolorspace.cpp
+++ b/src/gui/painting/qcolorspace.cpp
@@ -683,20 +683,6 @@ QColorTransform QColorSpace::transformationToColorSpace(const QColorSpace &color
     return d_ptr->transformationToColorSpace(colorspace.d_ptr.constData());
 }
 
-/*!
-    \internal
-*/
-QColorSpacePrivate *QColorSpace::d_func()
-{
-    d_ptr.detach();
-    return d_ptr.data();
-}
-
-/*!
-    \fn const QColorSpacePrivate* QColorSpacePrivate::d_func() const
-    \internal
-*/
-
 /*****************************************************************************
   QColorSpace stream functions
  *****************************************************************************/
diff --git a/src/gui/painting/qcolorspace.h b/src/gui/painting/qcolorspace.h
index 6f1a806b60..709ce38916 100644
--- a/src/gui/painting/qcolorspace.h
+++ b/src/gui/painting/qcolorspace.h
@@ -113,11 +113,9 @@ public:
 
     QColorTransform transformationToColorSpace(const QColorSpace &colorspace) const;
 
-    QColorSpacePrivate *d_func();
-    inline const QColorSpacePrivate *d_func() const { return d_ptr.constData(); }
 
 private:
-    friend class QColorSpacePrivate;
+    Q_DECLARE_PRIVATE(QColorSpace)
     QExplicitlySharedDataPointer<QColorSpacePrivate> d_ptr;
 };
 
diff --git a/src/gui/painting/qcolorspace_p.h b/src/gui/painting/qcolorspace_p.h
index 95e0655d0c..75b74f062f 100644
--- a/src/gui/painting/qcolorspace_p.h
+++ b/src/gui/painting/qcolorspace_p.h
@@ -95,6 +95,17 @@ public:
     QColorSpacePrivate(const QColorSpacePrimaries &primaries, QColorSpace::TransferFunction fun, float gamma);
     QColorSpacePrivate(const QColorSpacePrivate &other) = default;
 
+    static QColorSpacePrivate *getWritable(QColorSpace &colorSpace)
+    {
+        colorSpace.d_ptr.detach();
+        return colorSpace.d_ptr.data();
+    }
+
+    static const QColorSpacePrivate *get(const QColorSpace &colorSpace)
+    {
+        return colorSpace.d_ptr.data();
+    }
+
     void initialize();
     void setToXyzMatrix();
     void setTransferFunction();
diff --git a/src/gui/painting/qicc.cpp b/src/gui/painting/qicc.cpp
index d88b005782..2abb42993b 100644
--- a/src/gui/painting/qicc.cpp
+++ b/src/gui/painting/qicc.cpp
@@ -288,7 +288,7 @@ QByteArray toIccProfile(const QColorSpace &space)
     if (!space.isValid())
         return QByteArray();
 
-    const QColorSpacePrivate *spaceDPtr = space.d_func();
+    const QColorSpacePrivate *spaceDPtr = QColorSpacePrivate::get(space);
 
     constexpr int tagCount = 9;
     constexpr uint profileDataOffset = 128 + 4 + 12 * tagCount;
@@ -569,7 +569,7 @@ bool fromIccProfile(const QByteArray &data, QColorSpace *colorSpace)
         qCWarning(lcIcc) << "fromIccProfile: Bad XYZ data type";
         return false;
     }
-    QColorSpacePrivate *colorspaceDPtr = colorSpace->d_func();
+    QColorSpacePrivate *colorspaceDPtr = QColorSpacePrivate::getWritable(*colorSpace);
 
     colorspaceDPtr->toXyz.r = fromXyzData(rXyz);
     colorspaceDPtr->toXyz.g = fromXyzData(gXyz);
-- 
cgit v1.2.3