From 18e5d10426e7b116f02b20c258542c4de4f18560 Mon Sep 17 00:00:00 2001 From: Stephan Binner Date: Mon, 29 May 2017 16:56:28 +0200 Subject: Convert features.cups to QT_[REQUIRE_]CONFIG Change-Id: I189134b41c4f6e4ac42b5e47ae79338c744b581d Reviewed-by: Oswald Buddenhagen --- src/printsupport/dialogs/qpagesetupdialog_unix.cpp | 8 +++++--- src/printsupport/dialogs/qprintdialog_unix.cpp | 10 +++++----- src/printsupport/kernel/qcups.cpp | 4 ---- src/printsupport/kernel/qcups_p.h | 4 +--- src/printsupport/kernel/qprint_p.h | 4 ++-- src/printsupport/widgets/qcupsjobwidget.cpp | 4 ---- src/printsupport/widgets/widgets.pri | 2 +- 7 files changed, 14 insertions(+), 22 deletions(-) (limited to 'src') diff --git a/src/printsupport/dialogs/qpagesetupdialog_unix.cpp b/src/printsupport/dialogs/qpagesetupdialog_unix.cpp index 98d657bed4..fdaeb7ae8c 100644 --- a/src/printsupport/dialogs/qpagesetupdialog_unix.cpp +++ b/src/printsupport/dialogs/qpagesetupdialog_unix.cpp @@ -44,7 +44,9 @@ #include #include +#if QT_CONFIG(cups) #include +#endif #include "qpainter.h" #include "qprintdialog.h" @@ -294,7 +296,7 @@ void QPageSetupWidget::initUnits() // Init the Pages Per Sheet (n-up) combo boxes if using CUPS void QPageSetupWidget::initPagesPerSheet() { -#if !defined(QT_NO_CUPS) +#if QT_CONFIG(cups) m_ui.pagesPerSheetLayoutCombo->addItem(QPrintDialog::tr("Left to Right, Top to Bottom"), QVariant::fromValue(QCUPSSupport::LeftToRightTopToBottom)); m_ui.pagesPerSheetLayoutCombo->addItem(QPrintDialog::tr("Left to Right, Bottom to Top"), @@ -498,7 +500,7 @@ void QPageSetupWidget::updateWidget() void QPageSetupWidget::setupPrinter() const { m_printer->setPageLayout(m_pageLayout); -#if !defined(QT_NO_CUPS) +#if QT_CONFIG(cups) QCUPSSupport::PagesPerSheet pagesPerSheet = m_ui.pagesPerSheetCombo->currentData() .value(); QCUPSSupport::PagesPerSheetLayout pagesPerSheetLayout = m_ui.pagesPerSheetLayoutCombo->currentData() @@ -545,7 +547,7 @@ void QPageSetupWidget::pageOrientationChanged() void QPageSetupWidget::pagesPerSheetChanged() { -#if !defined(QT_NO_CUPS) +#if QT_CONFIG(cups) switch (m_ui.pagesPerSheetCombo->currentData().toInt()) { case QCUPSSupport::OnePagePerSheet: m_pagePreview->setPagePreviewLayout(1, 1); diff --git a/src/printsupport/dialogs/qprintdialog_unix.cpp b/src/printsupport/dialogs/qprintdialog_unix.cpp index 5527cd94f9..7c0e064ddd 100644 --- a/src/printsupport/dialogs/qprintdialog_unix.cpp +++ b/src/printsupport/dialogs/qprintdialog_unix.cpp @@ -64,7 +64,7 @@ #include "ui_qprintsettingsoutput.h" #include "ui_qprintwidget.h" -#ifndef QT_NO_CUPS +#if QT_CONFIG(cups) #include #if QT_CONFIG(cupsjobwidget) #include "qcupsjobwidget_p.h" @@ -313,7 +313,7 @@ void QPrintDialogPrivate::init() options.grayscale->setIconSize(QSize(32, 32)); options.grayscale->setIcon(QIcon(QLatin1String(":/qt-project.org/dialogs/qprintdialog/images/status-gray-scale.png"))); -#ifndef QT_NO_CUPS +#if QT_CONFIG(cups) // Add Page Set widget if CUPS is available options.pageSetCombo->addItem(tr("All Pages"), QVariant::fromValue(QCUPSSupport::AllPages)); options.pageSetCombo->addItem(tr("Odd Pages"), QVariant::fromValue(QCUPSSupport::OddPages)); @@ -435,7 +435,7 @@ void QPrintDialogPrivate::setupPrinter() } } -#ifndef QT_NO_CUPS +#if QT_CONFIG(cups) // page set if (p->printRange() == QPrinter::AllPages || p->printRange() == QPrinter::PageRange) { //If the application is selecting pages and the first page number is even then need to adjust the odd-even accordingly @@ -518,7 +518,7 @@ void QPrintDialogPrivate::updateWidgets() options.printCurrentPage->setVisible(q->isOptionEnabled(QPrintDialog::PrintCurrentPage)); options.collate->setVisible(q->isOptionEnabled(QPrintDialog::PrintCollateCopies)); -#ifndef QT_NO_CUPS +#if QT_CONFIG(cups) // Don't display Page Set if only Selection or Current Page are enabled if (!q->isOptionEnabled(QPrintDialog::PrintPageRange) && (q->isOptionEnabled(QPrintDialog::PrintSelection) || q->isOptionEnabled(QPrintDialog::PrintCurrentPage))) { @@ -867,7 +867,7 @@ bool QUnixPrintWidgetPrivate::checkFields() } } -#ifndef QT_NO_CUPS +#if QT_CONFIG(cups) if (propertiesDialogShown) { QCUPSSupport::PagesPerSheet pagesPerSheet = propertiesDialog->widget.pageSetup->m_ui.pagesPerSheetCombo ->currentData().value(); diff --git a/src/printsupport/kernel/qcups.cpp b/src/printsupport/kernel/qcups.cpp index d655dd09ba..48ab71eea4 100644 --- a/src/printsupport/kernel/qcups.cpp +++ b/src/printsupport/kernel/qcups.cpp @@ -41,8 +41,6 @@ #include "qprintengine.h" -#ifndef QT_NO_CUPS - QT_BEGIN_NAMESPACE QStringList QCUPSSupport::cupsOptionsList(QPrinter *printer) @@ -205,5 +203,3 @@ void QCUPSSupport::setPageRange(QPrinter *printer, int pageFrom, int pageTo) } QT_END_NAMESPACE - -#endif // QT_NO_CUPS diff --git a/src/printsupport/kernel/qcups_p.h b/src/printsupport/kernel/qcups_p.h index 139b18c509..780115e350 100644 --- a/src/printsupport/kernel/qcups_p.h +++ b/src/printsupport/kernel/qcups_p.h @@ -57,7 +57,7 @@ #include "QtPrintSupport/qprinter.h" #include "QtCore/qdatetime.h" -#ifndef QT_NO_CUPS +QT_REQUIRE_CONFIG(cups); QT_BEGIN_NAMESPACE @@ -150,6 +150,4 @@ Q_DECLARE_METATYPE(QCUPSSupport::PageSet) Q_DECLARE_METATYPE(QCUPSSupport::PagesPerSheetLayout) Q_DECLARE_METATYPE(QCUPSSupport::PagesPerSheet) -#endif // QT_NO_CUPS - #endif diff --git a/src/printsupport/kernel/qprint_p.h b/src/printsupport/kernel/qprint_p.h index 47dfce3787..280c2d7608 100644 --- a/src/printsupport/kernel/qprint_p.h +++ b/src/printsupport/kernel/qprint_p.h @@ -57,7 +57,7 @@ #include #include -#if (defined Q_OS_OSX) || (defined Q_OS_UNIX && !defined QT_NO_CUPS) +#if (defined Q_OS_MACOS) || (defined Q_OS_UNIX && QT_CONFIG(cups)) #include // Use for type defs only, don't want to actually link in main module #endif @@ -245,7 +245,7 @@ public: return QByteArray(); } -#if (defined Q_OS_OSX) || (defined Q_OS_UNIX && !defined QT_NO_CUPS) +#if (defined Q_OS_MACOS) || (defined Q_OS_UNIX && QT_CONFIG(cups)) // PPD utilities shared by CUPS and Mac plugins requiring CUPS headers // May turn into a proper internal QPpd class if enough shared between Mac and CUPS, diff --git a/src/printsupport/widgets/qcupsjobwidget.cpp b/src/printsupport/widgets/qcupsjobwidget.cpp index 204a125d13..00f2d64df2 100644 --- a/src/printsupport/widgets/qcupsjobwidget.cpp +++ b/src/printsupport/widgets/qcupsjobwidget.cpp @@ -54,8 +54,6 @@ QT_BEGIN_NAMESPACE -#if !defined(QT_NO_PRINTER) && !defined(QT_NO_CUPS) - /*! \internal \class QCupsJobWidget @@ -212,6 +210,4 @@ QCUPSSupport::BannerPage QCupsJobWidget::endBannerPage() const return m_ui.endBannerPageCombo->itemData(m_ui.endBannerPageCombo->currentIndex()).value(); } -#endif // QT_NO_PRINTER / QT_NO_CUPS - QT_END_NAMESPACE diff --git a/src/printsupport/widgets/widgets.pri b/src/printsupport/widgets/widgets.pri index 505983778e..1fa32764e8 100644 --- a/src/printsupport/widgets/widgets.pri +++ b/src/printsupport/widgets/widgets.pri @@ -1,7 +1,7 @@ HEADERS += widgets/qprintpreviewwidget.h SOURCES += widgets/qprintpreviewwidget.cpp -unix:!darwin:qtConfig(cups):qtConfig(cupsjobwidget) { +unix:!darwin:qtConfig(cupsjobwidget) { HEADERS += widgets/qcupsjobwidget_p.h SOURCES += widgets/qcupsjobwidget.cpp FORMS += widgets/qcupsjobwidget.ui -- cgit v1.2.3