From 456699da93323ca3ad56ca8f16aa3197dec380e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A5rten=20Nordheim?= Date: Thu, 19 Nov 2020 11:21:09 +0100 Subject: QSocks5SocketEngine: Fix out-of-bounds access of QBA This should've been caught a long time ago, but long story short: it wasn't. This has been deprecated since 5.14 and is now asserting. Pick-to: 5.15 Change-Id: Iddee22b1a68e5d1a03006831f795db8ec1c472be Reviewed-by: Giuseppe D'Angelo --- src/network/socket/qsocks5socketengine.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src') diff --git a/src/network/socket/qsocks5socketengine.cpp b/src/network/socket/qsocks5socketengine.cpp index 3d40840c1b..d681bec2d5 100644 --- a/src/network/socket/qsocks5socketengine.cpp +++ b/src/network/socket/qsocks5socketengine.cpp @@ -1635,9 +1635,7 @@ qint64 QSocks5SocketEngine::writeDatagram(const char *data, qint64 len, const QI QByteArray outBuf; outBuf.reserve(270 + len); - outBuf[0] = 0x00; - outBuf[1] = 0x00; - outBuf[2] = 0x00; + outBuf.append(3, '\0'); if (!qt_socks5_set_host_address_and_port(header.destinationAddress, header.destinationPort, &outBuf)) { } outBuf += QByteArray(data, len); -- cgit v1.2.3