From 84a3dacf462a4170a7fbc71b012fbb2db2c34a19 Mon Sep 17 00:00:00 2001 From: Giuseppe D'Angelo Date: Thu, 13 Nov 2014 21:41:04 +0100 Subject: QItemDelegate: let QTextEdit and QPlainTextEdit receive tab keypresses MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We already let enter/return key presses to reach text edits instead of closing the editor. Do the same for tab/backtabs. [ChangeLog][QtWidgets][Important behavior changes] QItemDelegate will now not close a QTextEdit/QPlainTextEdit editor when the tab key is pressed; instead, the key will reach the editor. Task-number: QTBUG-3305 Change-Id: Ife9e6fdc5678535c596d1068770b0963134d8d5a Reviewed-by: Friedemann Kleint Reviewed-by: Thorbjørn Lindeijer Reviewed-by: Thorbjørn Lund Martsum --- src/widgets/itemviews/qabstractitemdelegate.cpp | 33 +++++++++++++++++++++---- 1 file changed, 28 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/widgets/itemviews/qabstractitemdelegate.cpp b/src/widgets/itemviews/qabstractitemdelegate.cpp index 4d0840c3d6..c4c3d2acfd 100644 --- a/src/widgets/itemviews/qabstractitemdelegate.cpp +++ b/src/widgets/itemviews/qabstractitemdelegate.cpp @@ -420,6 +420,29 @@ QAbstractItemDelegatePrivate::QAbstractItemDelegatePrivate() { } +static bool editorHandlesKeyEvent(QWidget *editor, const QKeyEvent *event) +{ +#ifndef QT_NO_TEXTEDIT + // do not filter enter / return / tab / backtab for QTextEdit or QPlainTextEdit + if (qobject_cast(editor) || qobject_cast(editor)) { + switch (event->key()) { + case Qt::Key_Tab: + case Qt::Key_Backtab: + case Qt::Key_Enter: + case Qt::Key_Return: + return true; + + default: + break; + } + } +#endif // QT_NO_TEXTEDIT + + Q_UNUSED(editor); + Q_UNUSED(event); + return false; +} + bool QAbstractItemDelegatePrivate::editorEventFilter(QObject *object, QEvent *event) { Q_Q(QAbstractItemDelegate); @@ -428,7 +451,11 @@ bool QAbstractItemDelegatePrivate::editorEventFilter(QObject *object, QEvent *ev if (!editor) return false; if (event->type() == QEvent::KeyPress) { - switch (static_cast(event)->key()) { + QKeyEvent *keyEvent = static_cast(event); + if (editorHandlesKeyEvent(editor, keyEvent)) + return false; + + switch (keyEvent->key()) { case Qt::Key_Tab: if (tryFixup(editor)) { emit q->commitData(editor); @@ -443,10 +470,6 @@ bool QAbstractItemDelegatePrivate::editorEventFilter(QObject *object, QEvent *ev return true; case Qt::Key_Enter: case Qt::Key_Return: -#ifndef QT_NO_TEXTEDIT - if (qobject_cast(editor) || qobject_cast(editor)) - return false; // don't filter enter key events for QTextEdit or QPlainTextEdit -#endif // QT_NO_TEXTEDIT // We want the editor to be able to process the key press // before committing the data (e.g. so it can do // validation/fixup of the input). -- cgit v1.2.3