From 9149aebac96fb6134bf567b3266bf67d706893cf Mon Sep 17 00:00:00 2001 From: Shane Kearns Date: Tue, 22 May 2012 12:31:23 +0100 Subject: Fix compile warnings with MSVC Calling a static function non statically causes an unused variable warning for the optimised away d pointer. sscanf causes an insecure functions warning. (Even though it was used safely in this case) Change-Id: I07700e2155284ef3ebbe7d604ed59b2e61ee7f95 Reviewed-by: Friedemann Kleint --- src/network/access/qnetworkrequest.cpp | 7 +++++++ src/network/socket/qabstractsocket.cpp | 3 +-- 2 files changed, 8 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/network/access/qnetworkrequest.cpp b/src/network/access/qnetworkrequest.cpp index 9df06328a1..cb4614bb0a 100644 --- a/src/network/access/qnetworkrequest.cpp +++ b/src/network/access/qnetworkrequest.cpp @@ -1043,7 +1043,14 @@ QDateTime QNetworkHeadersPrivate::fromHttpDate(const QByteArray &value) if (pos == 3) { char month_name[4]; int day, year, hour, minute, second; +#ifdef Q_CC_MSVC + // Use secure version to avoid compiler warning + if (sscanf_s(value.constData(), "%*3s, %d %3s %d %d:%d:%d 'GMT'", &day, month_name, 4, &year, &hour, &minute, &second) == 6) +#else + // The POSIX secure mode is %ms (which allocates memory), too bleeding edge for now + // In any case this is already safe as field width is specified. if (sscanf(value.constData(), "%*3s, %d %3s %d %d:%d:%d 'GMT'", &day, month_name, &year, &hour, &minute, &second) == 6) +#endif dt = QDateTime(QDate(year, name_to_month(month_name), day), QTime(hour, minute, second)); } else { QLocale c = QLocale::c(); diff --git a/src/network/socket/qabstractsocket.cpp b/src/network/socket/qabstractsocket.cpp index 7abcb24291..8d1c134d7d 100644 --- a/src/network/socket/qabstractsocket.cpp +++ b/src/network/socket/qabstractsocket.cpp @@ -1378,8 +1378,7 @@ QAbstractSocket::~QAbstractSocket() */ void QAbstractSocket::resume() { - Q_D(QAbstractSocket); - d->resumeSocketNotifiers(this); + QAbstractSocketPrivate::resumeSocketNotifiers(this); } /*! -- cgit v1.2.3