From b3f3ebc2c0c9ba4142d553d02c86497377f4b3ef Mon Sep 17 00:00:00 2001
From: Ulf Hermann <ulf.hermann@qt.io>
Date: Fri, 16 Oct 2020 08:56:48 +0200
Subject: Fix "variable set but unused" in qvariant.cpp

... how did that pass the CI?

Change-Id: I84baaf3632df0410d1fb25f24fd22f65daae13af
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
---
 src/corelib/kernel/qvariant.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src')

diff --git a/src/corelib/kernel/qvariant.cpp b/src/corelib/kernel/qvariant.cpp
index 1555b26d99..09c3eee6ea 100644
--- a/src/corelib/kernel/qvariant.cpp
+++ b/src/corelib/kernel/qvariant.cpp
@@ -2265,7 +2265,7 @@ int spaceShip(Numeric lhs, Numeric rhs) {
         smaller = std::less<QObject *>()(lhs, rhs); // can't use less all the time because of bool
     else
         smaller = lhs < rhs;
-    if (lhs < rhs)
+    if (smaller)
         return -1;
     else if (lhs == rhs)
         return 0;
-- 
cgit v1.2.3