From dee26fe973083f8e94fcf5bcbb7fedbe5c35edfd Mon Sep 17 00:00:00 2001 From: Thomas McGuire Date: Mon, 2 Apr 2012 11:19:05 +0200 Subject: Get rid of false positive warning when stopping video playback The multimedia library actually creates two windows, and therefore the first call to updateHierarchy() would try to update the z-order of a no longer existing window. Change-Id: I499d049e2885ff848f38d9cc5880aa63235b1b4c Reviewed-by: Kevin Krammer Reviewed-by: Sean Harmer Reviewed-by: Robin Burchell --- src/plugins/platforms/qnx/qqnxscreen.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/plugins/platforms/qnx/qqnxscreen.cpp b/src/plugins/platforms/qnx/qqnxscreen.cpp index 183878bd07..7ae1988bff 100644 --- a/src/plugins/platforms/qnx/qqnxscreen.cpp +++ b/src/plugins/platforms/qnx/qqnxscreen.cpp @@ -263,8 +263,10 @@ void QQnxScreen::updateHierarchy() topZorder++; Q_FOREACH (screen_window_t overlay, m_overlays) { - if (screen_set_window_property_iv(overlay, SCREEN_PROPERTY_ZORDER, &topZorder) != 0) - qWarning("QQnxScreen: failed to update z order for overlay, errno=%d", errno); + // Do nothing when this fails. This can happen if we have stale windows in mOverlays, + // which in turn can happen because a window was removed but we didn't get a notification + // yet. + screen_set_window_property_iv(overlay, SCREEN_PROPERTY_ZORDER, &topZorder); topZorder++; } -- cgit v1.2.3