From 66c3f8753c0557fdfafc79cdab11fbd6ffde9105 Mon Sep 17 00:00:00 2001 From: Jason McDonald Date: Wed, 26 Oct 2011 10:52:54 +1000 Subject: Remove inappropriate QSKIP in QTextCodec autotest. There were only two ways the QSKIP could be called: (1) the C++ runtime is broken, or (2) the earlier call to resize the string failed. In both cases there should be a hard test failure. In the former case, a broken C++ runtime calls all of the test results into question. In the latter case, the QByteArray::resize() method has suffered a regression. Change-Id: I5adf942d2eb4d746d2ab31e98571c5d9bdd40890 Reviewed-by: Rohan McGovern --- tests/auto/corelib/codecs/qtextcodec/tst_qtextcodec.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'tests/auto/corelib/codecs') diff --git a/tests/auto/corelib/codecs/qtextcodec/tst_qtextcodec.cpp b/tests/auto/corelib/codecs/qtextcodec/tst_qtextcodec.cpp index c3002a81bc..4c9fc49e65 100644 --- a/tests/auto/corelib/codecs/qtextcodec/tst_qtextcodec.cpp +++ b/tests/auto/corelib/codecs/qtextcodec/tst_qtextcodec.cpp @@ -340,8 +340,7 @@ void tst_QTextCodec::codecForLocale() originalLocaleEncodedTimeString.size(), "%A%a%B%b%Z", localtime(&t)); - if (r == 0) - QSKIP("strftime() failed"); + QVERIFY(r != 0); originalLocaleEncodedTimeString.resize(r); QString unicodeTimeString = codec->toUnicode(originalLocaleEncodedTimeString); -- cgit v1.2.3