From 12559058b029720527c718a876889b0850ed1590 Mon Sep 17 00:00:00 2001 From: Kari Oikarinen Date: Wed, 18 Apr 2018 15:40:21 +0300 Subject: tst_QFile: Don't expect Windows HANDLE equality in nativeHandleLeaks() That check is flaky on Windows. It doesn't seem to be testing Qt functionality. I also don't see CreateFile2() documentation mentioning any guarantees that opening the same file twice would give the same HANDLE each time. Change-Id: Ica2e60571ae9fc39bf822803a2a9dd6add8323d7 Reviewed-by: Thiago Macieira Reviewed-by: Joerg Bornemann Reviewed-by: Friedemann Kleint --- tests/auto/corelib/io/qfile/tst_qfile.cpp | 4 ---- 1 file changed, 4 deletions(-) (limited to 'tests/auto/corelib/io/qfile/tst_qfile.cpp') diff --git a/tests/auto/corelib/io/qfile/tst_qfile.cpp b/tests/auto/corelib/io/qfile/tst_qfile.cpp index cd13e2bd19..ad00e25e7d 100644 --- a/tests/auto/corelib/io/qfile/tst_qfile.cpp +++ b/tests/auto/corelib/io/qfile/tst_qfile.cpp @@ -2878,10 +2878,6 @@ void tst_QFile::nativeHandleLeaks() #endif QCOMPARE( fd2, fd1 ); - -#ifdef Q_OS_WIN - QCOMPARE( handle2, handle1 ); -#endif } void tst_QFile::readEof_data() -- cgit v1.2.3