From 371c21b9a843619c4a0dd220f28b7eb50383290d Mon Sep 17 00:00:00 2001 From: Caroline Chao Date: Wed, 26 Sep 2012 08:02:49 +0200 Subject: Test: tst_QFile::writeLargeDataBlock() unstable failure as XFAIL While the large data block can be written to a file, the test is also showing instability while reading back the written block. Adding another expected failure to address this instability. Task-number: QTBUG-26906 Change-Id: I9704d441cf2bd6d7ef0f9023240ea61bb89561b6 Reviewed-by: Rohan McGovern --- tests/auto/corelib/io/qfile/tst_qfile.cpp | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) (limited to 'tests/auto/corelib/io/qfile/tst_qfile.cpp') diff --git a/tests/auto/corelib/io/qfile/tst_qfile.cpp b/tests/auto/corelib/io/qfile/tst_qfile.cpp index 0478b07006..d0fa303573 100644 --- a/tests/auto/corelib/io/qfile/tst_qfile.cpp +++ b/tests/auto/corelib/io/qfile/tst_qfile.cpp @@ -2277,7 +2277,7 @@ void tst_QFile::writeLargeDataBlock() qWarning() << qPrintable(QString("Error writing a large data block to [%1]: %2") .arg(fileName) .arg(file.errorString())); - QEXPECT_FAIL("unc file", "QTBUG-26906", Abort); + QEXPECT_FAIL("unc file", "QTBUG-26906 writing", Abort); } #endif QCOMPARE( fileWriteOriginalData, originalDataSize ); @@ -2294,9 +2294,17 @@ void tst_QFile::writeLargeDataBlock() QVERIFY2( openFile(file, QIODevice::ReadOnly, (FileType)type), qPrintable(QString("Couldn't open file for reading: [%1]").arg(fileName)) ); readData = file.readAll(); + +#if defined(Q_OS_WIN) + if (readData != originalData) { + qWarning() << qPrintable(QString("Error reading a large data block from [%1]: %2") + .arg(fileName) + .arg(file.errorString())); + QEXPECT_FAIL("unc file", "QTBUG-26906 reading", Abort); + } +#endif closeFile(file); } - QCOMPARE( readData, originalData ); QVERIFY( QFile::remove(fileName) ); } -- cgit v1.2.3