From 0ef76c77b8deb3ab18faac5138de174e06b84bc6 Mon Sep 17 00:00:00 2001 From: Fabian Kosmale Date: Sat, 21 Nov 2020 11:10:50 +0100 Subject: QMetaType: Track whether type is QML list type This information is required in the QML engine to handle list properties (instances of QQmlListproperty and list types from QML). Change-Id: I1e30572f1c91f58b290cb9b4b07433af99a1db6f Reviewed-by: Ulf Hermann (cherry picked from commit 5806ecf5cb24cf39ea2608d42246eafbaa817582) Reviewed-by: Qt Cherry-pick Bot --- .../corelib/kernel/qmetatype/tst_qmetatype.cpp | 42 ++++++++++++---------- 1 file changed, 23 insertions(+), 19 deletions(-) (limited to 'tests/auto/corelib') diff --git a/tests/auto/corelib/kernel/qmetatype/tst_qmetatype.cpp b/tests/auto/corelib/kernel/qmetatype/tst_qmetatype.cpp index 503e9b0e33..58f1772e91 100644 --- a/tests/auto/corelib/kernel/qmetatype/tst_qmetatype.cpp +++ b/tests/auto/corelib/kernel/qmetatype/tst_qmetatype.cpp @@ -1093,37 +1093,39 @@ void tst_QMetaType::flags_data() QTest::addColumn("isComplex"); QTest::addColumn("isPointerToQObject"); QTest::addColumn("isEnum"); + QTest::addColumn("isQmlList"); #define ADD_METATYPE_TEST_ROW(MetaTypeName, MetaTypeId, RealType) \ QTest::newRow(#RealType) << MetaTypeId \ << bool(QTypeInfo::isRelocatable) \ << bool(QTypeInfo::isComplex) \ << bool(QtPrivate::IsPointerToTypeDerivedFromQObject::Value) \ - << bool(std::is_enum::value); + << bool(std::is_enum::value) \ + << false; QT_FOR_EACH_STATIC_CORE_CLASS(ADD_METATYPE_TEST_ROW) QT_FOR_EACH_STATIC_PRIMITIVE_POINTER(ADD_METATYPE_TEST_ROW) QT_FOR_EACH_STATIC_CORE_POINTER(ADD_METATYPE_TEST_ROW) #undef ADD_METATYPE_TEST_ROW - QTest::newRow("TestSpace::Foo") << ::qMetaTypeId() << false << true << false << false; - QTest::newRow("Whity") << ::qMetaTypeId >() << true << true << false << false; - QTest::newRow("CustomMovable") << ::qMetaTypeId() << true << true << false << false; - QTest::newRow("CustomObject*") << ::qMetaTypeId() << true << false << true << false; - QTest::newRow("CustomMultiInheritanceObject*") << ::qMetaTypeId() << true << false << true << false; - QTest::newRow("QPair") << ::qMetaTypeId >() << false << true << false << false; - QTest::newRow("QPair") << ::qMetaTypeId >() << false << true << false << false; - QTest::newRow("QPair") << ::qMetaTypeId >() << false << true << false << false; - QTest::newRow("QPair") << ::qMetaTypeId >() << false << true << false << false; - QTest::newRow("QPair") << ::qMetaTypeId >() << true << true << false << false; - QTest::newRow("QPair") << ::qMetaTypeId >() << true << true << false << false; - QTest::newRow("QPair") << ::qMetaTypeId >() << false << true << false << false; - QTest::newRow("QPair") << ::qMetaTypeId >() << true << true << false << false; - QTest::newRow("QPair") << ::qMetaTypeId >() << true << false << false << false; - QTest::newRow("FlagsDataEnum") << ::qMetaTypeId() << true << false << false << true; + QTest::newRow("TestSpace::Foo") << ::qMetaTypeId() << false << true << false << false << false; + QTest::newRow("Whity") << ::qMetaTypeId >() << true << true << false << false << false; + QTest::newRow("CustomMovable") << ::qMetaTypeId() << true << true << false << false << false; + QTest::newRow("CustomObject*") << ::qMetaTypeId() << true << false << true << false << false; + QTest::newRow("CustomMultiInheritanceObject*") << ::qMetaTypeId() << true << false << true << false << false; + QTest::newRow("QPair") << ::qMetaTypeId >() << false << true << false << false << false; + QTest::newRow("QPair") << ::qMetaTypeId >() << false << true << false << false << false; + QTest::newRow("QPair") << ::qMetaTypeId >() << false << true << false << false << false; + QTest::newRow("QPair") << ::qMetaTypeId >() << false << true << false << false << false; + QTest::newRow("QPair") << ::qMetaTypeId >() << true << true << false << false << false; + QTest::newRow("QPair") << ::qMetaTypeId >() << true << true << false << false << false; + QTest::newRow("QPair") << ::qMetaTypeId >() << false << true << false << false << false; + QTest::newRow("QPair") << ::qMetaTypeId >() << true << true << false << false << false; + QTest::newRow("QPair") << ::qMetaTypeId >() << true << false << false << false << false; + QTest::newRow("FlagsDataEnum") << ::qMetaTypeId() << true << false << false << true << false; // invalid ids. - QTest::newRow("-1") << -1 << false << false << false << false; - QTest::newRow("-124125534") << -124125534 << false << false << false << false; - QTest::newRow("124125534") << 124125534 << false << false << false << false; + QTest::newRow("-1") << -1 << false << false << false << false << false; + QTest::newRow("-124125534") << -124125534 << false << false << false << false << false; + QTest::newRow("124125534") << 124125534 << false << false << false << false << false; } void tst_QMetaType::flags() @@ -1133,12 +1135,14 @@ void tst_QMetaType::flags() QFETCH(bool, isComplex); QFETCH(bool, isPointerToQObject); QFETCH(bool, isEnum); + QFETCH(bool, isQmlList); QCOMPARE(bool(QMetaType::typeFlags(type) & QMetaType::NeedsConstruction), isComplex); QCOMPARE(bool(QMetaType::typeFlags(type) & QMetaType::NeedsDestruction), isComplex); QCOMPARE(bool(QMetaType::typeFlags(type) & QMetaType::RelocatableType), isMovable); QCOMPARE(bool(QMetaType::typeFlags(type) & QMetaType::PointerToQObject), isPointerToQObject); QCOMPARE(bool(QMetaType::typeFlags(type) & QMetaType::IsEnumeration), isEnum); + QCOMPARE(bool(QMetaType::typeFlags(type) & QMetaType::IsQmlList), isQmlList); } void tst_QMetaType::flagsStaticLess_data() -- cgit v1.2.3