From 9e09677c1dd4da92735736a0fbcb703416bf4d6d Mon Sep 17 00:00:00 2001 From: David Skoland Date: Fri, 8 Jan 2021 12:57:47 +0100 Subject: Remove QtDBus includes Per the discussion of QTBUG-88831, we determined that module-wide imports are unfortunate, especially for compile times. Following this, all QtDBus includes have been replaced with the headers for the classes actually used in each file. Additionally, some cleanup of header file order and format has been performed in the changed files. Pick-to: 6.0 Change-Id: I62c1b75682a48422f0ba1168dd5d7bd0952808ac Reviewed-by: Qt CI Bot Reviewed-by: Volker Hilsheimer Reviewed-by: Edward Welbourne --- tests/auto/dbus/qdbusabstractadaptor/myobject.h | 7 +++++-- .../qdbusabstractadaptor/qmyserver/qmyserver.cpp | 9 +++++++-- .../tst_qdbusabstractadaptor.cpp | 11 +++++++---- tests/auto/dbus/qdbusabstractinterface/interface.h | 6 +++--- .../qdbusabstractinterface/qpinger/qpinger.cpp | 11 +++++++++-- .../tst_qdbusabstractinterface.cpp | 13 ++++++++----- .../dbus/qdbusconnection/tst_qdbusconnection.cpp | 12 +++++++----- .../dbus/qdbusconnection/tst_qdbusconnection.h | 5 ++++- .../tst_qdbusconnection_delayed.cpp | 3 ++- .../tst_qdbusconnection_no_bus.cpp | 6 +++--- .../tst_qdbusconnection_no_libdbus.cpp | 2 +- tests/auto/dbus/qdbuscontext/tst_qdbuscontext.cpp | 6 +++++- tests/auto/dbus/qdbusinterface/myobject.h | 7 ++++--- .../dbus/qdbusinterface/qmyserver/qmyserver.cpp | 5 +++-- .../dbus/qdbusinterface/tst_qdbusinterface.cpp | 22 +++++++++++++--------- .../dbus/qdbuslocalcalls/tst_qdbuslocalcalls.cpp | 14 ++++++++------ tests/auto/dbus/qdbusmarshall/common.h | 14 ++++++++++++-- tests/auto/dbus/qdbusmarshall/qpong/qpong.cpp | 6 ++++-- .../auto/dbus/qdbusmarshall/tst_qdbusmarshall.cpp | 2 -- .../dbus/qdbusmetaobject/tst_qdbusmetaobject.cpp | 10 +++++++--- .../auto/dbus/qdbusmetatype/tst_qdbusmetatype.cpp | 9 +++++---- .../dbus/qdbuspendingcall/tst_qdbuspendingcall.cpp | 15 ++++++++++----- .../qdbuspendingreply/tst_qdbuspendingreply.cpp | 13 +++++++++---- tests/auto/dbus/qdbusreply/tst_qdbusreply.cpp | 13 ++++++++----- .../tst_qdbusservicewatcher.cpp | 4 ++-- .../dbus/qdbusthreading/tst_qdbusthreading.cpp | 21 +++++++++++++-------- .../dbus/qdbusxmlparser/tst_qdbusxmlparser.cpp | 10 ++++------ 27 files changed, 163 insertions(+), 93 deletions(-) (limited to 'tests/auto/dbus') diff --git a/tests/auto/dbus/qdbusabstractadaptor/myobject.h b/tests/auto/dbus/qdbusabstractadaptor/myobject.h index a0c5d5c129..768e817043 100644 --- a/tests/auto/dbus/qdbusabstractadaptor/myobject.h +++ b/tests/auto/dbus/qdbusabstractadaptor/myobject.h @@ -29,8 +29,11 @@ #ifndef MYOBJECT_H #define MYOBJECT_H -#include -#include +#include +#include +#include +#include +#include extern const char *slotSpy; extern QString valueSpy; diff --git a/tests/auto/dbus/qdbusabstractadaptor/qmyserver/qmyserver.cpp b/tests/auto/dbus/qdbusabstractadaptor/qmyserver/qmyserver.cpp index 3e79fb77f4..a452d299b4 100644 --- a/tests/auto/dbus/qdbusabstractadaptor/qmyserver/qmyserver.cpp +++ b/tests/auto/dbus/qdbusabstractadaptor/qmyserver/qmyserver.cpp @@ -26,8 +26,13 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include + +#include +#include +#include +#include +#include +#include #include "../myobject.h" diff --git a/tests/auto/dbus/qdbusabstractadaptor/tst_qdbusabstractadaptor.cpp b/tests/auto/dbus/qdbusabstractadaptor/tst_qdbusabstractadaptor.cpp index fd74f45336..23fe3ff51a 100644 --- a/tests/auto/dbus/qdbusabstractadaptor/tst_qdbusabstractadaptor.cpp +++ b/tests/auto/dbus/qdbusabstractadaptor/tst_qdbusabstractadaptor.cpp @@ -26,12 +26,15 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include #include - -#include +#include +#include +#include +#include +#include +#include +#include #include "../qdbusmarshall/common.h" #include "myobject.h" diff --git a/tests/auto/dbus/qdbusabstractinterface/interface.h b/tests/auto/dbus/qdbusabstractinterface/interface.h index 209c7d359c..f9e6c0e028 100644 --- a/tests/auto/dbus/qdbusabstractinterface/interface.h +++ b/tests/auto/dbus/qdbusabstractinterface/interface.h @@ -29,9 +29,9 @@ #ifndef INTERFACE_H #define INTERFACE_H -#include -#include -#include +#include +#include +#include struct RegisteredType { diff --git a/tests/auto/dbus/qdbusabstractinterface/qpinger/qpinger.cpp b/tests/auto/dbus/qdbusabstractinterface/qpinger/qpinger.cpp index 7f098aeb36..2ff7d31332 100644 --- a/tests/auto/dbus/qdbusabstractinterface/qpinger/qpinger.cpp +++ b/tests/auto/dbus/qdbusabstractinterface/qpinger/qpinger.cpp @@ -26,8 +26,15 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include + +#include + +#include +#include +#include +#include +#include + #include "../interface.h" static const char serviceName[] = "org.qtproject.autotests.qpinger"; diff --git a/tests/auto/dbus/qdbusabstractinterface/tst_qdbusabstractinterface.cpp b/tests/auto/dbus/qdbusabstractinterface/tst_qdbusabstractinterface.cpp index 613baaab41..7cdf9dfe9c 100644 --- a/tests/auto/dbus/qdbusabstractinterface/tst_qdbusabstractinterface.cpp +++ b/tests/auto/dbus/qdbusabstractinterface/tst_qdbusabstractinterface.cpp @@ -26,15 +26,18 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include -#include #include #include +#include +#include +#include #include - -#include +#include +#include +#include +#include +#include #include "interface.h" #include "pinger_interface.h" diff --git a/tests/auto/dbus/qdbusconnection/tst_qdbusconnection.cpp b/tests/auto/dbus/qdbusconnection/tst_qdbusconnection.cpp index 314a23f987..cd6288ee34 100644 --- a/tests/auto/dbus/qdbusconnection/tst_qdbusconnection.cpp +++ b/tests/auto/dbus/qdbusconnection/tst_qdbusconnection.cpp @@ -29,12 +29,14 @@ #include "tst_qdbusconnection.h" -#include -#include - #include - -#include +#include +#include +#include +#include +#include +#include +#include #ifdef Q_OS_UNIX # include diff --git a/tests/auto/dbus/qdbusconnection/tst_qdbusconnection.h b/tests/auto/dbus/qdbusconnection/tst_qdbusconnection.h index d87d0e3773..a2e80149bc 100644 --- a/tests/auto/dbus/qdbusconnection/tst_qdbusconnection.h +++ b/tests/auto/dbus/qdbusconnection/tst_qdbusconnection.h @@ -31,9 +31,12 @@ #define TST_QDBUSCONNECTION_H #include -#include #include #include +#include +#include +#include +#include class BaseObject: public QObject { diff --git a/tests/auto/dbus/qdbusconnection_delayed/tst_qdbusconnection_delayed.cpp b/tests/auto/dbus/qdbusconnection_delayed/tst_qdbusconnection_delayed.cpp index a150451d34..b93ebbc4cd 100644 --- a/tests/auto/dbus/qdbusconnection_delayed/tst_qdbusconnection_delayed.cpp +++ b/tests/auto/dbus/qdbusconnection_delayed/tst_qdbusconnection_delayed.cpp @@ -26,9 +26,10 @@ ** ****************************************************************************/ -#include #include #include +#include +#include #ifdef Q_OS_WIN # include diff --git a/tests/auto/dbus/qdbusconnection_no_bus/tst_qdbusconnection_no_bus.cpp b/tests/auto/dbus/qdbusconnection_no_bus/tst_qdbusconnection_no_bus.cpp index 845360c93d..715b94d404 100644 --- a/tests/auto/dbus/qdbusconnection_no_bus/tst_qdbusconnection_no_bus.cpp +++ b/tests/auto/dbus/qdbusconnection_no_bus/tst_qdbusconnection_no_bus.cpp @@ -25,11 +25,11 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include #include -#include +#include +#include +#include #include diff --git a/tests/auto/dbus/qdbusconnection_no_libdbus/tst_qdbusconnection_no_libdbus.cpp b/tests/auto/dbus/qdbusconnection_no_libdbus/tst_qdbusconnection_no_libdbus.cpp index cf306a7eb4..946a9a2d97 100644 --- a/tests/auto/dbus/qdbusconnection_no_libdbus/tst_qdbusconnection_no_libdbus.cpp +++ b/tests/auto/dbus/qdbusconnection_no_libdbus/tst_qdbusconnection_no_libdbus.cpp @@ -29,7 +29,7 @@ #include #include -#include + #include diff --git a/tests/auto/dbus/qdbuscontext/tst_qdbuscontext.cpp b/tests/auto/dbus/qdbuscontext/tst_qdbuscontext.cpp index af1c64336d..87e2c8a1c1 100644 --- a/tests/auto/dbus/qdbuscontext/tst_qdbuscontext.cpp +++ b/tests/auto/dbus/qdbuscontext/tst_qdbuscontext.cpp @@ -25,8 +25,12 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include + #include +#include +#include +#include +#include const char errorName[] = "org.qtproject.tst_QDBusContext.Error"; const char errorMsg[] = "A generic error"; diff --git a/tests/auto/dbus/qdbusinterface/myobject.h b/tests/auto/dbus/qdbusinterface/myobject.h index 32da7348f2..e6f6d4a505 100644 --- a/tests/auto/dbus/qdbusinterface/myobject.h +++ b/tests/auto/dbus/qdbusinterface/myobject.h @@ -29,9 +29,10 @@ #ifndef MYOBJECT_H #define MYOBJECT_H -#include -#include - +#include +#include +#include +#include class MyObject: public QObject, protected QDBusContext { diff --git a/tests/auto/dbus/qdbusinterface/qmyserver/qmyserver.cpp b/tests/auto/dbus/qdbusinterface/qmyserver/qmyserver.cpp index 53eb9585f8..f7a935b1ba 100644 --- a/tests/auto/dbus/qdbusinterface/qmyserver/qmyserver.cpp +++ b/tests/auto/dbus/qdbusinterface/qmyserver/qmyserver.cpp @@ -26,8 +26,9 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include + +#include +#include #include "../myobject.h" diff --git a/tests/auto/dbus/qdbusinterface/tst_qdbusinterface.cpp b/tests/auto/dbus/qdbusinterface/tst_qdbusinterface.cpp index 8ed8762987..0d619e9c91 100644 --- a/tests/auto/dbus/qdbusinterface/tst_qdbusinterface.cpp +++ b/tests/auto/dbus/qdbusinterface/tst_qdbusinterface.cpp @@ -25,18 +25,22 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -/* -*- C++ -*- - */ -#include -#include #include +#include #include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include + #include "../qdbusmarshall/common.h" #include "myobject.h" diff --git a/tests/auto/dbus/qdbuslocalcalls/tst_qdbuslocalcalls.cpp b/tests/auto/dbus/qdbuslocalcalls/tst_qdbuslocalcalls.cpp index 705e1e065d..5caea5b14d 100644 --- a/tests/auto/dbus/qdbuslocalcalls/tst_qdbuslocalcalls.cpp +++ b/tests/auto/dbus/qdbuslocalcalls/tst_qdbuslocalcalls.cpp @@ -25,14 +25,16 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include -#include -#include + #include #include -#include - +#include +#include +#include +#include +#include +#include +#include class tst_QDBusLocalCalls: public QObject { diff --git a/tests/auto/dbus/qdbusmarshall/common.h b/tests/auto/dbus/qdbusmarshall/common.h index 3dfe3e39bb..9bdc1ebe66 100644 --- a/tests/auto/dbus/qdbusmarshall/common.h +++ b/tests/auto/dbus/qdbusmarshall/common.h @@ -25,8 +25,18 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include // qIsNan -#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #ifdef Q_OS_UNIX # include diff --git a/tests/auto/dbus/qdbusmarshall/qpong/qpong.cpp b/tests/auto/dbus/qdbusmarshall/qpong/qpong.cpp index cfcd51da7d..7333f5961d 100644 --- a/tests/auto/dbus/qdbusmarshall/qpong/qpong.cpp +++ b/tests/auto/dbus/qdbusmarshall/qpong/qpong.cpp @@ -25,8 +25,10 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include + +#include +#include +#include static const char serviceName[] = "org.qtproject.autotests.qpong"; static const char objectPath[] = "/org/qtproject/qpong"; diff --git a/tests/auto/dbus/qdbusmarshall/tst_qdbusmarshall.cpp b/tests/auto/dbus/qdbusmarshall/tst_qdbusmarshall.cpp index 9078ef02ab..c6928ca28d 100644 --- a/tests/auto/dbus/qdbusmarshall/tst_qdbusmarshall.cpp +++ b/tests/auto/dbus/qdbusmarshall/tst_qdbusmarshall.cpp @@ -30,8 +30,6 @@ #include #include -#include - #include "common.h" #include diff --git a/tests/auto/dbus/qdbusmetaobject/tst_qdbusmetaobject.cpp b/tests/auto/dbus/qdbusmetaobject/tst_qdbusmetaobject.cpp index 059b8cd483..3743a8ad07 100644 --- a/tests/auto/dbus/qdbusmetaobject/tst_qdbusmetaobject.cpp +++ b/tests/auto/dbus/qdbusmetaobject/tst_qdbusmetaobject.cpp @@ -25,11 +25,15 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include + #include +#include +#include +#include +#include +#include +#include -#include #include class tst_QDBusMetaObject: public QObject diff --git a/tests/auto/dbus/qdbusmetatype/tst_qdbusmetatype.cpp b/tests/auto/dbus/qdbusmetatype/tst_qdbusmetatype.cpp index 7bc6637a08..6735bdaf80 100644 --- a/tests/auto/dbus/qdbusmetatype/tst_qdbusmetatype.cpp +++ b/tests/auto/dbus/qdbusmetatype/tst_qdbusmetatype.cpp @@ -25,11 +25,12 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include -#include -#include +#include +#include +#include +#include +#include class tst_QDBusMetaType: public QObject { diff --git a/tests/auto/dbus/qdbuspendingcall/tst_qdbuspendingcall.cpp b/tests/auto/dbus/qdbuspendingcall/tst_qdbuspendingcall.cpp index 474f9b9119..0698c4591f 100644 --- a/tests/auto/dbus/qdbuspendingcall/tst_qdbuspendingcall.cpp +++ b/tests/auto/dbus/qdbuspendingcall/tst_qdbuspendingcall.cpp @@ -26,13 +26,18 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include -#include -#include + #include #include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #define TEST_INTERFACE_NAME "org.qtproject.QtDBus.MyObject" diff --git a/tests/auto/dbus/qdbuspendingreply/tst_qdbuspendingreply.cpp b/tests/auto/dbus/qdbuspendingreply/tst_qdbuspendingreply.cpp index 647749da8e..21563799d4 100644 --- a/tests/auto/dbus/qdbuspendingreply/tst_qdbuspendingreply.cpp +++ b/tests/auto/dbus/qdbuspendingreply/tst_qdbuspendingreply.cpp @@ -25,11 +25,16 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include -#include + #include -#include +#include +#include +#include +#include +#include +#include +#include +#include typedef QMap IntStringMap; Q_DECLARE_METATYPE(IntStringMap) diff --git a/tests/auto/dbus/qdbusreply/tst_qdbusreply.cpp b/tests/auto/dbus/qdbusreply/tst_qdbusreply.cpp index c68f0e4300..0d217dae69 100644 --- a/tests/auto/dbus/qdbusreply/tst_qdbusreply.cpp +++ b/tests/auto/dbus/qdbusreply/tst_qdbusreply.cpp @@ -25,13 +25,16 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -#include -#include -#include #include - -#include +#include +#include +#include +#include +#include +#include +#include +#include typedef QMap IntStringMap; Q_DECLARE_METATYPE(IntStringMap) diff --git a/tests/auto/dbus/qdbusservicewatcher/tst_qdbusservicewatcher.cpp b/tests/auto/dbus/qdbusservicewatcher/tst_qdbusservicewatcher.cpp index d1ebabdad3..d2c3a830ca 100644 --- a/tests/auto/dbus/qdbusservicewatcher/tst_qdbusservicewatcher.cpp +++ b/tests/auto/dbus/qdbusservicewatcher/tst_qdbusservicewatcher.cpp @@ -27,11 +27,11 @@ ** ****************************************************************************/ -#include -#include #include #include #include +#include +#include class tst_QDBusServiceWatcher: public QObject { diff --git a/tests/auto/dbus/qdbusthreading/tst_qdbusthreading.cpp b/tests/auto/dbus/qdbusthreading/tst_qdbusthreading.cpp index 9c12dc8235..3e1ec4242b 100644 --- a/tests/auto/dbus/qdbusthreading/tst_qdbusthreading.cpp +++ b/tests/auto/dbus/qdbusthreading/tst_qdbusthreading.cpp @@ -25,16 +25,21 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ + #include #include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include class Thread : public QThread { diff --git a/tests/auto/dbus/qdbusxmlparser/tst_qdbusxmlparser.cpp b/tests/auto/dbus/qdbusxmlparser/tst_qdbusxmlparser.cpp index 2867b64595..e935934fa1 100644 --- a/tests/auto/dbus/qdbusxmlparser/tst_qdbusxmlparser.cpp +++ b/tests/auto/dbus/qdbusxmlparser/tst_qdbusxmlparser.cpp @@ -25,13 +25,11 @@ ** $QT_END_LICENSE$ ** ****************************************************************************/ -/* -*- C++ -*- - */ -#include -#include + +#include +#include +#include #include -#include -#include #define USE_PRIVATE_CODE #include "../qdbusmarshall/common.h" -- cgit v1.2.3