From 73534e56ce727ea37a2dae70bc1ac88fd8ab22b9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A5rten=20Nordheim?= Date: Mon, 30 Nov 2020 16:38:07 +0100 Subject: Http2: Remove errored-out requests from queue The requests will remove themselves once they get deleted but since the deletion is done through a _queued_ invokeMethod to 'deleteLater' we will call QHttpNetworkConnection::_q_startNextRequest first which may end up starting a reconnect of the TCP socket which we had the error on. In this specific instance it manifested as a race condition where we either don't get a proxyAuthorizationRequired signal at all (it was emitted while we didn't have any valid replies), or we get the signal emitted too late and it gets emitted on whatever the next reply was. Task-number: QTBUG-88417 Change-Id: If3f8ececc5550f1868c90124559cb8e3029646d8 Reviewed-by: Timur Pocheptsov (cherry picked from commit 65bcac95a7a051d4343aaa3c5ff8b39494aa14e4) Reviewed-by: Qt Cherry-pick Bot --- tests/auto/network/access/qnetworkreply/BLACKLIST | 12 ------------ 1 file changed, 12 deletions(-) (limited to 'tests/auto/network/access/qnetworkreply/BLACKLIST') diff --git a/tests/auto/network/access/qnetworkreply/BLACKLIST b/tests/auto/network/access/qnetworkreply/BLACKLIST index 0da04b0a93..0b45914709 100644 --- a/tests/auto/network/access/qnetworkreply/BLACKLIST +++ b/tests/auto/network/access/qnetworkreply/BLACKLIST @@ -1,16 +1,4 @@ # See qtbase/src/testlib/qtestblacklist.cpp for format -[authenticationCacheAfterCancel] -windows-7sp1 -windows-10 msvc-2015 - -# QTBUG-88417 -[authenticationCacheAfterCancel:https+socksauth] -ubuntu-20.04 - -# QTBUG-88417 -[authenticationCacheAfterCancel:https+proxyauth] -ubuntu-20.04 - [backgroundRequestInterruption] opensuse-leap windows-10 msvc-2015 -- cgit v1.2.3