From 1ee75e47401d0ed4646d4fef7ce8e09eb90f4d5e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A5rten=20Nordheim?= Date: Tue, 16 Aug 2022 15:51:10 +0200 Subject: QSslServer: Make sure maxPendingConnections applies to all sockets Not just the ones we added to the pending sockets list Pick-to: 6.4 Change-Id: I0a0016fe39df7ca2fc3f0c4e4111195bc6d90198 Reviewed-by: Konrad Kujawa Reviewed-by: Timur Pocheptsov Reviewed-by: Edward Welbourne --- .../auto/network/ssl/qsslserver/tst_qsslserver.cpp | 29 ++++++++++++++++++++++ 1 file changed, 29 insertions(+) (limited to 'tests/auto/network/ssl') diff --git a/tests/auto/network/ssl/qsslserver/tst_qsslserver.cpp b/tests/auto/network/ssl/qsslserver/tst_qsslserver.cpp index 088f0170f4..b153d9545e 100644 --- a/tests/auto/network/ssl/qsslserver/tst_qsslserver.cpp +++ b/tests/auto/network/ssl/qsslserver/tst_qsslserver.cpp @@ -25,6 +25,7 @@ private slots: #endif void plaintextClient(); void quietClient(); + void manyQuietClients(); private: QString testDataDir; @@ -487,6 +488,34 @@ void tst_QSslServer::quietClient() QCOMPARE(serverPeerPort, clientLocalPort); } +void tst_QSslServer::manyQuietClients() +{ + QSslConfiguration serverConfiguration = selfSignedServerQSslConfiguration(); + SslServerSpy server(serverConfiguration); + constexpr qsizetype ExpectedConnections = 5; + server.server.setMaxPendingConnections(ExpectedConnections); + QVERIFY(server.server.listen()); + + // Connect one socket encrypted so we have a socket in the regular queue + QSslSocket tlsSocket; + QObject::connect(&tlsSocket, &QSslSocket::sslErrors, &tlsSocket, + qOverload &>(&QSslSocket::ignoreSslErrors)); + tlsSocket.connectToHostEncrypted("127.0.0.1", server.server.serverPort()); + + // Then we connect a bunch of TCP sockets who will not send any data at all + std::array sockets; + for (QTcpSocket &socket : sockets) + socket.connectToHost(QHostAddress::LocalHost, server.server.serverPort()); + QTest::qWait(500); // some leeway to let connections try to connect... + + // I happen to know the sockets are all children of the server, so let's see + // how many are created: + qsizetype connectedCount = server.server.findChildren().size(); + QCOMPARE(connectedCount, ExpectedConnections); + // 1 socket is ready and pending + QCOMPARE(server.pendingConnectionAvailableSpy.size(), 1); +} + QTEST_MAIN(tst_QSslServer) #include "tst_qsslserver.moc" -- cgit v1.2.3