From 9aba868571e7448ea79229a31d18bfd3e69813f8 Mon Sep 17 00:00:00 2001 From: Shawn Rutledge Date: Tue, 20 Oct 2020 22:39:18 +0200 Subject: QEvent copy constructor: copy the type flags too Failure to copy m_inputEvent and m_pointerEvent actually left them uninitialized, and resulted in random behavior in Qt Quick when Flickable clones a pointer event for later replay. Remove the comment about copying events being a "bad idea" in Qt 4, while we're at it. Copying became more common in Qt 5, and we probably won't be able to stop doing it now. Change-Id: I40b6ba5ad696e7aaafbeefbca86eca00cab40616 Reviewed-by: Thiago Macieira --- tests/auto/gui/kernel/qmouseevent/tst_qmouseevent.cpp | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'tests/auto') diff --git a/tests/auto/gui/kernel/qmouseevent/tst_qmouseevent.cpp b/tests/auto/gui/kernel/qmouseevent/tst_qmouseevent.cpp index c5bc7a9460..42a5f4d593 100644 --- a/tests/auto/gui/kernel/qmouseevent/tst_qmouseevent.cpp +++ b/tests/auto/gui/kernel/qmouseevent/tst_qmouseevent.cpp @@ -179,6 +179,15 @@ void tst_QMouseEvent::mouseEventBasic() me = QMouseEvent(QEvent::MouseButtonRelease, local, scene, screen, Qt::LeftButton, Qt::NoButton, Qt::NoModifier); QVERIFY(!me.isBeginEvent()); QVERIFY(me.isEndEvent()); + // Try out the copy constructor + QMouseEvent copy(me); + QVERIFY(copy.isInputEvent()); + QVERIFY(copy.isPointerEvent()); + QVERIFY(!copy.isBeginEvent()); + QVERIFY(copy.isEndEvent()); + QCOMPARE(copy.position(), local); + QCOMPARE(copy.scenePosition(), scene); + QCOMPARE(copy.globalPosition(), screen); } void tst_QMouseEvent::checkMousePressEvent_data() -- cgit v1.2.3