From b2c3b3e8fe0d8bdc88051d0120aaa8d5cf8acce0 Mon Sep 17 00:00:00 2001 From: Alex Trotsenko Date: Sat, 11 Sep 2021 17:32:09 +0300 Subject: Q{LocalSocket|Process}/Win: handle write errors MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To match the Unix behavior, we should emit errorOccurred() signal and close the channel if the write operation fails. Change-Id: Iac3acb18dbbfe6e7e8afb2555d9adaff1fe98d0f Reviewed-by: Oswald Buddenhagen Reviewed-by: MÃ¥rten Nordheim --- tests/auto/network/socket/qlocalsocket/tst_qlocalsocket.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'tests/auto') diff --git a/tests/auto/network/socket/qlocalsocket/tst_qlocalsocket.cpp b/tests/auto/network/socket/qlocalsocket/tst_qlocalsocket.cpp index 519a7bfacb..b2f426d01c 100644 --- a/tests/auto/network/socket/qlocalsocket/tst_qlocalsocket.cpp +++ b/tests/auto/network/socket/qlocalsocket/tst_qlocalsocket.cpp @@ -1531,6 +1531,7 @@ void tst_QLocalSocket::writeToDisconnected() QVERIFY(server.listen("writeToDisconnected")); QLocalSocket client; + QSignalSpy spyError(&client, SIGNAL(errorOccurred(QLocalSocket::LocalSocketError))); client.connectToServer("writeToDisconnected"); QVERIFY(client.waitForConnected(3000)); QVERIFY(server.waitForNewConnection(3000)); @@ -1548,6 +1549,7 @@ void tst_QLocalSocket::writeToDisconnected() QCOMPARE(client.bytesToWrite(), qint64(1)); QVERIFY(!client.waitForBytesWritten()); + QCOMPARE(spyError.count(), 1); QCOMPARE(client.state(), QLocalSocket::UnconnectedState); } -- cgit v1.2.3