From a03a71e332294aa500ac8475bb777c2f33609e8b Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Thu, 1 Mar 2012 10:09:02 +0100 Subject: examples: use QVector instead of QList QPointF is in the category of types for which QList is needlessly inefficient (elements are copy-constructed onto the heap and held through pointers). Use a vector instead. This is consistent with the QPainter API. Change-Id: Id0e910c067a60d12fbc175e7ee7da824834be374 Reviewed-by: hjk Reviewed-by: Lars Knoll --- .../benchmarks/gui/graphicsview/qgraphicsview/benchapps/chipTest/chip.h | 2 +- tests/benchmarks/gui/graphicsview/qgraphicsview/chiptester/chip.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'tests/benchmarks/gui/graphicsview') diff --git a/tests/benchmarks/gui/graphicsview/qgraphicsview/benchapps/chipTest/chip.h b/tests/benchmarks/gui/graphicsview/qgraphicsview/benchapps/chipTest/chip.h index b13f4a11e1..d2d859b402 100644 --- a/tests/benchmarks/gui/graphicsview/qgraphicsview/benchapps/chipTest/chip.h +++ b/tests/benchmarks/gui/graphicsview/qgraphicsview/benchapps/chipTest/chip.h @@ -62,7 +62,7 @@ protected: private: int x, y; QColor color; - QList stuff; + QVector stuff; }; #endif diff --git a/tests/benchmarks/gui/graphicsview/qgraphicsview/chiptester/chip.h b/tests/benchmarks/gui/graphicsview/qgraphicsview/chiptester/chip.h index ef3550e8d7..462109e599 100644 --- a/tests/benchmarks/gui/graphicsview/qgraphicsview/chiptester/chip.h +++ b/tests/benchmarks/gui/graphicsview/qgraphicsview/chiptester/chip.h @@ -62,7 +62,7 @@ protected: private: int x, y; QColor color; - QList stuff; + QVector stuff; }; #endif -- cgit v1.2.3 From 278ddc9d5e2f4e068ec1da94a1aeae4d97310dd2 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Thu, 1 Mar 2012 10:10:16 +0100 Subject: chiptester benchmark: compile The implementation uses QScrollBar, which is no longer included by . Change-Id: I2422cfccc427179ca71e9a3195f16bd637925fb3 Reviewed-by: Lars Knoll --- .../benchmarks/gui/graphicsview/qgraphicsview/chiptester/chiptester.cpp | 1 + 1 file changed, 1 insertion(+) (limited to 'tests/benchmarks/gui/graphicsview') diff --git a/tests/benchmarks/gui/graphicsview/qgraphicsview/chiptester/chiptester.cpp b/tests/benchmarks/gui/graphicsview/qgraphicsview/chiptester/chiptester.cpp index cae21fcfac..f8d766d82a 100644 --- a/tests/benchmarks/gui/graphicsview/qgraphicsview/chiptester/chiptester.cpp +++ b/tests/benchmarks/gui/graphicsview/qgraphicsview/chiptester/chiptester.cpp @@ -43,6 +43,7 @@ #include "chip.h" #include +#include #ifndef QT_NO_OPENGL #include #endif -- cgit v1.2.3