From 21a58910b2720748262433dd0c50bc043202755c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C4=99drzej=20Nowacki?= <jedrzej.nowacki@digia.com>
Date: Wed, 9 Jul 2014 18:00:07 +0200
Subject: Remove useless QMetaType benchmarks

Cost of a type lookup for core built-in types is really small, just few
cpu instructions, but the benchmark was testing create() and destroy()
functions (in a different fashion) which by definition allocate and
de-allocate memory. These memory operations are significantly more
expensive which obfuscate the results.

Change-Id: I33c679f57e6c2b57e98328f076dfe249ab7bcde8
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: Stephen Kelly <steveire@gmail.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
---
 .../gui/kernel/qguimetatype/tst_qguimetatype.cpp   | 60 ++--------------------
 1 file changed, 5 insertions(+), 55 deletions(-)

(limited to 'tests/benchmarks/gui')

diff --git a/tests/benchmarks/gui/kernel/qguimetatype/tst_qguimetatype.cpp b/tests/benchmarks/gui/kernel/qguimetatype/tst_qguimetatype.cpp
index 8f987470f5..ec587707c3 100644
--- a/tests/benchmarks/gui/kernel/qguimetatype/tst_qguimetatype.cpp
+++ b/tests/benchmarks/gui/kernel/qguimetatype/tst_qguimetatype.cpp
@@ -46,77 +46,27 @@ class tst_QGuiMetaType : public QObject
 {
     Q_OBJECT
 
-public:
-    tst_QGuiMetaType();
-    virtual ~tst_QGuiMetaType();
-
 private slots:
-    void constructGuiType_data();
-    void constructGuiType();
-    void constructGuiTypeCopy_data();
-    void constructGuiTypeCopy();
-
     void constructInPlace_data();
     void constructInPlace();
     void constructInPlaceCopy_data();
     void constructInPlaceCopy();
+private:
+    void constructableGuiTypes();
 };
 
-tst_QGuiMetaType::tst_QGuiMetaType()
-{
-}
-
-tst_QGuiMetaType::~tst_QGuiMetaType()
-{
-}
 
-void tst_QGuiMetaType::constructGuiType_data()
+void tst_QGuiMetaType::constructableGuiTypes()
 {
     QTest::addColumn<int>("typeId");
     for (int i = QMetaType::FirstGuiType; i <= QMetaType::LastGuiType; ++i)
         QTest::newRow(QMetaType::typeName(i)) << i;
 }
 
-// Tests how fast QMetaType can default-construct and destroy a Qt GUI
-// type. The purpose of this benchmark is to measure the overhead of
-// using type id-based creation compared to creating the type directly
-// (i.e. "T *t = new T(); delete t;").
-void tst_QGuiMetaType::constructGuiType()
-{
-    QFETCH(int, typeId);
-    QBENCHMARK {
-        for (int i = 0; i < 100000; ++i) {
-            void *data = QMetaType::create(typeId, (void *)0);
-            QMetaType::destroy(typeId, data);
-        }
-    }
-}
-
-void tst_QGuiMetaType::constructGuiTypeCopy_data()
-{
-    constructGuiType_data();
-}
-
-// Tests how fast QMetaType can copy-construct and destroy a Qt GUI
-// type. The purpose of this benchmark is to measure the overhead of
-// using type id-based creation compared to creating the type directly
-// (i.e. "T *t = new T(other); delete t;").
-void tst_QGuiMetaType::constructGuiTypeCopy()
-{
-    QFETCH(int, typeId);
-    QVariant other(typeId, (void *)0);
-    const void *copy = other.constData();
-    QBENCHMARK {
-        for (int i = 0; i < 100000; ++i) {
-            void *data = QMetaType::create(typeId, copy);
-            QMetaType::destroy(typeId, data);
-        }
-    }
-}
 
 void tst_QGuiMetaType::constructInPlace_data()
 {
-    constructGuiType_data();
+    constructableGuiTypes();
 }
 
 void tst_QGuiMetaType::constructInPlace()
@@ -137,7 +87,7 @@ void tst_QGuiMetaType::constructInPlace()
 
 void tst_QGuiMetaType::constructInPlaceCopy_data()
 {
-    constructGuiType_data();
+    constructableGuiTypes();
 }
 
 void tst_QGuiMetaType::constructInPlaceCopy()
-- 
cgit v1.2.3