From 586adeabe4d58a7c8a71bbb1be79c3533ab858ff Mon Sep 17 00:00:00 2001 From: Oswald Buddenhagen Date: Fri, 21 Dec 2012 12:09:56 +0100 Subject: add and use qtHaveModule() function this is much more elegant than the so far propagated !isEmpty(QT.foo.name). also replace feature-specific tests (no-gui and no-widgets) and the obsolete contains(QT_CONFIG, foo) syntax. Change-Id: Ia4b3c8febcabf9eeca67b1f9173a523820b1038b Reviewed-by: Sergio Ahumada Reviewed-by: Tasuku Suzuki Reviewed-by: Oswald Buddenhagen --- tests/benchmarks/benchmarks.pro | 4 ++-- tests/benchmarks/corelib/kernel/kernel.pro | 2 +- tests/benchmarks/corelib/tools/qregexp/qregexp.pro | 2 +- tests/benchmarks/gui/animation/animation.pro | 2 +- .../functional/GraphicsViewBenchmark/GraphicsViewBenchmark.pro | 2 +- tests/benchmarks/gui/graphicsview/graphicsview.pro | 2 +- .../gui/graphicsview/qgraphicsview/benchapps/chipTest/chip.pro | 2 +- .../gui/graphicsview/qgraphicsview/chiptester/chiptester.pri | 2 +- tests/benchmarks/gui/gui.pro | 2 +- tests/benchmarks/gui/image/image.pro | 2 +- tests/benchmarks/gui/kernel/kernel.pro | 2 +- tests/benchmarks/gui/painting/painting.pro | 2 +- tests/benchmarks/gui/styles/styles.pro | 2 +- 13 files changed, 14 insertions(+), 14 deletions(-) (limited to 'tests/benchmarks') diff --git a/tests/benchmarks/benchmarks.pro b/tests/benchmarks/benchmarks.pro index e685c3d7b2..5fd8ff6368 100644 --- a/tests/benchmarks/benchmarks.pro +++ b/tests/benchmarks/benchmarks.pro @@ -5,8 +5,8 @@ SUBDIRS = \ network \ sql \ -# removed-by-refactor contains(QT_CONFIG, opengl): SUBDIRS += opengl -contains(QT_CONFIG, dbus): SUBDIRS += dbus +# removed-by-refactor qtHaveModule(opengl): SUBDIRS += opengl +qtHaveModule(dbus): SUBDIRS += dbus check-trusted.CONFIG += recursive QMAKE_EXTRA_TARGETS += check-trusted diff --git a/tests/benchmarks/corelib/kernel/kernel.pro b/tests/benchmarks/corelib/kernel/kernel.pro index a55135b74d..02eeeaa254 100644 --- a/tests/benchmarks/corelib/kernel/kernel.pro +++ b/tests/benchmarks/corelib/kernel/kernel.pro @@ -7,6 +7,6 @@ SUBDIRS = \ qvariant \ qcoreapplication -isEmpty(QT.widgets.name): SUBDIRS -= \ +!qtHaveModule(widgets): SUBDIRS -= \ qmetaobject \ qobject diff --git a/tests/benchmarks/corelib/tools/qregexp/qregexp.pro b/tests/benchmarks/corelib/tools/qregexp/qregexp.pro index ef50a22d4d..74544519f3 100644 --- a/tests/benchmarks/corelib/tools/qregexp/qregexp.pro +++ b/tests/benchmarks/corelib/tools/qregexp/qregexp.pro @@ -6,7 +6,7 @@ CONFIG += release exceptions SOURCES += main.cpp RESOURCES += qregexp.qrc -!isEmpty(QT.script.name):!pcre { +qtHaveModule(script):!pcre { DEFINES += HAVE_JSC QT += script } diff --git a/tests/benchmarks/gui/animation/animation.pro b/tests/benchmarks/gui/animation/animation.pro index 1c9a7c3c08..76c1a49e5c 100644 --- a/tests/benchmarks/gui/animation/animation.pro +++ b/tests/benchmarks/gui/animation/animation.pro @@ -1,2 +1,2 @@ TEMPLATE = subdirs -!isEmpty(QT.widgets.name):SUBDIRS = qanimation +qtHaveModule(widgets): SUBDIRS = qanimation diff --git a/tests/benchmarks/gui/graphicsview/functional/GraphicsViewBenchmark/GraphicsViewBenchmark.pro b/tests/benchmarks/gui/graphicsview/functional/GraphicsViewBenchmark/GraphicsViewBenchmark.pro index b0bc021b0a..a6ed4b84fb 100644 --- a/tests/benchmarks/gui/graphicsview/functional/GraphicsViewBenchmark/GraphicsViewBenchmark.pro +++ b/tests/benchmarks/gui/graphicsview/functional/GraphicsViewBenchmark/GraphicsViewBenchmark.pro @@ -1,7 +1,7 @@ TEMPLATE = app QT += svg testlib -contains(QT_CONFIG, opengl):QT += opengl +qtHaveModule(opengl): QT += opengl HEADERS += widgets/gvbwidget.h \ widgets/abstractscrollarea.h \ diff --git a/tests/benchmarks/gui/graphicsview/graphicsview.pro b/tests/benchmarks/gui/graphicsview/graphicsview.pro index f8ba062829..d89a00c4b9 100644 --- a/tests/benchmarks/gui/graphicsview/graphicsview.pro +++ b/tests/benchmarks/gui/graphicsview/graphicsview.pro @@ -8,7 +8,7 @@ SUBDIRS = \ qgraphicsview \ qgraphicswidget -isEmpty(QT.widgets.name): SUBDIRS -= \ +!qtHaveModule(widgets): SUBDIRS -= \ qgraphicsanchorlayout \ qgraphicsitem \ qgraphicsscene \ diff --git a/tests/benchmarks/gui/graphicsview/qgraphicsview/benchapps/chipTest/chip.pro b/tests/benchmarks/gui/graphicsview/qgraphicsview/benchapps/chipTest/chip.pro index 759216d46d..4047bad1ca 100644 --- a/tests/benchmarks/gui/graphicsview/qgraphicsview/benchapps/chipTest/chip.pro +++ b/tests/benchmarks/gui/graphicsview/qgraphicsview/benchapps/chipTest/chip.pro @@ -4,7 +4,7 @@ HEADERS += mainwindow.h view.h chip.h SOURCES += main.cpp SOURCES += mainwindow.cpp view.cpp chip.cpp -contains(QT_CONFIG, opengl):QT += opengl +qtHaveModule(opengl): QT += opengl build_all:!build_pass { CONFIG -= build_all diff --git a/tests/benchmarks/gui/graphicsview/qgraphicsview/chiptester/chiptester.pri b/tests/benchmarks/gui/graphicsview/qgraphicsview/chiptester/chiptester.pri index 8d02504b73..105117de30 100644 --- a/tests/benchmarks/gui/graphicsview/qgraphicsview/chiptester/chiptester.pri +++ b/tests/benchmarks/gui/graphicsview/qgraphicsview/chiptester/chiptester.pri @@ -10,4 +10,4 @@ RESOURCES += \ chiptester/images.qrc QT += widgets -contains(QT_CONFIG, opengl) QT += opengl +qtHaveModule(opengl): QT += opengl diff --git a/tests/benchmarks/gui/gui.pro b/tests/benchmarks/gui/gui.pro index f4b84f0428..e943347938 100644 --- a/tests/benchmarks/gui/gui.pro +++ b/tests/benchmarks/gui/gui.pro @@ -17,5 +17,5 @@ TRUSTED_BENCHMARKS += \ include(../trusted-benchmarks.pri) -isEmpty(QT.widgets.name): SUBDIRS -= \ +!qtHaveModule(widgets): SUBDIRS -= \ itemviews diff --git a/tests/benchmarks/gui/image/image.pro b/tests/benchmarks/gui/image/image.pro index fa26f3ec4c..2d5db35a73 100644 --- a/tests/benchmarks/gui/image/image.pro +++ b/tests/benchmarks/gui/image/image.pro @@ -6,5 +6,5 @@ SUBDIRS = \ qpixmap \ qpixmapcache -isEmpty(QT.widgets.name): SUBDIRS -= \ +!qtHaveModule(widgets): SUBDIRS -= \ qimagereader diff --git a/tests/benchmarks/gui/kernel/kernel.pro b/tests/benchmarks/gui/kernel/kernel.pro index 303eff9759..cd7235cff8 100644 --- a/tests/benchmarks/gui/kernel/kernel.pro +++ b/tests/benchmarks/gui/kernel/kernel.pro @@ -1,4 +1,4 @@ TEMPLATE = subdirs -!isEmpty(QT.widgets.name):SUBDIRS = \ +qtHaveModule(widgets): SUBDIRS = \ qapplication \ qwidget diff --git a/tests/benchmarks/gui/painting/painting.pro b/tests/benchmarks/gui/painting/painting.pro index e55222a2c2..b3fb34757c 100644 --- a/tests/benchmarks/gui/painting/painting.pro +++ b/tests/benchmarks/gui/painting/painting.pro @@ -6,7 +6,7 @@ SUBDIRS = \ qtracebench \ qtbench -isEmpty(QT.widgets.name): SUBDIRS -= \ +!qtHaveModule(widgets): SUBDIRS -= \ qpainter \ qtracebench \ qtbench diff --git a/tests/benchmarks/gui/styles/styles.pro b/tests/benchmarks/gui/styles/styles.pro index 8930de127b..2c1d10b48c 100644 --- a/tests/benchmarks/gui/styles/styles.pro +++ b/tests/benchmarks/gui/styles/styles.pro @@ -1,3 +1,3 @@ TEMPLATE = subdirs -!isEmpty(QT.widgets.name):SUBDIRS = \ +qtHaveModule(widgets): SUBDIRS = \ qstylesheetstyle -- cgit v1.2.3