From a2a00eb044596f3e3f628b6b20b38a5ba524915c Mon Sep 17 00:00:00 2001 From: Friedemann Kleint Date: Tue, 13 Oct 2015 09:46:56 +0200 Subject: Tests: Fix single-character string literals. Use character literals where applicable. Change-Id: I1a026c320079ee5ca6f70be835d5a541deee2dd1 Reviewed-by: Simon Hausmann --- tests/benchmarks/corelib/codecs/qtextcodec/main.cpp | 6 +++--- tests/benchmarks/corelib/io/qfile/main.cpp | 8 ++++---- .../functional/GraphicsViewBenchmark/widgets/commandline.cpp | 2 +- .../functional/GraphicsViewBenchmark/widgets/dummydatagen.cpp | 3 ++- tests/benchmarks/gui/itemviews/qheaderview/qheaderviewbench.cpp | 2 +- tests/benchmarks/sql/kernel/qsqlquery/main.cpp | 2 +- 6 files changed, 12 insertions(+), 11 deletions(-) (limited to 'tests/benchmarks') diff --git a/tests/benchmarks/corelib/codecs/qtextcodec/main.cpp b/tests/benchmarks/corelib/codecs/qtextcodec/main.cpp index aa42c11fc7..ef6e41f4f3 100644 --- a/tests/benchmarks/corelib/codecs/qtextcodec/main.cpp +++ b/tests/benchmarks/corelib/codecs/qtextcodec/main.cpp @@ -56,11 +56,11 @@ void tst_QTextCodec::codecForName() const QBENCHMARK { foreach(const QByteArray& c, codecs) { QVERIFY(QTextCodec::codecForName(c)); - QVERIFY(QTextCodec::codecForName(c + "-")); + QVERIFY(QTextCodec::codecForName(c + '-')); } foreach(const QByteArray& c, codecs) { - QVERIFY(QTextCodec::codecForName(c + "+")); - QVERIFY(QTextCodec::codecForName(c + "*")); + QVERIFY(QTextCodec::codecForName(c + '+')); + QVERIFY(QTextCodec::codecForName(c + '*')); } } } diff --git a/tests/benchmarks/corelib/io/qfile/main.cpp b/tests/benchmarks/corelib/io/qfile/main.cpp index 8e836ebdff..13e1cb9e2f 100644 --- a/tests/benchmarks/corelib/io/qfile/main.cpp +++ b/tests/benchmarks/corelib/io/qfile/main.cpp @@ -602,7 +602,7 @@ void tst_qfile::createSmallFiles() for (int i = 0; i < 1000; ++i) #endif { - QFile f(tmpDirName+"/"+QString::number(i)); + QFile f(tmpDirName + QLatin1Char('/') + QString::number(i)); f.open(QIODevice::WriteOnly); f.seek(511); f.putChar('\n'); @@ -641,7 +641,7 @@ void tst_qfile::readSmallFiles() case(QFileBenchmark): { QList fileList; Q_FOREACH(QString file, files) { - QFile *f = new QFile(tmpDirName+ "/" + file); + QFile *f = new QFile(tmpDirName + QLatin1Char('/') + file); f->open(QIODevice::ReadOnly|textMode|bufferedMode); fileList.append(f); } @@ -664,7 +664,7 @@ void tst_qfile::readSmallFiles() case(QFSFileEngineBenchmark): { QList fileList; Q_FOREACH(QString file, files) { - QFSFileEngine *fse = new QFSFileEngine(tmpDirName+ "/" + file); + QFSFileEngine *fse = new QFSFileEngine(tmpDirName + QLatin1Char('/') + file); fse->open(QIODevice::ReadOnly|textMode|bufferedMode); fileList.append(fse); } @@ -685,7 +685,7 @@ void tst_qfile::readSmallFiles() case(PosixBenchmark): { QList fileList; Q_FOREACH(QString file, files) { - fileList.append(::fopen(QFile::encodeName(tmpDirName+ "/" + file).constData(), "rb")); + fileList.append(::fopen(QFile::encodeName(tmpDirName + QLatin1Char('/') + file).constData(), "rb")); } QBENCHMARK { diff --git a/tests/benchmarks/gui/graphicsview/functional/GraphicsViewBenchmark/widgets/commandline.cpp b/tests/benchmarks/gui/graphicsview/functional/GraphicsViewBenchmark/widgets/commandline.cpp index 7e82b1ca53..7c4dc97591 100644 --- a/tests/benchmarks/gui/graphicsview/functional/GraphicsViewBenchmark/widgets/commandline.cpp +++ b/tests/benchmarks/gui/graphicsview/functional/GraphicsViewBenchmark/widgets/commandline.cpp @@ -100,7 +100,7 @@ bool readSettingsFromCommandLine(int argc, char *argv[], return false; } else { - QStringList res = QString(argv[i+1]).split("x"); + QStringList res = QString(argv[i+1]).split(QLatin1Char('x')); if (res.count() != 2) { printf("-resolution parameter UI resolution should be set in format WxH where width and height are positive values\n"); usage(argv[0]); diff --git a/tests/benchmarks/gui/graphicsview/functional/GraphicsViewBenchmark/widgets/dummydatagen.cpp b/tests/benchmarks/gui/graphicsview/functional/GraphicsViewBenchmark/widgets/dummydatagen.cpp index 4dbb24211c..64c91da5f2 100644 --- a/tests/benchmarks/gui/graphicsview/functional/GraphicsViewBenchmark/widgets/dummydatagen.cpp +++ b/tests/benchmarks/gui/graphicsview/functional/GraphicsViewBenchmark/widgets/dummydatagen.cpp @@ -81,7 +81,8 @@ QString DummyDataGenerator::randomPhoneNumber(QString indexNumber) QString beginNumber = QString::number(555-index*2); QString endNumber = QString("0").repeated(4-indexNumber.length()) + indexNumber; - return countryCode +" " + areaCode +" " + beginNumber +" " + endNumber; + return countryCode + QLatin1Char(' ') + areaCode +QLatin1Char(' ') + beginNumber + + QLatin1Char(' ') + endNumber; } QString DummyDataGenerator::randomFirstName() diff --git a/tests/benchmarks/gui/itemviews/qheaderview/qheaderviewbench.cpp b/tests/benchmarks/gui/itemviews/qheaderview/qheaderviewbench.cpp index 9cc8f1e6bb..5b75d1ecd6 100644 --- a/tests/benchmarks/gui/itemviews/qheaderview/qheaderviewbench.cpp +++ b/tests/benchmarks/gui/itemviews/qheaderview/qheaderviewbench.cpp @@ -130,7 +130,7 @@ void BenchQHeaderView::init() for (int i = 0; i < m_model->rowCount(); ++i) { m_model->setData(m_model->index(i, 0), QVariant(i)); s.setNum(i); - s += "."; + s += QLatin1Char('.'); s += 'a' + (i % 25); m_model->setData(m_model->index(i, 1), QVariant(s)); } diff --git a/tests/benchmarks/sql/kernel/qsqlquery/main.cpp b/tests/benchmarks/sql/kernel/qsqlquery/main.cpp index b5937b76b0..942266313f 100644 --- a/tests/benchmarks/sql/kernel/qsqlquery/main.cpp +++ b/tests/benchmarks/sql/kernel/qsqlquery/main.cpp @@ -285,7 +285,7 @@ void tst_QSqlQuery::benchmarkSelectPrepared() int expectedSum = 0; QString fillQuery = "INSERT INTO " + tableName + " VALUES (0)"; for (int i = 1; i < NUM_ROWS; ++i) { - fillQuery += ", (" + QString::number(i) + ")"; + fillQuery += ", (" + QString::number(i) + QLatin1Char(')'); expectedSum += i; } QVERIFY_SQL(q, exec(fillQuery)); -- cgit v1.2.3