From a4fb128b733667dcc8269efbb1b0227f09e3a64c Mon Sep 17 00:00:00 2001
From: Fabian Kosmale <fabian.kosmale@qt.io>
Date: Thu, 2 Jan 2020 13:27:10 +0100
Subject: QSequentialIterableImpl: support append

Task-number: QTBUG-80916
Change-Id: I87e74da0ce454e56b5fe94d9db3693a587d35edf
Reviewed-by: Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
---
 .../auto/corelib/kernel/qvariant/tst_qvariant.cpp  | 24 ++++++++++++++++++++++
 1 file changed, 24 insertions(+)

(limited to 'tests')

diff --git a/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp b/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp
index 45eb61f6e4..5af1353a0f 100644
--- a/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp
+++ b/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp
@@ -281,6 +281,8 @@ private slots:
     void shouldDeleteVariantDataWorksForAssociative();
     void fromStdVariant();
     void qt4UuidDataStream();
+    void sequentialIterableEndianessSanityCheck();
+    void sequentialIterableAppend();
 
     void preferDirectConversionOverInterfaces();
 
@@ -5142,6 +5144,28 @@ void tst_QVariant::qt4UuidDataStream()
     QCOMPARE(result.value<QUuid>(), source);
 }
 
+void tst_QVariant::sequentialIterableEndianessSanityCheck()
+{
+    namespace QMTP = QtMetaTypePrivate;
+    uint oldIteratorCaps = QMTP::ForwardCapability | QMTP::BiDirectionalCapability | QMTP::RandomAccessCapability;
+    QMTP::QSequentialIterableImpl seqImpl {};
+    QCOMPARE(seqImpl.revision(), 1u);
+    memcpy(&seqImpl._iteratorCapabilities, &oldIteratorCaps, sizeof(oldIteratorCaps));
+    QCOMPARE(seqImpl.revision(), 0u);
+}
+
+void tst_QVariant::sequentialIterableAppend()
+{
+    QVector<int> container {1, 2};
+    auto variant = QVariant::fromValue(container);
+    QVERIFY(variant.canConvert<QtMetaTypePrivate::QSequentialIterableImpl>());
+    auto asIterable = variant.value<QtMetaTypePrivate::QSequentialIterableImpl>();
+    const int i = 3, j = 4;
+    asIterable.append(&i);
+    asIterable.append(&j);
+    QCOMPARE(variant.value<QVector<int>>(), QVector<int> ({1, 2, 3, 4}));
+}
+
 void tst_QVariant::preferDirectConversionOverInterfaces()
 {
     using namespace QtMetaTypePrivate;
-- 
cgit v1.2.3