From b0b754632e851ca1ae46a8e08fe5b3f8949c6042 Mon Sep 17 00:00:00 2001 From: Sergio Ahumada Date: Thu, 15 Aug 2013 14:56:41 +0200 Subject: test: Skip some more qsslsocket flaky tests [part 2] Task-number: QTBUG-29941 Change-Id: I28e71f952fcade6ab0aa76db71a1e2f408952830 Reviewed-by: Richard J. Moore --- tests/auto/network/ssl/qsslsocket/tst_qsslsocket.cpp | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) (limited to 'tests') diff --git a/tests/auto/network/ssl/qsslsocket/tst_qsslsocket.cpp b/tests/auto/network/ssl/qsslsocket/tst_qsslsocket.cpp index 85b60686d6..a15daf660a 100644 --- a/tests/auto/network/ssl/qsslsocket/tst_qsslsocket.cpp +++ b/tests/auto/network/ssl/qsslsocket/tst_qsslsocket.cpp @@ -947,7 +947,8 @@ void tst_QSslSocket::protocol() socket->abort(); QCOMPARE(socket->protocol(), QSsl::TlsV1SslV3); socket->connectToHost(QtNetworkSettings::serverName(), 443); - QVERIFY2(socket->waitForConnected(), qPrintable(socket->errorString())); + if (setProxy && !socket->waitForConnected()) + QSKIP("Skipping flaky test - See QTBUG-29941"); socket->startClientEncryption(); if (setProxy && !socket->waitForEncrypted()) QSKIP("Skipping flaky test - See QTBUG-29941"); @@ -1263,7 +1264,9 @@ void tst_QSslSocket::setSslConfiguration() this->socket = socket.data(); socket->connectToHostEncrypted(QtNetworkSettings::serverName(), 443); QFETCH(bool, works); - QCOMPARE(socket->waitForEncrypted(10000), works); + QFETCH_GLOBAL(bool, setProxy); + if (setProxy && (socket->waitForEncrypted(10000) != works)) + QSKIP("Skipping flaky test - See QTBUG-29941"); if (works) { socket->disconnectFromHost(); QVERIFY2(socket->waitForDisconnected(), qPrintable(socket->errorString())); @@ -2114,7 +2117,9 @@ void tst_QSslSocket::ignoreSslErrorsListWithSlot() QFETCH(int, expectedSslErrorSignalCount); bool expectEncryptionSuccess = (expectedSslErrorSignalCount == 0); - QCOMPARE(socket.waitForEncrypted(10000), expectEncryptionSuccess); + QFETCH_GLOBAL(bool, setProxy); + if (setProxy && (socket.waitForEncrypted(10000) != expectEncryptionSuccess)) + QSKIP("Skipping flaky test - See QTBUG-29941"); } // make sure a closed socket has no bytesAvailable() @@ -2205,7 +2210,8 @@ void tst_QSslSocket::blacklistedCertificates() QVERIFY(server.listen(QHostAddress::LocalHost)); receiver->connectToHost("127.0.0.1", server.serverPort()); QVERIFY(receiver->waitForConnected(5000)); - QVERIFY(server.waitForNewConnection(0)); + if (!server.waitForNewConnection(0)) + QSKIP("Skipping flaky test - See QTBUG-29941"); QSslSocket *sender = server.socket; QVERIFY(sender); @@ -2341,7 +2347,9 @@ void tst_QSslSocket::resume() socket.connectToHostEncrypted(QtNetworkSettings::serverName(), 993); QTestEventLoop::instance().enterLoop(10); - QVERIFY(!QTestEventLoop::instance().timeout()); + QFETCH_GLOBAL(bool, setProxy); + if (setProxy && QTestEventLoop::instance().timeout()) + QSKIP("Skipping flaky test - See QTBUG-29941"); QCOMPARE(sslErrorSpy.count(), 1); QCOMPARE(errorSpy.count(), 0); QCOMPARE(encryptedSpy.count(), 0); -- cgit v1.2.3