// // Copyright (c) 2013-2014 The ANGLE Project Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. // // validationES.h: Validation functions for generic OpenGL ES entry point parameters #include "libANGLE/validationES.h" #include "libANGLE/Context.h" #include "libANGLE/Display.h" #include "libANGLE/ErrorStrings.h" #include "libANGLE/Framebuffer.h" #include "libANGLE/FramebufferAttachment.h" #include "libANGLE/Image.h" #include "libANGLE/Program.h" #include "libANGLE/Query.h" #include "libANGLE/Texture.h" #include "libANGLE/TransformFeedback.h" #include "libANGLE/VertexArray.h" #include "libANGLE/formatutils.h" #include "libANGLE/queryconversions.h" #include "libANGLE/validationES2.h" #include "libANGLE/validationES3.h" #include "common/mathutil.h" #include "common/utilities.h" using namespace angle; namespace gl { namespace { bool ValidateDrawAttribs(ValidationContext *context, GLint primcount, GLint maxVertex, GLint vertexCount) { const gl::State &state = context->getGLState(); const gl::Program *program = state.getProgram(); bool webglCompatibility = context->getExtensions().webglCompatibility; const VertexArray *vao = state.getVertexArray(); const auto &vertexAttribs = vao->getVertexAttributes(); const auto &vertexBindings = vao->getVertexBindings(); size_t maxEnabledAttrib = vao->getMaxEnabledAttribute(); for (size_t attributeIndex = 0; attributeIndex < maxEnabledAttrib; ++attributeIndex) { const VertexAttribute &attrib = vertexAttribs[attributeIndex]; // No need to range check for disabled attribs. if (!attrib.enabled) { continue; } // If we have no buffer, then we either get an error, or there are no more checks to be // done. const VertexBinding &binding = vertexBindings[attrib.bindingIndex]; gl::Buffer *buffer = binding.getBuffer().get(); if (!buffer) { if (webglCompatibility || !state.areClientArraysEnabled()) { // [WebGL 1.0] Section 6.5 Enabled Vertex Attributes and Range Checking // If a vertex attribute is enabled as an array via enableVertexAttribArray but // no buffer is bound to that attribute via bindBuffer and vertexAttribPointer, // then calls to drawArrays or drawElements will generate an INVALID_OPERATION // error. ANGLE_VALIDATION_ERR(context, InvalidOperation(), VertexArrayNoBuffer); return false; } else if (attrib.pointer == nullptr) { // This is an application error that would normally result in a crash, // but we catch it and return an error ANGLE_VALIDATION_ERR(context, InvalidOperation(), VertexArrayNoBufferPointer); return false; } continue; } // This needs to come after the check for client arrays as even unused attributes cannot use // client-side arrays if (!program->isAttribLocationActive(attributeIndex)) { continue; } // If we're drawing zero vertices, we have enough data. if (vertexCount <= 0 || primcount <= 0) { continue; } GLint maxVertexElement = 0; GLuint divisor = binding.getDivisor(); if (divisor == 0) { maxVertexElement = maxVertex; } else { maxVertexElement = (primcount - 1) / divisor; } // We do manual overflow checks here instead of using safe_math.h because it was // a bottleneck. Thanks to some properties of GL we know inequalities that can // help us make the overflow checks faster. // The max possible attribSize is 16 for a vector of 4 32 bit values. constexpr uint64_t kMaxAttribSize = 16; constexpr uint64_t kIntMax = std::numeric_limits::max(); constexpr uint64_t kUint64Max = std::numeric_limits::max(); // We know attribStride is given as a GLsizei which is typedefed to int. // We also know an upper bound for attribSize. static_assert(std::is_same::value, ""); uint64_t attribStride = ComputeVertexAttributeStride(attrib, binding); uint64_t attribSize = ComputeVertexAttributeTypeSize(attrib); ASSERT(attribStride <= kIntMax && attribSize <= kMaxAttribSize); // Computing the max offset using uint64_t without attrib.offset is overflow // safe. Note: Last vertex element does not take the full stride! static_assert(kIntMax * kIntMax < kUint64Max - kMaxAttribSize, ""); uint64_t attribDataSizeNoOffset = maxVertexElement * attribStride + attribSize; // An overflow can happen when adding the offset, check for it. uint64_t attribOffset = ComputeVertexAttributeOffset(attrib, binding); if (attribDataSizeNoOffset > kUint64Max - attribOffset) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow); return false; } uint64_t attribDataSizeWithOffset = attribDataSizeNoOffset + attribOffset; // [OpenGL ES 3.0.2] section 2.9.4 page 40: // We can return INVALID_OPERATION if our vertex attribute does not have // enough backing data. if (attribDataSizeWithOffset > static_cast(buffer->getSize())) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientVertexBufferSize); return false; } } return true; } bool ValidReadPixelsTypeEnum(ValidationContext *context, GLenum type) { switch (type) { // Types referenced in Table 3.4 of the ES 2.0.25 spec case GL_UNSIGNED_BYTE: case GL_UNSIGNED_SHORT_4_4_4_4: case GL_UNSIGNED_SHORT_5_5_5_1: case GL_UNSIGNED_SHORT_5_6_5: return context->getClientVersion() >= ES_2_0; // Types referenced in Table 3.2 of the ES 3.0.5 spec (Except depth stencil) case GL_BYTE: case GL_INT: case GL_SHORT: case GL_UNSIGNED_INT: case GL_UNSIGNED_INT_10F_11F_11F_REV: case GL_UNSIGNED_INT_24_8: case GL_UNSIGNED_INT_2_10_10_10_REV: case GL_UNSIGNED_INT_5_9_9_9_REV: case GL_UNSIGNED_SHORT: case GL_UNSIGNED_SHORT_1_5_5_5_REV_EXT: case GL_UNSIGNED_SHORT_4_4_4_4_REV_EXT: return context->getClientVersion() >= ES_3_0; case GL_FLOAT: return context->getClientVersion() >= ES_3_0 || context->getExtensions().textureFloat || context->getExtensions().colorBufferHalfFloat; case GL_HALF_FLOAT: return context->getClientVersion() >= ES_3_0 || context->getExtensions().textureHalfFloat; case GL_HALF_FLOAT_OES: return context->getExtensions().colorBufferHalfFloat; default: return false; } } bool ValidReadPixelsFormatEnum(ValidationContext *context, GLenum format) { switch (format) { // Formats referenced in Table 3.4 of the ES 2.0.25 spec (Except luminance) case GL_RGBA: case GL_RGB: case GL_ALPHA: return context->getClientVersion() >= ES_2_0; // Formats referenced in Table 3.2 of the ES 3.0.5 spec case GL_RG: case GL_RED: case GL_RGBA_INTEGER: case GL_RGB_INTEGER: case GL_RG_INTEGER: case GL_RED_INTEGER: return context->getClientVersion() >= ES_3_0; case GL_SRGB_ALPHA_EXT: case GL_SRGB_EXT: return context->getExtensions().sRGB; case GL_BGRA_EXT: return context->getExtensions().readFormatBGRA; default: return false; } } bool ValidReadPixelsFormatType(ValidationContext *context, GLenum framebufferComponentType, GLenum format, GLenum type) { switch (framebufferComponentType) { case GL_UNSIGNED_NORMALIZED: // TODO(geofflang): Don't accept BGRA here. Some chrome internals appear to try to use // ReadPixels with BGRA even if the extension is not present return (format == GL_RGBA && type == GL_UNSIGNED_BYTE) || (context->getExtensions().readFormatBGRA && format == GL_BGRA_EXT && type == GL_UNSIGNED_BYTE); case GL_SIGNED_NORMALIZED: return (format == GL_RGBA && type == GL_UNSIGNED_BYTE); case GL_INT: return (format == GL_RGBA_INTEGER && type == GL_INT); case GL_UNSIGNED_INT: return (format == GL_RGBA_INTEGER && type == GL_UNSIGNED_INT); case GL_FLOAT: return (format == GL_RGBA && type == GL_FLOAT); default: UNREACHABLE(); return false; } } template bool ValidateTextureWrapModeValue(Context *context, ParamType *params, bool restrictedWrapModes) { switch (ConvertToGLenum(params[0])) { case GL_CLAMP_TO_EDGE: break; case GL_REPEAT: case GL_MIRRORED_REPEAT: if (restrictedWrapModes) { // OES_EGL_image_external and ANGLE_texture_rectangle specifies this error. ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidWrapModeTexture); return false; } break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureWrap); return false; } return true; } template bool ValidateTextureMinFilterValue(Context *context, ParamType *params, bool restrictedMinFilter) { switch (ConvertToGLenum(params[0])) { case GL_NEAREST: case GL_LINEAR: break; case GL_NEAREST_MIPMAP_NEAREST: case GL_LINEAR_MIPMAP_NEAREST: case GL_NEAREST_MIPMAP_LINEAR: case GL_LINEAR_MIPMAP_LINEAR: if (restrictedMinFilter) { // OES_EGL_image_external specifies this error. ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidFilterTexture); return false; } break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureFilterParam); return false; } return true; } template bool ValidateTextureMagFilterValue(Context *context, ParamType *params) { switch (ConvertToGLenum(params[0])) { case GL_NEAREST: case GL_LINEAR: break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureFilterParam); return false; } return true; } template bool ValidateTextureCompareModeValue(Context *context, ParamType *params) { // Acceptable mode parameters from GLES 3.0.2 spec, table 3.17 switch (ConvertToGLenum(params[0])) { case GL_NONE: case GL_COMPARE_REF_TO_TEXTURE: break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), UnknownParameter); return false; } return true; } template bool ValidateTextureCompareFuncValue(Context *context, ParamType *params) { // Acceptable function parameters from GLES 3.0.2 spec, table 3.17 switch (ConvertToGLenum(params[0])) { case GL_LEQUAL: case GL_GEQUAL: case GL_LESS: case GL_GREATER: case GL_EQUAL: case GL_NOTEQUAL: case GL_ALWAYS: case GL_NEVER: break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), UnknownParameter); return false; } return true; } template bool ValidateTextureSRGBDecodeValue(Context *context, ParamType *params) { if (!context->getExtensions().textureSRGBDecode) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled); return false; } switch (ConvertToGLenum(params[0])) { case GL_DECODE_EXT: case GL_SKIP_DECODE_EXT: break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), UnknownParameter); return false; } return true; } bool ValidateFragmentShaderColorBufferTypeMatch(ValidationContext *context) { const Program *program = context->getGLState().getProgram(); const Framebuffer *framebuffer = context->getGLState().getDrawFramebuffer(); const auto &programOutputTypes = program->getOutputVariableTypes(); for (size_t drawBufferIdx = 0; drawBufferIdx < programOutputTypes.size(); drawBufferIdx++) { GLenum outputType = programOutputTypes[drawBufferIdx]; GLenum inputType = framebuffer->getDrawbufferWriteType(drawBufferIdx); if (outputType != GL_NONE && inputType != GL_NONE && inputType != outputType) { context->handleError(InvalidOperation() << "Fragment shader output type does not " "match the bound framebuffer attachment " "type."); return false; } } return true; } bool ValidateVertexShaderAttributeTypeMatch(ValidationContext *context) { const auto &glState = context->getGLState(); const Program *program = context->getGLState().getProgram(); const VertexArray *vao = context->getGLState().getVertexArray(); const auto &vertexAttribs = vao->getVertexAttributes(); const auto ¤tValues = glState.getVertexAttribCurrentValues(); for (const sh::Attribute &shaderAttribute : program->getAttributes()) { // gl_VertexID and gl_InstanceID are active attributes but don't have a bound attribute. if (shaderAttribute.isBuiltIn()) { continue; } GLenum shaderInputType = VariableComponentType(shaderAttribute.type); const auto &attrib = vertexAttribs[shaderAttribute.location]; GLenum vertexType = attrib.enabled ? GetVertexAttributeBaseType(attrib) : currentValues[shaderAttribute.location].Type; if (shaderInputType != GL_NONE && vertexType != GL_NONE && shaderInputType != vertexType) { context->handleError(InvalidOperation() << "Vertex shader input type does not " "match the type of the bound vertex " "attribute."); return false; } } return true; } } // anonymous namespace bool ValidTextureTarget(const ValidationContext *context, GLenum target) { switch (target) { case GL_TEXTURE_2D: case GL_TEXTURE_CUBE_MAP: return true; case GL_TEXTURE_RECTANGLE_ANGLE: return context->getExtensions().textureRectangle; case GL_TEXTURE_3D: case GL_TEXTURE_2D_ARRAY: return (context->getClientMajorVersion() >= 3); case GL_TEXTURE_2D_MULTISAMPLE: return (context->getClientVersion() >= Version(3, 1)); default: return false; } } bool ValidTexture2DTarget(const ValidationContext *context, GLenum target) { switch (target) { case GL_TEXTURE_2D: case GL_TEXTURE_CUBE_MAP: return true; case GL_TEXTURE_RECTANGLE_ANGLE: return context->getExtensions().textureRectangle; default: return false; } } bool ValidTexture3DTarget(const ValidationContext *context, GLenum target) { switch (target) { case GL_TEXTURE_3D: case GL_TEXTURE_2D_ARRAY: return (context->getClientMajorVersion() >= 3); default: return false; } } // Most texture GL calls are not compatible with external textures, so we have a separate validation // function for use in the GL calls that do bool ValidTextureExternalTarget(const ValidationContext *context, GLenum target) { return (target == GL_TEXTURE_EXTERNAL_OES) && (context->getExtensions().eglImageExternal || context->getExtensions().eglStreamConsumerExternal); } // This function differs from ValidTextureTarget in that the target must be // usable as the destination of a 2D operation-- so a cube face is valid, but // GL_TEXTURE_CUBE_MAP is not. // Note: duplicate of IsInternalTextureTarget bool ValidTexture2DDestinationTarget(const ValidationContext *context, GLenum target) { switch (target) { case GL_TEXTURE_2D: case GL_TEXTURE_CUBE_MAP_POSITIVE_X: case GL_TEXTURE_CUBE_MAP_NEGATIVE_X: case GL_TEXTURE_CUBE_MAP_POSITIVE_Y: case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y: case GL_TEXTURE_CUBE_MAP_POSITIVE_Z: case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z: return true; case GL_TEXTURE_RECTANGLE_ANGLE: return context->getExtensions().textureRectangle; default: return false; } } bool ValidateDrawElementsInstancedBase(ValidationContext *context, GLenum mode, GLsizei count, GLenum type, const GLvoid *indices, GLsizei primcount) { if (primcount < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativePrimcount); return false; } if (!ValidateDrawElementsCommon(context, mode, count, type, indices, primcount)) { return false; } // No-op zero primitive count return (primcount > 0); } bool ValidateDrawArraysInstancedBase(Context *context, GLenum mode, GLint first, GLsizei count, GLsizei primcount) { if (primcount < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativePrimcount); return false; } if (!ValidateDrawArraysCommon(context, mode, first, count, primcount)) { return false; } // No-op if zero primitive count return (primcount > 0); } bool ValidateDrawInstancedANGLE(ValidationContext *context) { // Verify there is at least one active attribute with a divisor of zero const State &state = context->getGLState(); Program *program = state.getProgram(); const auto &attribs = state.getVertexArray()->getVertexAttributes(); const auto &bindings = state.getVertexArray()->getVertexBindings(); for (size_t attributeIndex = 0; attributeIndex < MAX_VERTEX_ATTRIBS; attributeIndex++) { const VertexAttribute &attrib = attribs[attributeIndex]; const VertexBinding &binding = bindings[attrib.bindingIndex]; if (program->isAttribLocationActive(attributeIndex) && binding.getDivisor() == 0) { return true; } } ANGLE_VALIDATION_ERR(context, InvalidOperation(), NoZeroDivisor); return false; } bool ValidTexture3DDestinationTarget(const ValidationContext *context, GLenum target) { switch (target) { case GL_TEXTURE_3D: case GL_TEXTURE_2D_ARRAY: return true; default: return false; } } bool ValidTexLevelDestinationTarget(const ValidationContext *context, GLenum target) { switch (target) { case GL_TEXTURE_2D: case GL_TEXTURE_CUBE_MAP_POSITIVE_X: case GL_TEXTURE_CUBE_MAP_NEGATIVE_X: case GL_TEXTURE_CUBE_MAP_POSITIVE_Y: case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y: case GL_TEXTURE_CUBE_MAP_POSITIVE_Z: case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z: case GL_TEXTURE_3D: case GL_TEXTURE_2D_ARRAY: case GL_TEXTURE_2D_MULTISAMPLE: return true; case GL_TEXTURE_RECTANGLE_ANGLE: return context->getExtensions().textureRectangle; default: return false; } } bool ValidFramebufferTarget(const ValidationContext *context, GLenum target) { static_assert(GL_DRAW_FRAMEBUFFER_ANGLE == GL_DRAW_FRAMEBUFFER && GL_READ_FRAMEBUFFER_ANGLE == GL_READ_FRAMEBUFFER, "ANGLE framebuffer enums must equal the ES3 framebuffer enums."); switch (target) { case GL_FRAMEBUFFER: return true; case GL_READ_FRAMEBUFFER: case GL_DRAW_FRAMEBUFFER: return (context->getExtensions().framebufferBlit || context->getClientMajorVersion() >= 3); default: return false; } } bool ValidBufferType(const ValidationContext *context, BufferBinding target) { switch (target) { case BufferBinding::ElementArray: case BufferBinding::Array: return true; case BufferBinding::PixelPack: case BufferBinding::PixelUnpack: return (context->getExtensions().pixelBufferObject || context->getClientMajorVersion() >= 3); case BufferBinding::CopyRead: case BufferBinding::CopyWrite: case BufferBinding::TransformFeedback: case BufferBinding::Uniform: return (context->getClientMajorVersion() >= 3); case BufferBinding::AtomicCounter: case BufferBinding::ShaderStorage: case BufferBinding::DrawIndirect: case BufferBinding::DispatchIndirect: return context->getClientVersion() >= Version(3, 1); default: return false; } } bool ValidMipLevel(const ValidationContext *context, GLenum target, GLint level) { const auto &caps = context->getCaps(); size_t maxDimension = 0; switch (target) { case GL_TEXTURE_2D: maxDimension = caps.max2DTextureSize; break; case GL_TEXTURE_CUBE_MAP: case GL_TEXTURE_CUBE_MAP_POSITIVE_X: case GL_TEXTURE_CUBE_MAP_NEGATIVE_X: case GL_TEXTURE_CUBE_MAP_POSITIVE_Y: case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y: case GL_TEXTURE_CUBE_MAP_POSITIVE_Z: case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z: maxDimension = caps.maxCubeMapTextureSize; break; case GL_TEXTURE_RECTANGLE_ANGLE: return level == 0; case GL_TEXTURE_3D: maxDimension = caps.max3DTextureSize; break; case GL_TEXTURE_2D_ARRAY: maxDimension = caps.max2DTextureSize; break; case GL_TEXTURE_2D_MULTISAMPLE: maxDimension = caps.max2DTextureSize; break; default: UNREACHABLE(); } return level <= gl::log2(static_cast(maxDimension)) && level >= 0; } bool ValidImageSizeParameters(ValidationContext *context, GLenum target, GLint level, GLsizei width, GLsizei height, GLsizei depth, bool isSubImage) { if (width < 0 || height < 0 || depth < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeSize); return false; } // TexSubImage parameters can be NPOT without textureNPOT extension, // as long as the destination texture is POT. bool hasNPOTSupport = context->getExtensions().textureNPOT || context->getClientVersion() >= Version(3, 0); if (!isSubImage && !hasNPOTSupport && (level != 0 && (!gl::isPow2(width) || !gl::isPow2(height) || !gl::isPow2(depth)))) { ANGLE_VALIDATION_ERR(context, InvalidValue(), TextureNotPow2); return false; } if (!ValidMipLevel(context, target, level)) { ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel); return false; } return true; } bool CompressedTextureFormatRequiresExactSize(GLenum internalFormat) { // List of compressed format that require that the texture size is smaller than or a multiple of // the compressed block size. switch (internalFormat) { case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: case GL_COMPRESSED_SRGB_S3TC_DXT1_EXT: case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT1_EXT: case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT3_EXT: case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT5_EXT: case GL_ETC1_RGB8_LOSSY_DECODE_ANGLE: case GL_COMPRESSED_RGB8_LOSSY_DECODE_ETC2_ANGLE: case GL_COMPRESSED_SRGB8_LOSSY_DECODE_ETC2_ANGLE: case GL_COMPRESSED_RGB8_PUNCHTHROUGH_ALPHA1_LOSSY_DECODE_ETC2_ANGLE: case GL_COMPRESSED_SRGB8_PUNCHTHROUGH_ALPHA1_LOSSY_DECODE_ETC2_ANGLE: case GL_COMPRESSED_RGBA8_LOSSY_DECODE_ETC2_EAC_ANGLE: case GL_COMPRESSED_SRGB8_ALPHA8_LOSSY_DECODE_ETC2_EAC_ANGLE: return true; default: return false; } } bool ValidCompressedDimension(GLsizei size, GLuint blockSize, bool smallerThanBlockSizeAllowed) { return (smallerThanBlockSizeAllowed && (size > 0) && (blockSize % size == 0)) || (size % blockSize == 0); } bool ValidCompressedImageSize(const ValidationContext *context, GLenum internalFormat, GLint level, GLsizei width, GLsizei height) { const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(internalFormat); if (!formatInfo.compressed) { return false; } if (width < 0 || height < 0) { return false; } if (CompressedTextureFormatRequiresExactSize(internalFormat)) { // The ANGLE extensions allow specifying compressed textures with sizes smaller than the // block size for level 0 but WebGL disallows this. bool smallerThanBlockSizeAllowed = level > 0 || !context->getExtensions().webglCompatibility; if (!ValidCompressedDimension(width, formatInfo.compressedBlockWidth, smallerThanBlockSizeAllowed) || !ValidCompressedDimension(height, formatInfo.compressedBlockHeight, smallerThanBlockSizeAllowed)) { return false; } } return true; } bool ValidCompressedSubImageSize(const ValidationContext *context, GLenum internalFormat, GLint xoffset, GLint yoffset, GLsizei width, GLsizei height, size_t textureWidth, size_t textureHeight) { const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(internalFormat); if (!formatInfo.compressed) { return false; } if (xoffset < 0 || yoffset < 0 || width < 0 || height < 0) { return false; } if (CompressedTextureFormatRequiresExactSize(internalFormat)) { if (xoffset % formatInfo.compressedBlockWidth != 0 || yoffset % formatInfo.compressedBlockHeight != 0) { return false; } // Allowed to either have data that is a multiple of block size or is smaller than the block // size but fills the entire mip bool fillsEntireMip = xoffset == 0 && yoffset == 0 && static_cast(width) == textureWidth && static_cast(height) == textureHeight; bool sizeMultipleOfBlockSize = (width % formatInfo.compressedBlockWidth) == 0 && (height % formatInfo.compressedBlockHeight) == 0; if (!sizeMultipleOfBlockSize && !fillsEntireMip) { return false; } } return true; } bool ValidImageDataSize(ValidationContext *context, GLenum textureTarget, GLsizei width, GLsizei height, GLsizei depth, GLenum format, GLenum type, const void *pixels, GLsizei imageSize) { gl::Buffer *pixelUnpackBuffer = context->getGLState().getTargetBuffer(BufferBinding::PixelUnpack); if (pixelUnpackBuffer == nullptr && imageSize < 0) { // Checks are not required return true; } // ...the data would be unpacked from the buffer object such that the memory reads required // would exceed the data store size. const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(format, type); ASSERT(formatInfo.internalFormat != GL_NONE); const gl::Extents size(width, height, depth); const auto &unpack = context->getGLState().getUnpackState(); bool targetIs3D = textureTarget == GL_TEXTURE_3D || textureTarget == GL_TEXTURE_2D_ARRAY; auto endByteOrErr = formatInfo.computePackUnpackEndByte(type, size, unpack, targetIs3D); if (endByteOrErr.isError()) { context->handleError(endByteOrErr.getError()); return false; } GLuint endByte = endByteOrErr.getResult(); if (pixelUnpackBuffer) { CheckedNumeric checkedEndByte(endByteOrErr.getResult()); CheckedNumeric checkedOffset(reinterpret_cast(pixels)); checkedEndByte += checkedOffset; if (!checkedEndByte.IsValid() || (checkedEndByte.ValueOrDie() > static_cast(pixelUnpackBuffer->getSize()))) { // Overflow past the end of the buffer context->handleError(InvalidOperation()); return false; } } else { ASSERT(imageSize >= 0); if (pixels == nullptr && imageSize != 0) { context->handleError(InvalidOperation() << "imageSize must be 0 if no texture data is provided."); return false; } if (pixels != nullptr && endByte > static_cast(imageSize)) { context->handleError(InvalidOperation() << "imageSize must be at least " << endByte); return false; } } return true; } bool ValidQueryType(const Context *context, GLenum queryType) { static_assert(GL_ANY_SAMPLES_PASSED == GL_ANY_SAMPLES_PASSED_EXT, "GL extension enums not equal."); static_assert(GL_ANY_SAMPLES_PASSED_CONSERVATIVE == GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT, "GL extension enums not equal."); switch (queryType) { case GL_ANY_SAMPLES_PASSED: case GL_ANY_SAMPLES_PASSED_CONSERVATIVE: return context->getClientMajorVersion() >= 3 || context->getExtensions().occlusionQueryBoolean; case GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN: return (context->getClientMajorVersion() >= 3); case GL_TIME_ELAPSED_EXT: return context->getExtensions().disjointTimerQuery; case GL_COMMANDS_COMPLETED_CHROMIUM: return context->getExtensions().syncQuery; default: return false; } } bool ValidateWebGLVertexAttribPointer(ValidationContext *context, GLenum type, GLboolean normalized, GLsizei stride, const void *ptr, bool pureInteger) { ASSERT(context->getExtensions().webglCompatibility); // WebGL 1.0 [Section 6.11] Vertex Attribute Data Stride // The WebGL API supports vertex attribute data strides up to 255 bytes. A call to // vertexAttribPointer will generate an INVALID_VALUE error if the value for the stride // parameter exceeds 255. constexpr GLsizei kMaxWebGLStride = 255; if (stride > kMaxWebGLStride) { context->handleError(InvalidValue() << "Stride is over the maximum stride allowed by WebGL."); return false; } // WebGL 1.0 [Section 6.4] Buffer Offset and Stride Requirements // The offset arguments to drawElements and vertexAttribPointer, and the stride argument to // vertexAttribPointer, must be a multiple of the size of the data type passed to the call, // or an INVALID_OPERATION error is generated. VertexFormatType internalType = GetVertexFormatType(type, normalized, 1, pureInteger); size_t typeSize = GetVertexFormatTypeSize(internalType); ASSERT(isPow2(typeSize) && typeSize > 0); size_t sizeMask = (typeSize - 1); if ((reinterpret_cast(ptr) & sizeMask) != 0) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), OffsetMustBeMultipleOfType); return false; } if ((stride & sizeMask) != 0) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), StrideMustBeMultipleOfType); return false; } return true; } Program *GetValidProgram(ValidationContext *context, GLuint id) { // ES3 spec (section 2.11.1) -- "Commands that accept shader or program object names will // generate the error INVALID_VALUE if the provided name is not the name of either a shader // or program object and INVALID_OPERATION if the provided name identifies an object // that is not the expected type." Program *validProgram = context->getProgram(id); if (!validProgram) { if (context->getShader(id)) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExpectedProgramName); } else { ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidProgramName); } } return validProgram; } Shader *GetValidShader(ValidationContext *context, GLuint id) { // See ValidProgram for spec details. Shader *validShader = context->getShader(id); if (!validShader) { if (context->getProgram(id)) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExpectedShaderName); } else { ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidShaderName); } } return validShader; } bool ValidateAttachmentTarget(gl::Context *context, GLenum attachment) { if (attachment >= GL_COLOR_ATTACHMENT1_EXT && attachment <= GL_COLOR_ATTACHMENT15_EXT) { if (context->getClientMajorVersion() < 3 && !context->getExtensions().drawBuffers) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidAttachment); return false; } // Color attachment 0 is validated below because it is always valid const unsigned int colorAttachment = (attachment - GL_COLOR_ATTACHMENT0_EXT); if (colorAttachment >= context->getCaps().maxColorAttachments) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidAttachment); return false; } } else { switch (attachment) { case GL_COLOR_ATTACHMENT0: case GL_DEPTH_ATTACHMENT: case GL_STENCIL_ATTACHMENT: break; case GL_DEPTH_STENCIL_ATTACHMENT: if (!context->getExtensions().webglCompatibility && context->getClientMajorVersion() < 3) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidAttachment); return false; } break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidAttachment); return false; } } return true; } bool ValidateRenderbufferStorageParametersBase(ValidationContext *context, GLenum target, GLsizei samples, GLenum internalformat, GLsizei width, GLsizei height) { switch (target) { case GL_RENDERBUFFER: break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferTarget); return false; } if (width < 0 || height < 0 || samples < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidRenderbufferWidthHeight); return false; } // Hack for the special WebGL 1 "DEPTH_STENCIL" internal format. GLenum convertedInternalFormat = context->getConvertedRenderbufferFormat(internalformat); const TextureCaps &formatCaps = context->getTextureCaps().get(convertedInternalFormat); if (!formatCaps.renderable) { context->handleError(InvalidEnum()); return false; } // ANGLE_framebuffer_multisample does not explicitly state that the internal format must be // sized but it does state that the format must be in the ES2.0 spec table 4.5 which contains // only sized internal formats. const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(convertedInternalFormat); if (formatInfo.internalFormat == GL_NONE) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferInternalFormat); return false; } if (static_cast(std::max(width, height)) > context->getCaps().maxRenderbufferSize) { context->handleError(InvalidValue()); return false; } GLuint handle = context->getGLState().getRenderbufferId(); if (handle == 0) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidRenderbufferTarget); return false; } return true; } bool ValidateFramebufferRenderbufferParameters(gl::Context *context, GLenum target, GLenum attachment, GLenum renderbuffertarget, GLuint renderbuffer) { if (!ValidFramebufferTarget(context, target)) { context->handleError(InvalidEnum()); return false; } gl::Framebuffer *framebuffer = context->getGLState().getTargetFramebuffer(target); ASSERT(framebuffer); if (framebuffer->id() == 0) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), DefaultFramebufferTarget); return false; } if (!ValidateAttachmentTarget(context, attachment)) { return false; } // [OpenGL ES 2.0.25] Section 4.4.3 page 112 // [OpenGL ES 3.0.2] Section 4.4.2 page 201 // 'renderbuffer' must be either zero or the name of an existing renderbuffer object of // type 'renderbuffertarget', otherwise an INVALID_OPERATION error is generated. if (renderbuffer != 0) { if (!context->getRenderbuffer(renderbuffer)) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidRenderbufferTarget); return false; } } return true; } bool ValidateBlitFramebufferParameters(ValidationContext *context, GLint srcX0, GLint srcY0, GLint srcX1, GLint srcY1, GLint dstX0, GLint dstY0, GLint dstX1, GLint dstY1, GLbitfield mask, GLenum filter) { switch (filter) { case GL_NEAREST: break; case GL_LINEAR: break; default: context->handleError(InvalidEnum()); return false; } if ((mask & ~(GL_COLOR_BUFFER_BIT | GL_STENCIL_BUFFER_BIT | GL_DEPTH_BUFFER_BIT)) != 0) { context->handleError(InvalidValue()); return false; } if (mask == 0) { // ES3.0 spec, section 4.3.2 specifies that a mask of zero is valid and no // buffers are copied. return false; } // ES3.0 spec, section 4.3.2 states that linear filtering is only available for the // color buffer, leaving only nearest being unfiltered from above if ((mask & ~GL_COLOR_BUFFER_BIT) != 0 && filter != GL_NEAREST) { context->handleError(InvalidOperation()); return false; } const auto &glState = context->getGLState(); gl::Framebuffer *readFramebuffer = glState.getReadFramebuffer(); gl::Framebuffer *drawFramebuffer = glState.getDrawFramebuffer(); if (!readFramebuffer || !drawFramebuffer) { context->handleError(InvalidFramebufferOperation()); return false; } if (readFramebuffer->id() == drawFramebuffer->id()) { context->handleError(InvalidOperation()); return false; } if (readFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE) { context->handleError(InvalidFramebufferOperation()); return false; } if (drawFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE) { context->handleError(InvalidFramebufferOperation()); return false; } if (drawFramebuffer->getSamples(context) != 0) { context->handleError(InvalidOperation()); return false; } bool sameBounds = srcX0 == dstX0 && srcY0 == dstY0 && srcX1 == dstX1 && srcY1 == dstY1; if (mask & GL_COLOR_BUFFER_BIT) { const gl::FramebufferAttachment *readColorBuffer = readFramebuffer->getReadColorbuffer(); const Extensions &extensions = context->getExtensions(); if (readColorBuffer) { const Format &readFormat = readColorBuffer->getFormat(); for (size_t drawbufferIdx = 0; drawbufferIdx < drawFramebuffer->getDrawbufferStateCount(); ++drawbufferIdx) { const FramebufferAttachment *attachment = drawFramebuffer->getDrawBuffer(drawbufferIdx); if (attachment) { const Format &drawFormat = attachment->getFormat(); // The GL ES 3.0.2 spec (pg 193) states that: // 1) If the read buffer is fixed point format, the draw buffer must be as well // 2) If the read buffer is an unsigned integer format, the draw buffer must be // as well // 3) If the read buffer is a signed integer format, the draw buffer must be as // well // Changes with EXT_color_buffer_float: // Case 1) is changed to fixed point OR floating point GLenum readComponentType = readFormat.info->componentType; GLenum drawComponentType = drawFormat.info->componentType; bool readFixedPoint = (readComponentType == GL_UNSIGNED_NORMALIZED || readComponentType == GL_SIGNED_NORMALIZED); bool drawFixedPoint = (drawComponentType == GL_UNSIGNED_NORMALIZED || drawComponentType == GL_SIGNED_NORMALIZED); if (extensions.colorBufferFloat) { bool readFixedOrFloat = (readFixedPoint || readComponentType == GL_FLOAT); bool drawFixedOrFloat = (drawFixedPoint || drawComponentType == GL_FLOAT); if (readFixedOrFloat != drawFixedOrFloat) { context->handleError(InvalidOperation() << "If the read buffer contains fixed-point or " "floating-point values, the draw buffer must " "as well."); return false; } } else if (readFixedPoint != drawFixedPoint) { context->handleError(InvalidOperation() << "If the read buffer contains fixed-point values, " "the draw buffer must as well."); return false; } if (readComponentType == GL_UNSIGNED_INT && drawComponentType != GL_UNSIGNED_INT) { context->handleError(InvalidOperation()); return false; } if (readComponentType == GL_INT && drawComponentType != GL_INT) { context->handleError(InvalidOperation()); return false; } if (readColorBuffer->getSamples() > 0 && (!Format::EquivalentForBlit(readFormat, drawFormat) || !sameBounds)) { context->handleError(InvalidOperation()); return false; } if (context->getExtensions().webglCompatibility && *readColorBuffer == *attachment) { context->handleError( InvalidOperation() << "Read and write color attachments cannot be the same image."); return false; } } } if ((readFormat.info->componentType == GL_INT || readFormat.info->componentType == GL_UNSIGNED_INT) && filter == GL_LINEAR) { context->handleError(InvalidOperation()); return false; } } // WebGL 2.0 BlitFramebuffer when blitting from a missing attachment // In OpenGL ES it is undefined what happens when an operation tries to blit from a missing // attachment and WebGL defines it to be an error. We do the check unconditionally as the // situation is an application error that would lead to a crash in ANGLE. else if (drawFramebuffer->hasEnabledDrawBuffer()) { context->handleError( InvalidOperation() << "Attempt to read from a missing color attachment of a complete framebuffer."); return false; } } GLenum masks[] = {GL_DEPTH_BUFFER_BIT, GL_STENCIL_BUFFER_BIT}; GLenum attachments[] = {GL_DEPTH_ATTACHMENT, GL_STENCIL_ATTACHMENT}; for (size_t i = 0; i < 2; i++) { if (mask & masks[i]) { const gl::FramebufferAttachment *readBuffer = readFramebuffer->getAttachment(attachments[i]); const gl::FramebufferAttachment *drawBuffer = drawFramebuffer->getAttachment(attachments[i]); if (readBuffer && drawBuffer) { if (!Format::EquivalentForBlit(readBuffer->getFormat(), drawBuffer->getFormat())) { context->handleError(InvalidOperation()); return false; } if (readBuffer->getSamples() > 0 && !sameBounds) { context->handleError(InvalidOperation()); return false; } if (context->getExtensions().webglCompatibility && *readBuffer == *drawBuffer) { context->handleError( InvalidOperation() << "Read and write depth stencil attachments cannot be the same image."); return false; } } // WebGL 2.0 BlitFramebuffer when blitting from a missing attachment else if (drawBuffer) { context->handleError(InvalidOperation() << "Attempt to read from a missing " "depth/stencil attachment of a " "complete framebuffer."); return false; } } } // ANGLE_multiview, Revision 1: // Calling BlitFramebuffer will result in an INVALID_FRAMEBUFFER_OPERATION error if the // multi-view layout of the current draw framebuffer or read framebuffer is not NONE. if (readFramebuffer->getMultiviewLayout() != GL_NONE) { context->handleError(InvalidFramebufferOperation() << "Attempt to read from a multi-view framebuffer."); return false; } if (drawFramebuffer->getMultiviewLayout() != GL_NONE) { context->handleError(InvalidFramebufferOperation() << "Attempt to write to a multi-view framebuffer."); return false; } return true; } bool ValidateReadPixelsRobustANGLE(Context *context, GLint x, GLint y, GLsizei width, GLsizei height, GLenum format, GLenum type, GLsizei bufSize, GLsizei *length, GLsizei *columns, GLsizei *rows, void *pixels) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateReadPixelsBase(context, x, y, width, height, format, type, bufSize, length, columns, rows, pixels)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateReadnPixelsEXT(Context *context, GLint x, GLint y, GLsizei width, GLsizei height, GLenum format, GLenum type, GLsizei bufSize, void *pixels) { if (bufSize < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeBufferSize); return false; } return ValidateReadPixelsBase(context, x, y, width, height, format, type, bufSize, nullptr, nullptr, nullptr, pixels); } bool ValidateReadnPixelsRobustANGLE(Context *context, GLint x, GLint y, GLsizei width, GLsizei height, GLenum format, GLenum type, GLsizei bufSize, GLsizei *length, GLsizei *columns, GLsizei *rows, void *data) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateReadPixelsBase(context, x, y, width, height, format, type, bufSize, length, columns, rows, data)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateGenQueriesEXT(gl::Context *context, GLsizei n, GLuint *ids) { if (!context->getExtensions().occlusionQueryBoolean && !context->getExtensions().disjointTimerQuery) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryExtensionNotEnabled); return false; } return ValidateGenOrDelete(context, n); } bool ValidateDeleteQueriesEXT(gl::Context *context, GLsizei n, const GLuint *ids) { if (!context->getExtensions().occlusionQueryBoolean && !context->getExtensions().disjointTimerQuery) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryExtensionNotEnabled); return false; } return ValidateGenOrDelete(context, n); } bool ValidateIsQueryEXT(gl::Context *context, GLuint id) { if (!context->getExtensions().occlusionQueryBoolean && !context->getExtensions().disjointTimerQuery) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryExtensionNotEnabled); return false; } return true; } bool ValidateBeginQueryBase(gl::Context *context, GLenum target, GLuint id) { if (!ValidQueryType(context, target)) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidQueryType); return false; } if (id == 0) { context->handleError(InvalidOperation() << "Query id is 0"); return false; } // From EXT_occlusion_query_boolean: If BeginQueryEXT is called with an // of zero, if the active query object name for is non-zero (for the // targets ANY_SAMPLES_PASSED_EXT and ANY_SAMPLES_PASSED_CONSERVATIVE_EXT, if // the active query for either target is non-zero), if is the name of an // existing query object whose type does not match , or if is the // active query object name for any query type, the error INVALID_OPERATION is // generated. // Ensure no other queries are active // NOTE: If other queries than occlusion are supported, we will need to check // separately that: // a) The query ID passed is not the current active query for any target/type // b) There are no active queries for the requested target (and in the case // of GL_ANY_SAMPLES_PASSED_EXT and GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT, // no query may be active for either if glBeginQuery targets either. if (context->getGLState().isQueryActive(target)) { context->handleError(InvalidOperation() << "Other query is active"); return false; } Query *queryObject = context->getQuery(id, true, target); // check that name was obtained with glGenQueries if (!queryObject) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidQueryId); return false; } // check for type mismatch if (queryObject->getType() != target) { context->handleError(InvalidOperation() << "Query type does not match target"); return false; } return true; } bool ValidateBeginQueryEXT(gl::Context *context, GLenum target, GLuint id) { if (!context->getExtensions().occlusionQueryBoolean && !context->getExtensions().disjointTimerQuery && !context->getExtensions().syncQuery) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryExtensionNotEnabled); return false; } return ValidateBeginQueryBase(context, target, id); } bool ValidateEndQueryBase(gl::Context *context, GLenum target) { if (!ValidQueryType(context, target)) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidQueryType); return false; } const Query *queryObject = context->getGLState().getActiveQuery(target); if (queryObject == nullptr) { context->handleError(InvalidOperation() << "Query target not active"); return false; } return true; } bool ValidateEndQueryEXT(gl::Context *context, GLenum target) { if (!context->getExtensions().occlusionQueryBoolean && !context->getExtensions().disjointTimerQuery && !context->getExtensions().syncQuery) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryExtensionNotEnabled); return false; } return ValidateEndQueryBase(context, target); } bool ValidateQueryCounterEXT(Context *context, GLuint id, GLenum target) { if (!context->getExtensions().disjointTimerQuery) { context->handleError(InvalidOperation() << "Disjoint timer query not enabled"); return false; } if (target != GL_TIMESTAMP_EXT) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidQueryTarget); return false; } Query *queryObject = context->getQuery(id, true, target); if (queryObject == nullptr) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidQueryId); return false; } if (context->getGLState().isQueryActive(queryObject)) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryActive); return false; } return true; } bool ValidateGetQueryivBase(Context *context, GLenum target, GLenum pname, GLsizei *numParams) { if (numParams) { *numParams = 0; } if (!ValidQueryType(context, target) && target != GL_TIMESTAMP_EXT) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidQueryType); return false; } switch (pname) { case GL_CURRENT_QUERY_EXT: if (target == GL_TIMESTAMP_EXT) { context->handleError(InvalidEnum() << "Cannot use current query for timestamp"); return false; } break; case GL_QUERY_COUNTER_BITS_EXT: if (!context->getExtensions().disjointTimerQuery || (target != GL_TIMESTAMP_EXT && target != GL_TIME_ELAPSED_EXT)) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidPname); return false; } break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidPname); return false; } if (numParams) { // All queries return only one value *numParams = 1; } return true; } bool ValidateGetQueryivEXT(Context *context, GLenum target, GLenum pname, GLint *params) { if (!context->getExtensions().occlusionQueryBoolean && !context->getExtensions().disjointTimerQuery && !context->getExtensions().syncQuery) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled); return false; } return ValidateGetQueryivBase(context, target, pname, nullptr); } bool ValidateGetQueryivRobustANGLE(Context *context, GLenum target, GLenum pname, GLsizei bufSize, GLsizei *length, GLint *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetQueryivBase(context, target, pname, length)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateGetQueryObjectValueBase(Context *context, GLuint id, GLenum pname, GLsizei *numParams) { if (numParams) { *numParams = 0; } Query *queryObject = context->getQuery(id, false, GL_NONE); if (!queryObject) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidQueryId); return false; } if (context->getGLState().isQueryActive(queryObject)) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryActive); return false; } switch (pname) { case GL_QUERY_RESULT_EXT: case GL_QUERY_RESULT_AVAILABLE_EXT: break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } if (numParams) { *numParams = 1; } return true; } bool ValidateGetQueryObjectivEXT(Context *context, GLuint id, GLenum pname, GLint *params) { if (!context->getExtensions().disjointTimerQuery) { context->handleError(InvalidOperation() << "Timer query extension not enabled"); return false; } return ValidateGetQueryObjectValueBase(context, id, pname, nullptr); } bool ValidateGetQueryObjectivRobustANGLE(Context *context, GLuint id, GLenum pname, GLsizei bufSize, GLsizei *length, GLint *params) { if (!context->getExtensions().disjointTimerQuery) { context->handleError(InvalidOperation() << "Timer query extension not enabled"); return false; } if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetQueryObjectValueBase(context, id, pname, length)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateGetQueryObjectuivEXT(Context *context, GLuint id, GLenum pname, GLuint *params) { if (!context->getExtensions().disjointTimerQuery && !context->getExtensions().occlusionQueryBoolean && !context->getExtensions().syncQuery) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled); return false; } return ValidateGetQueryObjectValueBase(context, id, pname, nullptr); } bool ValidateGetQueryObjectuivRobustANGLE(Context *context, GLuint id, GLenum pname, GLsizei bufSize, GLsizei *length, GLuint *params) { if (!context->getExtensions().disjointTimerQuery && !context->getExtensions().occlusionQueryBoolean && !context->getExtensions().syncQuery) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled); return false; } if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetQueryObjectValueBase(context, id, pname, length)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateGetQueryObjecti64vEXT(Context *context, GLuint id, GLenum pname, GLint64 *params) { if (!context->getExtensions().disjointTimerQuery) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled); return false; } return ValidateGetQueryObjectValueBase(context, id, pname, nullptr); } bool ValidateGetQueryObjecti64vRobustANGLE(Context *context, GLuint id, GLenum pname, GLsizei bufSize, GLsizei *length, GLint64 *params) { if (!context->getExtensions().disjointTimerQuery) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled); return false; } if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetQueryObjectValueBase(context, id, pname, length)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateGetQueryObjectui64vEXT(Context *context, GLuint id, GLenum pname, GLuint64 *params) { if (!context->getExtensions().disjointTimerQuery) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled); return false; } return ValidateGetQueryObjectValueBase(context, id, pname, nullptr); } bool ValidateGetQueryObjectui64vRobustANGLE(Context *context, GLuint id, GLenum pname, GLsizei bufSize, GLsizei *length, GLuint64 *params) { if (!context->getExtensions().disjointTimerQuery) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled); return false; } if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetQueryObjectValueBase(context, id, pname, length)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateUniformCommonBase(ValidationContext *context, gl::Program *program, GLint location, GLsizei count, const LinkedUniform **uniformOut) { // TODO(Jiajia): Add image uniform check in future. if (count < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount); return false; } if (!program) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidProgramName); return false; } if (!program->isLinked()) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked); return false; } if (location == -1) { // Silently ignore the uniform command return false; } const auto &uniformLocations = program->getUniformLocations(); size_t castedLocation = static_cast(location); if (castedLocation >= uniformLocations.size()) { context->handleError(InvalidOperation() << "Invalid uniform location"); return false; } const auto &uniformLocation = uniformLocations[castedLocation]; if (uniformLocation.ignored) { // Silently ignore the uniform command return false; } if (!uniformLocation.used()) { context->handleError(InvalidOperation()); return false; } const auto &uniform = program->getUniformByIndex(uniformLocation.index); // attempting to write an array to a non-array uniform is an INVALID_OPERATION if (!uniform.isArray() && count > 1) { context->handleError(InvalidOperation()); return false; } *uniformOut = &uniform; return true; } bool ValidateUniform1ivValue(ValidationContext *context, GLenum uniformType, GLsizei count, const GLint *value) { // Value type is GL_INT, because we only get here from glUniform1i{v}. // It is compatible with INT or BOOL. // Do these cheap tests first, for a little extra speed. if (GL_INT == uniformType || GL_BOOL == uniformType) { return true; } if (IsSamplerType(uniformType)) { // Check that the values are in range. const GLint max = context->getCaps().maxCombinedTextureImageUnits; for (GLsizei i = 0; i < count; ++i) { if (value[i] < 0 || value[i] >= max) { context->handleError(InvalidValue() << "sampler uniform value out of range"); return false; } } return true; } context->handleError(InvalidOperation() << "wrong type of value for uniform"); return false; } bool ValidateUniformValue(ValidationContext *context, GLenum valueType, GLenum uniformType) { // Check that the value type is compatible with uniform type. // Do the cheaper test first, for a little extra speed. if (valueType == uniformType || VariableBoolVectorType(valueType) == uniformType) { return true; } ANGLE_VALIDATION_ERR(context, InvalidOperation(), UniformSizeMismatch); return false; } bool ValidateUniformMatrixValue(ValidationContext *context, GLenum valueType, GLenum uniformType) { // Check that the value type is compatible with uniform type. if (valueType == uniformType) { return true; } context->handleError(InvalidOperation() << "wrong type of value for uniform"); return false; } bool ValidateUniform(ValidationContext *context, GLenum valueType, GLint location, GLsizei count) { const LinkedUniform *uniform = nullptr; gl::Program *programObject = context->getGLState().getProgram(); return ValidateUniformCommonBase(context, programObject, location, count, &uniform) && ValidateUniformValue(context, valueType, uniform->type); } bool ValidateUniform1iv(ValidationContext *context, GLint location, GLsizei count, const GLint *value) { const LinkedUniform *uniform = nullptr; gl::Program *programObject = context->getGLState().getProgram(); return ValidateUniformCommonBase(context, programObject, location, count, &uniform) && ValidateUniform1ivValue(context, uniform->type, count, value); } bool ValidateUniformMatrix(ValidationContext *context, GLenum valueType, GLint location, GLsizei count, GLboolean transpose) { if (ConvertToBool(transpose) && context->getClientMajorVersion() < 3) { context->handleError(InvalidValue()); return false; } const LinkedUniform *uniform = nullptr; gl::Program *programObject = context->getGLState().getProgram(); return ValidateUniformCommonBase(context, programObject, location, count, &uniform) && ValidateUniformMatrixValue(context, valueType, uniform->type); } bool ValidateStateQuery(ValidationContext *context, GLenum pname, GLenum *nativeType, unsigned int *numParams) { if (!context->getQueryParameterInfo(pname, nativeType, numParams)) { context->handleError(InvalidEnum()); return false; } const Caps &caps = context->getCaps(); if (pname >= GL_DRAW_BUFFER0 && pname <= GL_DRAW_BUFFER15) { unsigned int colorAttachment = (pname - GL_DRAW_BUFFER0); if (colorAttachment >= caps.maxDrawBuffers) { context->handleError(InvalidOperation()); return false; } } switch (pname) { case GL_TEXTURE_BINDING_2D: case GL_TEXTURE_BINDING_CUBE_MAP: case GL_TEXTURE_BINDING_3D: case GL_TEXTURE_BINDING_2D_ARRAY: case GL_TEXTURE_BINDING_2D_MULTISAMPLE: break; case GL_TEXTURE_BINDING_RECTANGLE_ANGLE: if (!context->getExtensions().textureRectangle) { context->handleError(InvalidEnum() << "ANGLE_texture_rectangle extension not present"); return false; } break; case GL_TEXTURE_BINDING_EXTERNAL_OES: if (!context->getExtensions().eglStreamConsumerExternal && !context->getExtensions().eglImageExternal) { context->handleError(InvalidEnum() << "Neither NV_EGL_stream_consumer_external " "nor GL_OES_EGL_image_external " "extensions enabled"); return false; } break; case GL_IMPLEMENTATION_COLOR_READ_TYPE: case GL_IMPLEMENTATION_COLOR_READ_FORMAT: { if (context->getGLState().getReadFramebuffer()->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE) { context->handleError(InvalidOperation()); return false; } const Framebuffer *framebuffer = context->getGLState().getReadFramebuffer(); ASSERT(framebuffer); if (framebuffer->getReadBufferState() == GL_NONE) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ReadBufferNone); return false; } const FramebufferAttachment *attachment = framebuffer->getReadColorbuffer(); if (!attachment) { context->handleError(InvalidOperation()); return false; } } break; default: break; } // pname is valid, but there are no parameters to return if (*numParams == 0) { return false; } return true; } bool ValidateRobustStateQuery(ValidationContext *context, GLenum pname, GLsizei bufSize, GLenum *nativeType, unsigned int *numParams) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateStateQuery(context, pname, nativeType, numParams)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *numParams)) { return false; } return true; } bool ValidateCopyTexImageParametersBase(ValidationContext *context, GLenum target, GLint level, GLenum internalformat, bool isSubImage, GLint xoffset, GLint yoffset, GLint zoffset, GLint x, GLint y, GLsizei width, GLsizei height, GLint border, Format *textureFormatOut) { if (xoffset < 0 || yoffset < 0 || zoffset < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset); return false; } if (width < 0 || height < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeSize); return false; } if (std::numeric_limits::max() - xoffset < width || std::numeric_limits::max() - yoffset < height) { context->handleError(InvalidValue()); return false; } if (border != 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidBorder); return false; } if (!ValidMipLevel(context, target, level)) { ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel); return false; } const auto &state = context->getGLState(); Framebuffer *readFramebuffer = state.getReadFramebuffer(); if (readFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE) { context->handleError(InvalidFramebufferOperation()); return false; } if (readFramebuffer->id() != 0 && readFramebuffer->getSamples(context) != 0) { context->handleError(InvalidOperation()); return false; } if (readFramebuffer->getReadBufferState() == GL_NONE) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ReadBufferNone); return false; } // WebGL 1.0 [Section 6.26] Reading From a Missing Attachment // In OpenGL ES it is undefined what happens when an operation tries to read from a missing // attachment and WebGL defines it to be an error. We do the check unconditionally as the // situation is an application error that would lead to a crash in ANGLE. const FramebufferAttachment *source = readFramebuffer->getReadColorbuffer(); if (source == nullptr) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), MissingReadAttachment); return false; } // ANGLE_multiview spec, Revision 1: // Calling CopyTexSubImage3D, CopyTexImage2D, or CopyTexSubImage2D will result in an // INVALID_FRAMEBUFFER_OPERATION error if the multi-view layout of the current read framebuffer // is not NONE. if (source->getMultiviewLayout() != GL_NONE) { context->handleError(InvalidFramebufferOperation() << "The active read framebuffer object has multiview attachments."); return false; } const gl::Caps &caps = context->getCaps(); GLuint maxDimension = 0; switch (target) { case GL_TEXTURE_2D: maxDimension = caps.max2DTextureSize; break; case GL_TEXTURE_CUBE_MAP_POSITIVE_X: case GL_TEXTURE_CUBE_MAP_NEGATIVE_X: case GL_TEXTURE_CUBE_MAP_POSITIVE_Y: case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y: case GL_TEXTURE_CUBE_MAP_POSITIVE_Z: case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z: maxDimension = caps.maxCubeMapTextureSize; break; case GL_TEXTURE_RECTANGLE_ANGLE: maxDimension = caps.maxRectangleTextureSize; break; case GL_TEXTURE_2D_ARRAY: maxDimension = caps.max2DTextureSize; break; case GL_TEXTURE_3D: maxDimension = caps.max3DTextureSize; break; default: context->handleError(InvalidEnum()); return false; } gl::Texture *texture = state.getTargetTexture(IsCubeMapTextureTarget(target) ? GL_TEXTURE_CUBE_MAP : target); if (!texture) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), TextureNotBound); return false; } if (texture->getImmutableFormat() && !isSubImage) { context->handleError(InvalidOperation()); return false; } const gl::InternalFormat &formatInfo = isSubImage ? *texture->getFormat(target, level).info : gl::GetInternalFormatInfo(internalformat, GL_UNSIGNED_BYTE); if (formatInfo.depthBits > 0 || formatInfo.compressed) { context->handleError(InvalidOperation()); return false; } if (isSubImage) { if (static_cast(xoffset + width) > texture->getWidth(target, level) || static_cast(yoffset + height) > texture->getHeight(target, level) || static_cast(zoffset) >= texture->getDepth(target, level)) { context->handleError(InvalidValue()); return false; } } else { if (IsCubeMapTextureTarget(target) && width != height) { ANGLE_VALIDATION_ERR(context, InvalidValue(), CubemapIncomplete); return false; } if (!formatInfo.textureSupport(context->getClientVersion(), context->getExtensions())) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } int maxLevelDimension = (maxDimension >> level); if (static_cast(width) > maxLevelDimension || static_cast(height) > maxLevelDimension) { ANGLE_VALIDATION_ERR(context, InvalidValue(), ResourceMaxTextureSize); return false; } } if (textureFormatOut) { *textureFormatOut = texture->getFormat(target, level); } // Detect texture copying feedback loops for WebGL. if (context->getExtensions().webglCompatibility) { if (readFramebuffer->formsCopyingFeedbackLoopWith(texture->id(), level, zoffset)) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), FeedbackLoop); return false; } } return true; } bool ValidateDrawBase(ValidationContext *context, GLenum mode, GLsizei count) { switch (mode) { case GL_POINTS: case GL_LINES: case GL_LINE_LOOP: case GL_LINE_STRIP: case GL_TRIANGLES: case GL_TRIANGLE_STRIP: case GL_TRIANGLE_FAN: break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidDrawMode); return false; } if (count < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount); return false; } const State &state = context->getGLState(); const Extensions &extensions = context->getExtensions(); // WebGL buffers cannot be mapped/unmapped because the MapBufferRange, FlushMappedBufferRange, // and UnmapBuffer entry points are removed from the WebGL 2.0 API. // https://www.khronos.org/registry/webgl/specs/latest/2.0/#5.14 if (!extensions.webglCompatibility) { // Check for mapped buffers // TODO(jmadill): Optimize this check for non - WebGL contexts. if (state.hasMappedBuffer(BufferBinding::Array)) { context->handleError(InvalidOperation()); return false; } } // Note: these separate values are not supported in WebGL, due to D3D's limitations. See // Section 6.10 of the WebGL 1.0 spec. Framebuffer *framebuffer = state.getDrawFramebuffer(); if (context->getLimitations().noSeparateStencilRefsAndMasks || extensions.webglCompatibility) { const FramebufferAttachment *dsAttachment = framebuffer->getStencilOrDepthStencilAttachment(); GLuint stencilBits = dsAttachment ? dsAttachment->getStencilSize() : 0; GLuint minimumRequiredStencilMask = (1 << stencilBits) - 1; const DepthStencilState &depthStencilState = state.getDepthStencilState(); bool differentRefs = state.getStencilRef() != state.getStencilBackRef(); bool differentWritemasks = (depthStencilState.stencilWritemask & minimumRequiredStencilMask) != (depthStencilState.stencilBackWritemask & minimumRequiredStencilMask); bool differentMasks = (depthStencilState.stencilMask & minimumRequiredStencilMask) != (depthStencilState.stencilBackMask & minimumRequiredStencilMask); if (differentRefs || differentWritemasks || differentMasks) { if (!extensions.webglCompatibility) { ERR() << "This ANGLE implementation does not support separate front/back stencil " "writemasks, reference values, or stencil mask values."; } ANGLE_VALIDATION_ERR(context, InvalidOperation(), StencilReferenceMaskOrMismatch); return false; } } if (framebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE) { context->handleError(InvalidFramebufferOperation()); return false; } gl::Program *program = state.getProgram(); if (!program) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotBound); return false; } // In OpenGL ES spec for UseProgram at section 7.3, trying to render without // vertex shader stage or fragment shader stage is a undefined behaviour. // But ANGLE should clearly generate an INVALID_OPERATION error instead of // produce undefined result. if (program->isLinked() && (!program->hasLinkedVertexShader() || !program->hasLinkedFragmentShader())) { context->handleError(InvalidOperation() << "It is a undefined behaviour to render without " "vertex shader stage or fragment shader stage."); return false; } if (!program->validateSamplers(nullptr, context->getCaps())) { context->handleError(InvalidOperation()); return false; } if (extensions.multiview) { const int programNumViews = program->usesMultiview() ? program->getNumViews() : 1; const int framebufferNumViews = framebuffer->getNumViews(); if (framebufferNumViews != programNumViews) { context->handleError(InvalidOperation() << "The number of views in the active program " "and draw framebuffer does not match."); return false; } const TransformFeedback *transformFeedbackObject = state.getCurrentTransformFeedback(); if (transformFeedbackObject != nullptr && transformFeedbackObject->isActive() && framebufferNumViews > 1) { context->handleError(InvalidOperation() << "There is an active transform feedback object " "when the number of views in the active draw " "framebuffer is greater than 1."); return false; } if (extensions.disjointTimerQuery && framebufferNumViews > 1 && state.isQueryActive(GL_TIME_ELAPSED_EXT)) { context->handleError(InvalidOperation() << "There is an active query for target " "GL_TIME_ELAPSED_EXT when the number of " "views in the active draw framebuffer is " "greater than 1."); return false; } } // Uniform buffer validation for (unsigned int uniformBlockIndex = 0; uniformBlockIndex < program->getActiveUniformBlockCount(); uniformBlockIndex++) { const gl::InterfaceBlock &uniformBlock = program->getUniformBlockByIndex(uniformBlockIndex); GLuint blockBinding = program->getUniformBlockBinding(uniformBlockIndex); const OffsetBindingPointer &uniformBuffer = state.getIndexedUniformBuffer(blockBinding); if (uniformBuffer.get() == nullptr) { // undefined behaviour context->handleError( InvalidOperation() << "It is undefined behaviour to have a used but unbound uniform buffer."); return false; } size_t uniformBufferSize = uniformBuffer.getSize(); if (uniformBufferSize == 0) { // Bind the whole buffer. uniformBufferSize = static_cast(uniformBuffer->getSize()); } if (uniformBufferSize < uniformBlock.dataSize) { // undefined behaviour context->handleError( InvalidOperation() << "It is undefined behaviour to use a uniform buffer that is too small."); return false; } } // Do some additonal WebGL-specific validation if (extensions.webglCompatibility) { // Detect rendering feedback loops for WebGL. if (framebuffer->formsRenderingFeedbackLoopWith(state)) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), FeedbackLoop); return false; } // Detect that the vertex shader input types match the attribute types if (!ValidateVertexShaderAttributeTypeMatch(context)) { return false; } // Detect that the color buffer types match the fragment shader output types if (!ValidateFragmentShaderColorBufferTypeMatch(context)) { return false; } } // No-op if zero count return (count > 0); } bool ValidateDrawArraysCommon(ValidationContext *context, GLenum mode, GLint first, GLsizei count, GLsizei primcount) { if (first < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeStart); return false; } const State &state = context->getGLState(); gl::TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback(); if (curTransformFeedback && curTransformFeedback->isActive() && !curTransformFeedback->isPaused() && curTransformFeedback->getPrimitiveMode() != mode) { // It is an invalid operation to call DrawArrays or DrawArraysInstanced with a draw mode // that does not match the current transform feedback object's draw mode (if transform // feedback // is active), (3.0.2, section 2.14, pg 86) ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidDrawModeTransformFeedback); return false; } if (!ValidateDrawBase(context, mode, count)) { return false; } // Check the computation of maxVertex doesn't overflow. // - first < 0 or count < 0 have been checked as an error condition // - count > 0 has been checked in ValidateDrawBase as it makes the call a noop // From this we know maxVertex will be positive, and only need to check if it overflows GLint. ASSERT(count > 0 && first >= 0); int64_t maxVertex = static_cast(first) + static_cast(count) - 1; if (maxVertex > static_cast(std::numeric_limits::max())) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow); return false; } if (!ValidateDrawAttribs(context, primcount, static_cast(maxVertex), count)) { return false; } return true; } bool ValidateDrawArraysInstancedANGLE(Context *context, GLenum mode, GLint first, GLsizei count, GLsizei primcount) { if (!context->getExtensions().instancedArrays) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled); return false; } if (!ValidateDrawArraysInstancedBase(context, mode, first, count, primcount)) { return false; } return ValidateDrawInstancedANGLE(context); } bool ValidateDrawElementsBase(ValidationContext *context, GLenum type) { switch (type) { case GL_UNSIGNED_BYTE: case GL_UNSIGNED_SHORT: break; case GL_UNSIGNED_INT: if (context->getClientMajorVersion() < 3 && !context->getExtensions().elementIndexUint) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), TypeNotUnsignedShortByte); return false; } break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), TypeNotUnsignedShortByte); return false; } const State &state = context->getGLState(); gl::TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback(); if (curTransformFeedback && curTransformFeedback->isActive() && !curTransformFeedback->isPaused()) { // It is an invalid operation to call DrawElements, DrawRangeElements or // DrawElementsInstanced // while transform feedback is active, (3.0.2, section 2.14, pg 86) context->handleError(InvalidOperation()); return false; } return true; } bool ValidateDrawElementsCommon(ValidationContext *context, GLenum mode, GLsizei count, GLenum type, const void *indices, GLsizei primcount) { if (!ValidateDrawElementsBase(context, type)) return false; const State &state = context->getGLState(); if (!ValidateDrawBase(context, mode, count)) { return false; } // WebGL buffers cannot be mapped/unmapped because the MapBufferRange, FlushMappedBufferRange, // and UnmapBuffer entry points are removed from the WebGL 2.0 API. // https://www.khronos.org/registry/webgl/specs/latest/2.0/#5.14 if (!context->getExtensions().webglCompatibility) { // Check for mapped buffers // TODO(jmadill): Optimize this check for non - WebGL contexts. if (state.hasMappedBuffer(gl::BufferBinding::ElementArray)) { context->handleError(InvalidOperation() << "Index buffer is mapped."); return false; } } const gl::VertexArray *vao = state.getVertexArray(); gl::Buffer *elementArrayBuffer = vao->getElementArrayBuffer().get(); GLuint typeBytes = gl::GetTypeInfo(type).bytes; if (context->getExtensions().webglCompatibility) { ASSERT(isPow2(typeBytes) && typeBytes > 0); if ((reinterpret_cast(indices) & static_cast(typeBytes - 1)) != 0) { // [WebGL 1.0] Section 6.4 Buffer Offset and Stride Requirements // The offset arguments to drawElements and [...], must be a multiple of the size of the // data type passed to the call, or an INVALID_OPERATION error is generated. ANGLE_VALIDATION_ERR(context, InvalidOperation(), OffsetMustBeMultipleOfType); return false; } // [WebGL 1.0] Section 6.4 Buffer Offset and Stride Requirements // In addition the offset argument to drawElements must be non-negative or an INVALID_VALUE // error is generated. if (reinterpret_cast(indices) < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset); return false; } } if (context->getExtensions().webglCompatibility || !context->getGLState().areClientArraysEnabled()) { if (!elementArrayBuffer && count > 0) { // [WebGL 1.0] Section 6.2 No Client Side Arrays // If drawElements is called with a count greater than zero, and no WebGLBuffer is bound // to the ELEMENT_ARRAY_BUFFER binding point, an INVALID_OPERATION error is generated. ANGLE_VALIDATION_ERR(context, InvalidOperation(), MustHaveElementArrayBinding); return false; } } if (count > 0) { if (elementArrayBuffer) { // The max possible type size is 8 and count is on 32 bits so doing the multiplication // in a 64 bit integer is safe. Also we are guaranteed that here count > 0. static_assert(std::is_same::value, "GLsizei isn't the expected type"); constexpr uint64_t kMaxTypeSize = 8; constexpr uint64_t kIntMax = std::numeric_limits::max(); constexpr uint64_t kUint64Max = std::numeric_limits::max(); static_assert(kIntMax < kUint64Max / kMaxTypeSize, ""); uint64_t typeSize = typeBytes; uint64_t elementCount = static_cast(count); ASSERT(elementCount > 0 && typeSize <= kMaxTypeSize); // Doing the multiplication here is overflow-safe uint64_t elementDataSizeNoOffset = typeSize * elementCount; // The offset can be any value, check for overflows uint64_t offset = static_cast(reinterpret_cast(indices)); if (elementDataSizeNoOffset > kUint64Max - offset) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow); return false; } uint64_t elementDataSizeWithOffset = elementDataSizeNoOffset + offset; if (elementDataSizeWithOffset > static_cast(elementArrayBuffer->getSize())) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize); return false; } ASSERT(isPow2(typeSize) && typeSize > 0); if ((elementArrayBuffer->getSize() & (typeSize - 1)) != 0) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), MismatchedByteCountType); return false; } } else if (!indices) { // This is an application error that would normally result in a crash, // but we catch it and return an error context->handleError(InvalidOperation() << "No element array buffer and no pointer."); return false; } } if (context->getExtensions().robustBufferAccessBehavior) { // Here we use maxVertex = 0 and vertexCount = 1 to avoid retrieving IndexRange when robust // access is enabled. if (!ValidateDrawAttribs(context, primcount, 0, 1)) { return false; } } else { // Use the parameter buffer to retrieve and cache the index range. const auto ¶ms = context->getParams(); const auto &indexRangeOpt = params.getIndexRange(); if (!indexRangeOpt.valid()) { // Unexpected error. return false; } // If we use an index greater than our maximum supported index range, return an error. // The ES3 spec does not specify behaviour here, it is undefined, but ANGLE should always // return an error if possible here. if (static_cast(indexRangeOpt.value().end) >= context->getCaps().maxElementIndex) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExceedsMaxElement); return false; } if (!ValidateDrawAttribs(context, primcount, static_cast(indexRangeOpt.value().end), static_cast(indexRangeOpt.value().vertexCount()))) { return false; } // No op if there are no real indices in the index data (all are primitive restart). return (indexRangeOpt.value().vertexIndexCount > 0); } return true; } bool ValidateDrawElementsInstancedCommon(ValidationContext *context, GLenum mode, GLsizei count, GLenum type, const void *indices, GLsizei primcount) { return ValidateDrawElementsInstancedBase(context, mode, count, type, indices, primcount); } bool ValidateDrawElementsInstancedANGLE(Context *context, GLenum mode, GLsizei count, GLenum type, const void *indices, GLsizei primcount) { if (!context->getExtensions().instancedArrays) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled); return false; } if (!ValidateDrawElementsInstancedBase(context, mode, count, type, indices, primcount)) { return false; } return ValidateDrawInstancedANGLE(context); } bool ValidateFramebufferTextureBase(Context *context, GLenum target, GLenum attachment, GLuint texture, GLint level) { if (!ValidFramebufferTarget(context, target)) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidFramebufferTarget); return false; } if (!ValidateAttachmentTarget(context, attachment)) { return false; } if (texture != 0) { gl::Texture *tex = context->getTexture(texture); if (tex == NULL) { context->handleError(InvalidOperation()); return false; } if (level < 0) { context->handleError(InvalidValue()); return false; } } const gl::Framebuffer *framebuffer = context->getGLState().getTargetFramebuffer(target); ASSERT(framebuffer); if (framebuffer->id() == 0) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), DefaultFramebufferTarget); return false; } return true; } bool ValidateGetUniformBase(Context *context, GLuint program, GLint location) { if (program == 0) { context->handleError(InvalidValue()); return false; } gl::Program *programObject = GetValidProgram(context, program); if (!programObject) { return false; } if (!programObject || !programObject->isLinked()) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked); return false; } if (!programObject->isValidUniformLocation(location)) { context->handleError(InvalidOperation()); return false; } return true; } static bool ValidateSizedGetUniform(Context *context, GLuint program, GLint location, GLsizei bufSize, GLsizei *length) { if (length) { *length = 0; } if (!ValidateGetUniformBase(context, program, location)) { return false; } if (bufSize < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeBufferSize); return false; } gl::Program *programObject = context->getProgram(program); ASSERT(programObject); // sized queries -- ensure the provided buffer is large enough const LinkedUniform &uniform = programObject->getUniformByLocation(location); size_t requiredBytes = VariableExternalSize(uniform.type); if (static_cast(bufSize) < requiredBytes) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize); return false; } if (length) { *length = VariableComponentCount(uniform.type); } return true; } bool ValidateGetnUniformfvEXT(Context *context, GLuint program, GLint location, GLsizei bufSize, GLfloat *params) { return ValidateSizedGetUniform(context, program, location, bufSize, nullptr); } bool ValidateGetnUniformivEXT(Context *context, GLuint program, GLint location, GLsizei bufSize, GLint *params) { return ValidateSizedGetUniform(context, program, location, bufSize, nullptr); } bool ValidateGetUniformfvRobustANGLE(Context *context, GLuint program, GLint location, GLsizei bufSize, GLsizei *length, GLfloat *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } // bufSize is validated in ValidateSizedGetUniform return ValidateSizedGetUniform(context, program, location, bufSize, length); } bool ValidateGetUniformivRobustANGLE(Context *context, GLuint program, GLint location, GLsizei bufSize, GLsizei *length, GLint *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } // bufSize is validated in ValidateSizedGetUniform return ValidateSizedGetUniform(context, program, location, bufSize, length); } bool ValidateGetUniformuivRobustANGLE(Context *context, GLuint program, GLint location, GLsizei bufSize, GLsizei *length, GLuint *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (context->getClientMajorVersion() < 3) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); return false; } // bufSize is validated in ValidateSizedGetUniform return ValidateSizedGetUniform(context, program, location, bufSize, length); } bool ValidateDiscardFramebufferBase(Context *context, GLenum target, GLsizei numAttachments, const GLenum *attachments, bool defaultFramebuffer) { if (numAttachments < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeAttachments); return false; } for (GLsizei i = 0; i < numAttachments; ++i) { if (attachments[i] >= GL_COLOR_ATTACHMENT0 && attachments[i] <= GL_COLOR_ATTACHMENT31) { if (defaultFramebuffer) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), DefaultFramebufferInvalidAttachment); return false; } if (attachments[i] >= GL_COLOR_ATTACHMENT0 + context->getCaps().maxColorAttachments) { context->handleError(InvalidOperation() << "Requested color attachment is " "greater than the maximum supported " "color attachments"); return false; } } else { switch (attachments[i]) { case GL_DEPTH_ATTACHMENT: case GL_STENCIL_ATTACHMENT: case GL_DEPTH_STENCIL_ATTACHMENT: if (defaultFramebuffer) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), DefaultFramebufferInvalidAttachment); return false; } break; case GL_COLOR: case GL_DEPTH: case GL_STENCIL: if (!defaultFramebuffer) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), DefaultFramebufferInvalidAttachment); return false; } break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidAttachment); return false; } } } return true; } bool ValidateInsertEventMarkerEXT(Context *context, GLsizei length, const char *marker) { // Note that debug marker calls must not set error state if (length < 0) { return false; } if (marker == nullptr) { return false; } return true; } bool ValidatePushGroupMarkerEXT(Context *context, GLsizei length, const char *marker) { // Note that debug marker calls must not set error state if (length < 0) { return false; } if (length > 0 && marker == nullptr) { return false; } return true; } bool ValidateEGLImageTargetTexture2DOES(Context *context, GLenum target, egl::Image *image) { if (!context->getExtensions().eglImage && !context->getExtensions().eglImageExternal) { context->handleError(InvalidOperation()); return false; } switch (target) { case GL_TEXTURE_2D: if (!context->getExtensions().eglImage) { context->handleError(InvalidEnum() << "GL_TEXTURE_2D texture target requires GL_OES_EGL_image."); } break; case GL_TEXTURE_EXTERNAL_OES: if (!context->getExtensions().eglImageExternal) { context->handleError(InvalidEnum() << "GL_TEXTURE_EXTERNAL_OES texture target " "requires GL_OES_EGL_image_external."); } break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureTarget); return false; } ASSERT(context->getCurrentDisplay()); if (!context->getCurrentDisplay()->isValidImage(image)) { context->handleError(InvalidValue() << "EGL image is not valid."); return false; } if (image->getSamples() > 0) { context->handleError(InvalidOperation() << "cannot create a 2D texture from a multisampled EGL image."); return false; } const TextureCaps &textureCaps = context->getTextureCaps().get(image->getFormat().info->sizedInternalFormat); if (!textureCaps.texturable) { context->handleError(InvalidOperation() << "EGL image internal format is not supported as a texture."); return false; } return true; } bool ValidateEGLImageTargetRenderbufferStorageOES(Context *context, GLenum target, egl::Image *image) { if (!context->getExtensions().eglImage) { context->handleError(InvalidOperation()); return false; } switch (target) { case GL_RENDERBUFFER: break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferTarget); return false; } ASSERT(context->getCurrentDisplay()); if (!context->getCurrentDisplay()->isValidImage(image)) { context->handleError(InvalidValue() << "EGL image is not valid."); return false; } const TextureCaps &textureCaps = context->getTextureCaps().get(image->getFormat().info->sizedInternalFormat); if (!textureCaps.renderable) { context->handleError(InvalidOperation() << "EGL image internal format is not supported as a renderbuffer."); return false; } return true; } bool ValidateBindVertexArrayBase(Context *context, GLuint array) { if (!context->isVertexArrayGenerated(array)) { // The default VAO should always exist ASSERT(array != 0); context->handleError(InvalidOperation()); return false; } return true; } bool ValidateProgramBinaryBase(Context *context, GLuint program, GLenum binaryFormat, const void *binary, GLint length) { Program *programObject = GetValidProgram(context, program); if (programObject == nullptr) { return false; } const std::vector &programBinaryFormats = context->getCaps().programBinaryFormats; if (std::find(programBinaryFormats.begin(), programBinaryFormats.end(), binaryFormat) == programBinaryFormats.end()) { context->handleError(InvalidEnum() << "Program binary format is not valid."); return false; } if (context->hasActiveTransformFeedback(program)) { // ES 3.0.4 section 2.15 page 91 context->handleError(InvalidOperation() << "Cannot change program binary while program " "is associated with an active transform " "feedback object."); return false; } return true; } bool ValidateGetProgramBinaryBase(Context *context, GLuint program, GLsizei bufSize, GLsizei *length, GLenum *binaryFormat, void *binary) { Program *programObject = GetValidProgram(context, program); if (programObject == nullptr) { return false; } if (!programObject->isLinked()) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked); return false; } if (context->getCaps().programBinaryFormats.empty()) { context->handleError(InvalidOperation() << "No program binary formats supported."); return false; } return true; } bool ValidateDrawBuffersBase(ValidationContext *context, GLsizei n, const GLenum *bufs) { // INVALID_VALUE is generated if n is negative or greater than value of MAX_DRAW_BUFFERS if (n < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount); return false; } if (static_cast(n) > context->getCaps().maxDrawBuffers) { ANGLE_VALIDATION_ERR(context, InvalidValue(), IndexExceedsMaxDrawBuffer); return false; } ASSERT(context->getGLState().getDrawFramebuffer()); GLuint frameBufferId = context->getGLState().getDrawFramebuffer()->id(); GLuint maxColorAttachment = GL_COLOR_ATTACHMENT0_EXT + context->getCaps().maxColorAttachments; // This should come first before the check for the default frame buffer // because when we switch to ES3.1+, invalid enums will return INVALID_ENUM // rather than INVALID_OPERATION for (int colorAttachment = 0; colorAttachment < n; colorAttachment++) { const GLenum attachment = GL_COLOR_ATTACHMENT0_EXT + colorAttachment; if (bufs[colorAttachment] != GL_NONE && bufs[colorAttachment] != GL_BACK && (bufs[colorAttachment] < GL_COLOR_ATTACHMENT0 || bufs[colorAttachment] > GL_COLOR_ATTACHMENT31)) { // Value in bufs is not NONE, BACK, or GL_COLOR_ATTACHMENTi // The 3.0.4 spec says to generate GL_INVALID_OPERATION here, but this // was changed to GL_INVALID_ENUM in 3.1, which dEQP also expects. // 3.1 is still a bit ambiguous about the error, but future specs are // expected to clarify that GL_INVALID_ENUM is the correct error. context->handleError(InvalidEnum() << "Invalid buffer value"); return false; } else if (bufs[colorAttachment] >= maxColorAttachment) { context->handleError(InvalidOperation() << "Buffer value is greater than MAX_DRAW_BUFFERS"); return false; } else if (bufs[colorAttachment] != GL_NONE && bufs[colorAttachment] != attachment && frameBufferId != 0) { // INVALID_OPERATION-GL is bound to buffer and ith argument // is not COLOR_ATTACHMENTi or NONE context->handleError(InvalidOperation() << "Ith value does not match COLOR_ATTACHMENTi or NONE"); return false; } } // INVALID_OPERATION is generated if GL is bound to the default framebuffer // and n is not 1 or bufs is bound to value other than BACK and NONE if (frameBufferId == 0) { if (n != 1) { context->handleError(InvalidOperation() << "n must be 1 when GL is bound to the default framebuffer"); return false; } if (bufs[0] != GL_NONE && bufs[0] != GL_BACK) { context->handleError( InvalidOperation() << "Only NONE or BACK are valid values when drawing to the default framebuffer"); return false; } } return true; } bool ValidateGetBufferPointervBase(Context *context, BufferBinding target, GLenum pname, GLsizei *length, void **params) { if (length) { *length = 0; } if (context->getClientMajorVersion() < 3 && !context->getExtensions().mapBuffer) { context->handleError( InvalidOperation() << "Context does not support OpenGL ES 3.0 or GL_OES_mapbuffer is not enabled."); return false; } if (!ValidBufferType(context, target)) { context->handleError(InvalidEnum() << "Buffer target not valid"); return false; } switch (pname) { case GL_BUFFER_MAP_POINTER: break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } // GLES 3.0 section 2.10.1: "Attempts to attempts to modify or query buffer object state for a // target bound to zero generate an INVALID_OPERATION error." // GLES 3.1 section 6.6 explicitly specifies this error. if (context->getGLState().getTargetBuffer(target) == nullptr) { context->handleError(InvalidOperation() << "Can not get pointer for reserved buffer name zero."); return false; } if (length) { *length = 1; } return true; } bool ValidateUnmapBufferBase(Context *context, BufferBinding target) { if (!ValidBufferType(context, target)) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes); return false; } Buffer *buffer = context->getGLState().getTargetBuffer(target); if (buffer == nullptr || !buffer->isMapped()) { context->handleError(InvalidOperation() << "Buffer not mapped."); return false; } return true; } bool ValidateMapBufferRangeBase(Context *context, BufferBinding target, GLintptr offset, GLsizeiptr length, GLbitfield access) { if (!ValidBufferType(context, target)) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes); return false; } if (offset < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset); return false; } if (length < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeLength); return false; } Buffer *buffer = context->getGLState().getTargetBuffer(target); if (!buffer) { context->handleError(InvalidOperation() << "Attempted to map buffer object zero."); return false; } // Check for buffer overflow CheckedNumeric checkedOffset(offset); auto checkedSize = checkedOffset + length; if (!checkedSize.IsValid() || checkedSize.ValueOrDie() > static_cast(buffer->getSize())) { context->handleError(InvalidValue() << "Mapped range does not fit into buffer dimensions."); return false; } // Check for invalid bits in the mask GLbitfield allAccessBits = GL_MAP_READ_BIT | GL_MAP_WRITE_BIT | GL_MAP_INVALIDATE_RANGE_BIT | GL_MAP_INVALIDATE_BUFFER_BIT | GL_MAP_FLUSH_EXPLICIT_BIT | GL_MAP_UNSYNCHRONIZED_BIT; if (access & ~(allAccessBits)) { context->handleError(InvalidValue() << "Invalid access bits: 0x" << std::hex << std::uppercase << access); return false; } if (length == 0) { context->handleError(InvalidOperation() << "Buffer mapping length is zero."); return false; } if (buffer->isMapped()) { context->handleError(InvalidOperation() << "Buffer is already mapped."); return false; } // Check for invalid bit combinations if ((access & (GL_MAP_READ_BIT | GL_MAP_WRITE_BIT)) == 0) { context->handleError(InvalidOperation() << "Need to map buffer for either reading or writing."); return false; } GLbitfield writeOnlyBits = GL_MAP_INVALIDATE_RANGE_BIT | GL_MAP_INVALIDATE_BUFFER_BIT | GL_MAP_UNSYNCHRONIZED_BIT; if ((access & GL_MAP_READ_BIT) != 0 && (access & writeOnlyBits) != 0) { context->handleError(InvalidOperation() << "Invalid access bits when mapping buffer for reading: 0x" << std::hex << std::uppercase << access); return false; } if ((access & GL_MAP_WRITE_BIT) == 0 && (access & GL_MAP_FLUSH_EXPLICIT_BIT) != 0) { context->handleError( InvalidOperation() << "The explicit flushing bit may only be set if the buffer is mapped for writing."); return false; } return ValidateMapBufferBase(context, target); } bool ValidateFlushMappedBufferRangeBase(Context *context, BufferBinding target, GLintptr offset, GLsizeiptr length) { if (offset < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset); return false; } if (length < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeLength); return false; } if (!ValidBufferType(context, target)) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes); return false; } Buffer *buffer = context->getGLState().getTargetBuffer(target); if (buffer == nullptr) { context->handleError(InvalidOperation() << "Attempted to flush buffer object zero."); return false; } if (!buffer->isMapped() || (buffer->getAccessFlags() & GL_MAP_FLUSH_EXPLICIT_BIT) == 0) { context->handleError(InvalidOperation() << "Attempted to flush a buffer not mapped for explicit flushing."); return false; } // Check for buffer overflow CheckedNumeric checkedOffset(offset); auto checkedSize = checkedOffset + length; if (!checkedSize.IsValid() || checkedSize.ValueOrDie() > static_cast(buffer->getMapLength())) { context->handleError(InvalidValue() << "Flushed range does not fit into buffer mapping dimensions."); return false; } return true; } bool ValidateGenOrDelete(Context *context, GLint n) { if (n < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount); return false; } return true; } bool ValidateRobustEntryPoint(ValidationContext *context, GLsizei bufSize) { if (!context->getExtensions().robustClientMemory) { context->handleError(InvalidOperation() << "GL_ANGLE_robust_client_memory is not available."); return false; } if (bufSize < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeBufferSize); return false; } return true; } bool ValidateRobustBufferSize(ValidationContext *context, GLsizei bufSize, GLsizei numParams) { if (bufSize < numParams) { context->handleError(InvalidOperation() << numParams << " parameters are required but " << bufSize << " were provided."); return false; } return true; } bool ValidateGetFramebufferAttachmentParameterivBase(ValidationContext *context, GLenum target, GLenum attachment, GLenum pname, GLsizei *numParams) { if (!ValidFramebufferTarget(context, target)) { context->handleError(InvalidEnum()); return false; } int clientVersion = context->getClientMajorVersion(); switch (pname) { case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE: case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME: case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LEVEL: case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_CUBE_MAP_FACE: break; case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_NUM_VIEWS_ANGLE: case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_MULTIVIEW_LAYOUT_ANGLE: case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_BASE_VIEW_INDEX_ANGLE: case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_VIEWPORT_OFFSETS_ANGLE: if (clientVersion < 3 || !context->getExtensions().multiview) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } break; case GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING: if (clientVersion < 3 && !context->getExtensions().sRGB) { context->handleError(InvalidEnum()); return false; } break; case GL_FRAMEBUFFER_ATTACHMENT_RED_SIZE: case GL_FRAMEBUFFER_ATTACHMENT_GREEN_SIZE: case GL_FRAMEBUFFER_ATTACHMENT_BLUE_SIZE: case GL_FRAMEBUFFER_ATTACHMENT_ALPHA_SIZE: case GL_FRAMEBUFFER_ATTACHMENT_DEPTH_SIZE: case GL_FRAMEBUFFER_ATTACHMENT_STENCIL_SIZE: case GL_FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE: case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LAYER: if (clientVersion < 3) { context->handleError(InvalidEnum()); return false; } break; default: context->handleError(InvalidEnum()); return false; } // Determine if the attachment is a valid enum switch (attachment) { case GL_BACK: case GL_DEPTH: case GL_STENCIL: if (clientVersion < 3) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidAttachment); return false; } break; case GL_DEPTH_STENCIL_ATTACHMENT: if (clientVersion < 3 && !context->isWebGL1()) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidAttachment); return false; } break; case GL_COLOR_ATTACHMENT0: case GL_DEPTH_ATTACHMENT: case GL_STENCIL_ATTACHMENT: break; default: if ((clientVersion < 3 && !context->getExtensions().drawBuffers) || attachment < GL_COLOR_ATTACHMENT0_EXT || (attachment - GL_COLOR_ATTACHMENT0_EXT) >= context->getCaps().maxColorAttachments) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidAttachment); return false; } break; } const Framebuffer *framebuffer = context->getGLState().getTargetFramebuffer(target); ASSERT(framebuffer); if (framebuffer->id() == 0) { if (clientVersion < 3) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), DefaultFramebufferTarget); return false; } switch (attachment) { case GL_BACK: case GL_DEPTH: case GL_STENCIL: break; default: ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidAttachment); return false; } } else { if (attachment >= GL_COLOR_ATTACHMENT0_EXT && attachment <= GL_COLOR_ATTACHMENT15_EXT) { // Valid attachment query } else { switch (attachment) { case GL_DEPTH_ATTACHMENT: case GL_STENCIL_ATTACHMENT: break; case GL_DEPTH_STENCIL_ATTACHMENT: if (!framebuffer->hasValidDepthStencil() && !context->isWebGL1()) { context->handleError(InvalidOperation()); return false; } break; default: ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidAttachment); return false; } } } const FramebufferAttachment *attachmentObject = framebuffer->getAttachment(attachment); if (attachmentObject) { ASSERT(attachmentObject->type() == GL_RENDERBUFFER || attachmentObject->type() == GL_TEXTURE || attachmentObject->type() == GL_FRAMEBUFFER_DEFAULT); switch (pname) { case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME: if (attachmentObject->type() != GL_RENDERBUFFER && attachmentObject->type() != GL_TEXTURE) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment); return false; } break; case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LEVEL: if (attachmentObject->type() != GL_TEXTURE) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment); return false; } break; case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_CUBE_MAP_FACE: if (attachmentObject->type() != GL_TEXTURE) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment); return false; } break; case GL_FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE: if (attachment == GL_DEPTH_STENCIL_ATTACHMENT) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidAttachment); return false; } break; case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LAYER: if (attachmentObject->type() != GL_TEXTURE) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment); return false; } break; default: break; } } else { // ES 2.0.25 spec pg 127 states that if the value of FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE // is NONE, then querying any other pname will generate INVALID_ENUM. // ES 3.0.2 spec pg 235 states that if the attachment type is none, // GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME will return zero and be an // INVALID_OPERATION for all other pnames switch (pname) { case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE: break; case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME: if (clientVersion < 3) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidFramebufferAttachmentParameter); return false; } break; default: if (clientVersion < 3) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidFramebufferAttachmentParameter); return false; } else { ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidFramebufferAttachmentParameter); return false; } } } if (numParams) { if (pname == GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_VIEWPORT_OFFSETS_ANGLE) { // Only when the viewport offsets are queried we can have a varying number of output // parameters. const int numViews = attachmentObject ? attachmentObject->getNumViews() : 1; *numParams = numViews * 2; } else { // For all other queries we can have only one output parameter. *numParams = 1; } } return true; } bool ValidateGetFramebufferAttachmentParameterivRobustANGLE(ValidationContext *context, GLenum target, GLenum attachment, GLenum pname, GLsizei bufSize, GLsizei *numParams) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetFramebufferAttachmentParameterivBase(context, target, attachment, pname, numParams)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *numParams)) { return false; } return true; } bool ValidateGetBufferParameterivRobustANGLE(ValidationContext *context, BufferBinding target, GLenum pname, GLsizei bufSize, GLsizei *length, GLint *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetBufferParameterBase(context, target, pname, false, length)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateGetBufferParameteri64vRobustANGLE(ValidationContext *context, BufferBinding target, GLenum pname, GLsizei bufSize, GLsizei *length, GLint64 *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetBufferParameterBase(context, target, pname, false, length)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateGetProgramivBase(ValidationContext *context, GLuint program, GLenum pname, GLsizei *numParams) { // Currently, all GetProgramiv queries return 1 parameter if (numParams) { *numParams = 1; } Program *programObject = GetValidProgram(context, program); if (!programObject) { return false; } switch (pname) { case GL_DELETE_STATUS: case GL_LINK_STATUS: case GL_VALIDATE_STATUS: case GL_INFO_LOG_LENGTH: case GL_ATTACHED_SHADERS: case GL_ACTIVE_ATTRIBUTES: case GL_ACTIVE_ATTRIBUTE_MAX_LENGTH: case GL_ACTIVE_UNIFORMS: case GL_ACTIVE_UNIFORM_MAX_LENGTH: break; case GL_PROGRAM_BINARY_LENGTH: if (context->getClientMajorVersion() < 3 && !context->getExtensions().getProgramBinary) { context->handleError(InvalidEnum() << "Querying GL_PROGRAM_BINARY_LENGTH " "requires GL_OES_get_program_binary or " "ES 3.0."); return false; } break; case GL_ACTIVE_UNIFORM_BLOCKS: case GL_ACTIVE_UNIFORM_BLOCK_MAX_NAME_LENGTH: case GL_TRANSFORM_FEEDBACK_BUFFER_MODE: case GL_TRANSFORM_FEEDBACK_VARYINGS: case GL_TRANSFORM_FEEDBACK_VARYING_MAX_LENGTH: case GL_PROGRAM_BINARY_RETRIEVABLE_HINT: if (context->getClientMajorVersion() < 3) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), ES3Required); return false; } break; case GL_PROGRAM_SEPARABLE: case GL_COMPUTE_WORK_GROUP_SIZE: case GL_ACTIVE_ATOMIC_COUNTER_BUFFERS: if (context->getClientVersion() < Version(3, 1)) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), ES31Required); return false; } break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } return true; } bool ValidateGetProgramivRobustANGLE(Context *context, GLuint program, GLenum pname, GLsizei bufSize, GLsizei *numParams) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetProgramivBase(context, program, pname, numParams)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *numParams)) { return false; } return true; } bool ValidateGetRenderbufferParameterivRobustANGLE(Context *context, GLenum target, GLenum pname, GLsizei bufSize, GLsizei *length, GLint *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetRenderbufferParameterivBase(context, target, pname, length)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateGetShaderivRobustANGLE(Context *context, GLuint shader, GLenum pname, GLsizei bufSize, GLsizei *length, GLint *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetShaderivBase(context, shader, pname, length)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateGetTexParameterfvRobustANGLE(Context *context, GLenum target, GLenum pname, GLsizei bufSize, GLsizei *length, GLfloat *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetTexParameterBase(context, target, pname, length)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateGetTexParameterivRobustANGLE(Context *context, GLenum target, GLenum pname, GLsizei bufSize, GLsizei *length, GLint *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetTexParameterBase(context, target, pname, length)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateTexParameterfvRobustANGLE(Context *context, GLenum target, GLenum pname, GLsizei bufSize, const GLfloat *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } return ValidateTexParameterBase(context, target, pname, bufSize, params); } bool ValidateTexParameterivRobustANGLE(Context *context, GLenum target, GLenum pname, GLsizei bufSize, const GLint *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } return ValidateTexParameterBase(context, target, pname, bufSize, params); } bool ValidateGetSamplerParameterfvRobustANGLE(Context *context, GLuint sampler, GLenum pname, GLuint bufSize, GLsizei *length, GLfloat *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetSamplerParameterBase(context, sampler, pname, length)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateGetSamplerParameterivRobustANGLE(Context *context, GLuint sampler, GLenum pname, GLuint bufSize, GLsizei *length, GLint *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetSamplerParameterBase(context, sampler, pname, length)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateSamplerParameterfvRobustANGLE(Context *context, GLuint sampler, GLenum pname, GLsizei bufSize, const GLfloat *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } return ValidateSamplerParameterBase(context, sampler, pname, bufSize, params); } bool ValidateSamplerParameterivRobustANGLE(Context *context, GLuint sampler, GLenum pname, GLsizei bufSize, const GLint *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } return ValidateSamplerParameterBase(context, sampler, pname, bufSize, params); } bool ValidateGetVertexAttribfvRobustANGLE(Context *context, GLuint index, GLenum pname, GLsizei bufSize, GLsizei *length, GLfloat *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetVertexAttribBase(context, index, pname, length, false, false)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateGetVertexAttribivRobustANGLE(Context *context, GLuint index, GLenum pname, GLsizei bufSize, GLsizei *length, GLint *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetVertexAttribBase(context, index, pname, length, false, false)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateGetVertexAttribPointervRobustANGLE(Context *context, GLuint index, GLenum pname, GLsizei bufSize, GLsizei *length, void **pointer) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetVertexAttribBase(context, index, pname, length, true, false)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateGetVertexAttribIivRobustANGLE(Context *context, GLuint index, GLenum pname, GLsizei bufSize, GLsizei *length, GLint *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetVertexAttribBase(context, index, pname, length, false, true)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateGetVertexAttribIuivRobustANGLE(Context *context, GLuint index, GLenum pname, GLsizei bufSize, GLsizei *length, GLuint *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetVertexAttribBase(context, index, pname, length, false, true)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateGetActiveUniformBlockivRobustANGLE(Context *context, GLuint program, GLuint uniformBlockIndex, GLenum pname, GLsizei bufSize, GLsizei *length, GLint *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetActiveUniformBlockivBase(context, program, uniformBlockIndex, pname, length)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateGetInternalFormativRobustANGLE(Context *context, GLenum target, GLenum internalformat, GLenum pname, GLsizei bufSize, GLsizei *length, GLint *params) { if (!ValidateRobustEntryPoint(context, bufSize)) { return false; } if (!ValidateGetInternalFormativBase(context, target, internalformat, pname, bufSize, length)) { return false; } if (!ValidateRobustBufferSize(context, bufSize, *length)) { return false; } return true; } bool ValidateVertexFormatBase(ValidationContext *context, GLuint attribIndex, GLint size, GLenum type, GLboolean pureInteger) { const Caps &caps = context->getCaps(); if (attribIndex >= caps.maxVertexAttributes) { ANGLE_VALIDATION_ERR(context, InvalidValue(), IndexExceedsMaxVertexAttribute); return false; } if (size < 1 || size > 4) { ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidVertexAttrSize); return false; } switch (type) { case GL_BYTE: case GL_UNSIGNED_BYTE: case GL_SHORT: case GL_UNSIGNED_SHORT: break; case GL_INT: case GL_UNSIGNED_INT: if (context->getClientMajorVersion() < 3) { context->handleError(InvalidEnum() << "Vertex type not supported before OpenGL ES 3.0."); return false; } break; case GL_FIXED: case GL_FLOAT: if (pureInteger) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTypePureInt); return false; } break; case GL_HALF_FLOAT: if (context->getClientMajorVersion() < 3) { context->handleError(InvalidEnum() << "Vertex type not supported before OpenGL ES 3.0."); return false; } if (pureInteger) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTypePureInt); return false; } break; case GL_INT_2_10_10_10_REV: case GL_UNSIGNED_INT_2_10_10_10_REV: if (context->getClientMajorVersion() < 3) { context->handleError(InvalidEnum() << "Vertex type not supported before OpenGL ES 3.0."); return false; } if (pureInteger) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTypePureInt); return false; } if (size != 4) { context->handleError(InvalidOperation() << "Type is INT_2_10_10_10_REV or " "UNSIGNED_INT_2_10_10_10_REV and " "size is not 4."); return false; } break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidType); return false; } return true; } // Perform validation from WebGL 2 section 5.10 "Invalid Clears": // In the WebGL 2 API, trying to perform a clear when there is a mismatch between the type of the // specified clear value and the type of a buffer that is being cleared generates an // INVALID_OPERATION error instead of producing undefined results bool ValidateWebGLFramebufferAttachmentClearType(ValidationContext *context, GLint drawbuffer, const GLenum *validComponentTypes, size_t validComponentTypeCount) { const FramebufferAttachment *attachment = context->getGLState().getDrawFramebuffer()->getDrawBuffer(drawbuffer); if (attachment) { GLenum componentType = attachment->getFormat().info->componentType; const GLenum *end = validComponentTypes + validComponentTypeCount; if (std::find(validComponentTypes, end, componentType) == end) { context->handleError( InvalidOperation() << "No defined conversion between clear value and attachment format."); return false; } } return true; } bool ValidateRobustCompressedTexImageBase(ValidationContext *context, GLsizei imageSize, GLsizei dataSize) { if (!ValidateRobustEntryPoint(context, dataSize)) { return false; } gl::Buffer *pixelUnpackBuffer = context->getGLState().getTargetBuffer(BufferBinding::PixelUnpack); if (pixelUnpackBuffer == nullptr) { if (dataSize < imageSize) { context->handleError(InvalidOperation() << "dataSize must be at least " << imageSize); } } return true; } bool ValidateGetBufferParameterBase(ValidationContext *context, BufferBinding target, GLenum pname, bool pointerVersion, GLsizei *numParams) { if (numParams) { *numParams = 0; } if (!ValidBufferType(context, target)) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes); return false; } const Buffer *buffer = context->getGLState().getTargetBuffer(target); if (!buffer) { // A null buffer means that "0" is bound to the requested buffer target ANGLE_VALIDATION_ERR(context, InvalidOperation(), BufferNotBound); return false; } const Extensions &extensions = context->getExtensions(); switch (pname) { case GL_BUFFER_USAGE: case GL_BUFFER_SIZE: break; case GL_BUFFER_ACCESS_OES: if (!extensions.mapBuffer) { context->handleError(InvalidEnum() << "pname requires OpenGL ES 3.0 or GL_OES_mapbuffer."); return false; } break; case GL_BUFFER_MAPPED: static_assert(GL_BUFFER_MAPPED == GL_BUFFER_MAPPED_OES, "GL enums should be equal."); if (context->getClientMajorVersion() < 3 && !extensions.mapBuffer && !extensions.mapBufferRange) { context->handleError(InvalidEnum() << "pname requires OpenGL ES 3.0, " "GL_OES_mapbuffer or " "GL_EXT_map_buffer_range."); return false; } break; case GL_BUFFER_MAP_POINTER: if (!pointerVersion) { context->handleError( InvalidEnum() << "GL_BUFFER_MAP_POINTER can only be queried with GetBufferPointerv."); return false; } break; case GL_BUFFER_ACCESS_FLAGS: case GL_BUFFER_MAP_OFFSET: case GL_BUFFER_MAP_LENGTH: if (context->getClientMajorVersion() < 3 && !extensions.mapBufferRange) { context->handleError(InvalidEnum() << "pname requires OpenGL ES 3.0 or GL_EXT_map_buffer_range."); return false; } break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } // All buffer parameter queries return one value. if (numParams) { *numParams = 1; } return true; } bool ValidateGetRenderbufferParameterivBase(Context *context, GLenum target, GLenum pname, GLsizei *length) { if (length) { *length = 0; } if (target != GL_RENDERBUFFER) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferTarget); return false; } Renderbuffer *renderbuffer = context->getGLState().getCurrentRenderbuffer(); if (renderbuffer == nullptr) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), RenderbufferNotBound); return false; } switch (pname) { case GL_RENDERBUFFER_WIDTH: case GL_RENDERBUFFER_HEIGHT: case GL_RENDERBUFFER_INTERNAL_FORMAT: case GL_RENDERBUFFER_RED_SIZE: case GL_RENDERBUFFER_GREEN_SIZE: case GL_RENDERBUFFER_BLUE_SIZE: case GL_RENDERBUFFER_ALPHA_SIZE: case GL_RENDERBUFFER_DEPTH_SIZE: case GL_RENDERBUFFER_STENCIL_SIZE: break; case GL_RENDERBUFFER_SAMPLES_ANGLE: if (!context->getExtensions().framebufferMultisample) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled); return false; } break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } if (length) { *length = 1; } return true; } bool ValidateGetShaderivBase(Context *context, GLuint shader, GLenum pname, GLsizei *length) { if (length) { *length = 0; } if (GetValidShader(context, shader) == nullptr) { return false; } switch (pname) { case GL_SHADER_TYPE: case GL_DELETE_STATUS: case GL_COMPILE_STATUS: case GL_INFO_LOG_LENGTH: case GL_SHADER_SOURCE_LENGTH: break; case GL_TRANSLATED_SHADER_SOURCE_LENGTH_ANGLE: if (!context->getExtensions().translatedShaderSource) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled); return false; } break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } if (length) { *length = 1; } return true; } bool ValidateGetTexParameterBase(Context *context, GLenum target, GLenum pname, GLsizei *length) { if (length) { *length = 0; } if (!ValidTextureTarget(context, target) && !ValidTextureExternalTarget(context, target)) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureTarget); return false; } if (context->getTargetTexture(target) == nullptr) { // Should only be possible for external textures ANGLE_VALIDATION_ERR(context, InvalidEnum(), TextureNotBound); return false; } switch (pname) { case GL_TEXTURE_MAG_FILTER: case GL_TEXTURE_MIN_FILTER: case GL_TEXTURE_WRAP_S: case GL_TEXTURE_WRAP_T: break; case GL_TEXTURE_USAGE_ANGLE: if (!context->getExtensions().textureUsage) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled); return false; } break; case GL_TEXTURE_MAX_ANISOTROPY_EXT: if (!context->getExtensions().textureFilterAnisotropic) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled); return false; } break; case GL_TEXTURE_IMMUTABLE_FORMAT: if (context->getClientMajorVersion() < 3 && !context->getExtensions().textureStorage) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled); return false; } break; case GL_TEXTURE_WRAP_R: case GL_TEXTURE_IMMUTABLE_LEVELS: case GL_TEXTURE_SWIZZLE_R: case GL_TEXTURE_SWIZZLE_G: case GL_TEXTURE_SWIZZLE_B: case GL_TEXTURE_SWIZZLE_A: case GL_TEXTURE_BASE_LEVEL: case GL_TEXTURE_MAX_LEVEL: case GL_TEXTURE_MIN_LOD: case GL_TEXTURE_MAX_LOD: case GL_TEXTURE_COMPARE_MODE: case GL_TEXTURE_COMPARE_FUNC: if (context->getClientMajorVersion() < 3) { context->handleError(InvalidEnum() << "pname requires OpenGL ES 3.0."); return false; } break; case GL_TEXTURE_SRGB_DECODE_EXT: if (!context->getExtensions().textureSRGBDecode) { context->handleError(InvalidEnum() << "GL_EXT_texture_sRGB_decode is not enabled."); return false; } break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } if (length) { *length = 1; } return true; } bool ValidateGetVertexAttribBase(Context *context, GLuint index, GLenum pname, GLsizei *length, bool pointer, bool pureIntegerEntryPoint) { if (length) { *length = 0; } if (pureIntegerEntryPoint && context->getClientMajorVersion() < 3) { context->handleError(InvalidOperation() << "Context does not support OpenGL ES 3.0."); return false; } if (index >= context->getCaps().maxVertexAttributes) { ANGLE_VALIDATION_ERR(context, InvalidValue(), IndexExceedsMaxVertexAttribute); return false; } if (pointer) { if (pname != GL_VERTEX_ATTRIB_ARRAY_POINTER) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } } else { switch (pname) { case GL_VERTEX_ATTRIB_ARRAY_ENABLED: case GL_VERTEX_ATTRIB_ARRAY_SIZE: case GL_VERTEX_ATTRIB_ARRAY_STRIDE: case GL_VERTEX_ATTRIB_ARRAY_TYPE: case GL_VERTEX_ATTRIB_ARRAY_NORMALIZED: case GL_VERTEX_ATTRIB_ARRAY_BUFFER_BINDING: case GL_CURRENT_VERTEX_ATTRIB: break; case GL_VERTEX_ATTRIB_ARRAY_DIVISOR: static_assert( GL_VERTEX_ATTRIB_ARRAY_DIVISOR == GL_VERTEX_ATTRIB_ARRAY_DIVISOR_ANGLE, "ANGLE extension enums not equal to GL enums."); if (context->getClientMajorVersion() < 3 && !context->getExtensions().instancedArrays) { context->handleError(InvalidEnum() << "GL_VERTEX_ATTRIB_ARRAY_DIVISOR " "requires OpenGL ES 3.0 or " "GL_ANGLE_instanced_arrays."); return false; } break; case GL_VERTEX_ATTRIB_ARRAY_INTEGER: if (context->getClientMajorVersion() < 3) { context->handleError( InvalidEnum() << "GL_VERTEX_ATTRIB_ARRAY_INTEGER requires OpenGL ES 3.0."); return false; } break; case GL_VERTEX_ATTRIB_BINDING: case GL_VERTEX_ATTRIB_RELATIVE_OFFSET: if (context->getClientVersion() < ES_3_1) { context->handleError(InvalidEnum() << "Vertex Attrib Bindings require OpenGL ES 3.1."); return false; } break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } } if (length) { if (pname == GL_CURRENT_VERTEX_ATTRIB) { *length = 4; } else { *length = 1; } } return true; } bool ValidateReadPixelsBase(Context *context, GLint x, GLint y, GLsizei width, GLsizei height, GLenum format, GLenum type, GLsizei bufSize, GLsizei *length, GLsizei *columns, GLsizei *rows, void *pixels) { if (length != nullptr) { *length = 0; } if (rows != nullptr) { *rows = 0; } if (columns != nullptr) { *columns = 0; } if (width < 0 || height < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeSize); return false; } Framebuffer *readFramebuffer = context->getGLState().getReadFramebuffer(); if (readFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE) { context->handleError(InvalidFramebufferOperation()); return false; } if (readFramebuffer->id() != 0 && readFramebuffer->getSamples(context) != 0) { context->handleError(InvalidOperation()); return false; } const Framebuffer *framebuffer = context->getGLState().getReadFramebuffer(); ASSERT(framebuffer); if (framebuffer->getReadBufferState() == GL_NONE) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ReadBufferNone); return false; } const FramebufferAttachment *readBuffer = framebuffer->getReadColorbuffer(); // WebGL 1.0 [Section 6.26] Reading From a Missing Attachment // In OpenGL ES it is undefined what happens when an operation tries to read from a missing // attachment and WebGL defines it to be an error. We do the check unconditionnaly as the // situation is an application error that would lead to a crash in ANGLE. if (readBuffer == nullptr) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), MissingReadAttachment); return false; } // ANGLE_multiview, Revision 1: // ReadPixels generates an INVALID_FRAMEBUFFER_OPERATION error if the multi-view layout of the // current read framebuffer is not NONE. if (readBuffer->getMultiviewLayout() != GL_NONE) { context->handleError(InvalidFramebufferOperation() << "Attempting to read from a multi-view framebuffer."); return false; } if (context->getExtensions().webglCompatibility) { // The ES 2.0 spec states that the format must be "among those defined in table 3.4, // excluding formats LUMINANCE and LUMINANCE_ALPHA.". This requires validating the format // and type before validating the combination of format and type. However, the // dEQP-GLES3.functional.negative_api.buffer.read_pixels passes GL_LUMINANCE as a format and // verifies that GL_INVALID_OPERATION is generated. // TODO(geofflang): Update this check to be done in all/no cases once this is resolved in // dEQP/WebGL. if (!ValidReadPixelsFormatEnum(context, format)) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidFormat); return false; } if (!ValidReadPixelsTypeEnum(context, type)) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidType); return false; } } GLenum currentFormat = framebuffer->getImplementationColorReadFormat(context); GLenum currentType = framebuffer->getImplementationColorReadType(context); GLenum currentComponentType = readBuffer->getFormat().info->componentType; bool validFormatTypeCombination = ValidReadPixelsFormatType(context, currentComponentType, format, type); if (!(currentFormat == format && currentType == type) && !validFormatTypeCombination) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), MismatchedTypeAndFormat); return false; } // Check for pixel pack buffer related API errors gl::Buffer *pixelPackBuffer = context->getGLState().getTargetBuffer(BufferBinding::PixelPack); if (pixelPackBuffer != nullptr && pixelPackBuffer->isMapped()) { // ...the buffer object's data store is currently mapped. context->handleError(InvalidOperation() << "Pixel pack buffer is mapped."); return false; } // .. the data would be packed to the buffer object such that the memory writes required // would exceed the data store size. const InternalFormat &formatInfo = GetInternalFormatInfo(format, type); const gl::Extents size(width, height, 1); const auto &pack = context->getGLState().getPackState(); auto endByteOrErr = formatInfo.computePackUnpackEndByte(type, size, pack, false); if (endByteOrErr.isError()) { context->handleError(endByteOrErr.getError()); return false; } size_t endByte = endByteOrErr.getResult(); if (bufSize >= 0) { if (pixelPackBuffer == nullptr && static_cast(bufSize) < endByte) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize); return false; } } if (pixelPackBuffer != nullptr) { CheckedNumeric checkedEndByte(endByte); CheckedNumeric checkedOffset(reinterpret_cast(pixels)); checkedEndByte += checkedOffset; if (checkedEndByte.ValueOrDie() > static_cast(pixelPackBuffer->getSize())) { // Overflow past the end of the buffer ANGLE_VALIDATION_ERR(context, InvalidOperation(), ParamOverflow); return false; } } if (pixelPackBuffer == nullptr && length != nullptr) { if (endByte > static_cast(std::numeric_limits::max())) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow); return false; } *length = static_cast(endByte); } auto getClippedExtent = [](GLint start, GLsizei length, int bufferSize) { angle::CheckedNumeric clippedExtent(length); if (start < 0) { // "subtract" the area that is less than 0 clippedExtent += start; } const int readExtent = start + length; if (readExtent > bufferSize) { // Subtract the region to the right of the read buffer clippedExtent -= (readExtent - bufferSize); } if (!clippedExtent.IsValid()) { return 0; } return std::max(clippedExtent.ValueOrDie(), 0); }; if (columns != nullptr) { *columns = getClippedExtent(x, width, readBuffer->getSize().width); } if (rows != nullptr) { *rows = getClippedExtent(y, height, readBuffer->getSize().height); } return true; } template bool ValidateTexParameterBase(Context *context, GLenum target, GLenum pname, GLsizei bufSize, const ParamType *params) { if (!ValidTextureTarget(context, target) && !ValidTextureExternalTarget(context, target)) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureTarget); return false; } if (context->getTargetTexture(target) == nullptr) { // Should only be possible for external textures ANGLE_VALIDATION_ERR(context, InvalidEnum(), TextureNotBound); return false; } const GLsizei minBufSize = 1; if (bufSize >= 0 && bufSize < minBufSize) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize); return false; } switch (pname) { case GL_TEXTURE_WRAP_R: case GL_TEXTURE_SWIZZLE_R: case GL_TEXTURE_SWIZZLE_G: case GL_TEXTURE_SWIZZLE_B: case GL_TEXTURE_SWIZZLE_A: case GL_TEXTURE_BASE_LEVEL: case GL_TEXTURE_MAX_LEVEL: case GL_TEXTURE_COMPARE_MODE: case GL_TEXTURE_COMPARE_FUNC: case GL_TEXTURE_MIN_LOD: case GL_TEXTURE_MAX_LOD: if (context->getClientMajorVersion() < 3) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), ES3Required); return false; } if (target == GL_TEXTURE_EXTERNAL_OES && !context->getExtensions().eglImageExternalEssl3) { context->handleError(InvalidEnum() << "ES3 texture parameters are not " "available without " "GL_OES_EGL_image_external_essl3."); return false; } break; default: break; } if (target == GL_TEXTURE_2D_MULTISAMPLE) { switch (pname) { case GL_TEXTURE_MIN_FILTER: case GL_TEXTURE_MAG_FILTER: case GL_TEXTURE_WRAP_S: case GL_TEXTURE_WRAP_T: case GL_TEXTURE_WRAP_R: case GL_TEXTURE_MIN_LOD: case GL_TEXTURE_MAX_LOD: case GL_TEXTURE_COMPARE_MODE: case GL_TEXTURE_COMPARE_FUNC: context->handleError(InvalidEnum() << "Invalid parameter for 2D multisampled textures."); return false; } } switch (pname) { case GL_TEXTURE_WRAP_S: case GL_TEXTURE_WRAP_T: case GL_TEXTURE_WRAP_R: { bool restrictedWrapModes = target == GL_TEXTURE_EXTERNAL_OES || target == GL_TEXTURE_RECTANGLE_ANGLE; if (!ValidateTextureWrapModeValue(context, params, restrictedWrapModes)) { return false; } } break; case GL_TEXTURE_MIN_FILTER: { bool restrictedMinFilter = target == GL_TEXTURE_EXTERNAL_OES || target == GL_TEXTURE_RECTANGLE_ANGLE; if (!ValidateTextureMinFilterValue(context, params, restrictedMinFilter)) { return false; } } break; case GL_TEXTURE_MAG_FILTER: if (!ValidateTextureMagFilterValue(context, params)) { return false; } break; case GL_TEXTURE_USAGE_ANGLE: if (!context->getExtensions().textureUsage) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } switch (ConvertToGLenum(params[0])) { case GL_NONE: case GL_FRAMEBUFFER_ATTACHMENT_ANGLE: break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } break; case GL_TEXTURE_MAX_ANISOTROPY_EXT: if (!context->getExtensions().textureFilterAnisotropic) { context->handleError(InvalidEnum() << "GL_EXT_texture_anisotropic is not enabled."); return false; } // we assume the parameter passed to this validation method is truncated, not rounded if (params[0] < 1) { context->handleError(InvalidValue() << "Max anisotropy must be at least 1."); return false; } break; case GL_TEXTURE_MIN_LOD: case GL_TEXTURE_MAX_LOD: // any value is permissible break; case GL_TEXTURE_COMPARE_MODE: if (!ValidateTextureCompareModeValue(context, params)) { return false; } break; case GL_TEXTURE_COMPARE_FUNC: if (!ValidateTextureCompareFuncValue(context, params)) { return false; } break; case GL_TEXTURE_SWIZZLE_R: case GL_TEXTURE_SWIZZLE_G: case GL_TEXTURE_SWIZZLE_B: case GL_TEXTURE_SWIZZLE_A: switch (ConvertToGLenum(params[0])) { case GL_RED: case GL_GREEN: case GL_BLUE: case GL_ALPHA: case GL_ZERO: case GL_ONE: break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } break; case GL_TEXTURE_BASE_LEVEL: if (ConvertToGLint(params[0]) < 0) { context->handleError(InvalidValue() << "Base level must be at least 0."); return false; } if (target == GL_TEXTURE_EXTERNAL_OES && static_cast(params[0]) != 0) { context->handleError(InvalidOperation() << "Base level must be 0 for external textures."); return false; } if (target == GL_TEXTURE_2D_MULTISAMPLE && static_cast(params[0]) != 0) { context->handleError(InvalidOperation() << "Base level must be 0 for multisampled textures."); return false; } if (target == GL_TEXTURE_RECTANGLE_ANGLE && static_cast(params[0]) != 0) { context->handleError(InvalidOperation() << "Base level must be 0 for rectangle textures."); return false; } break; case GL_TEXTURE_MAX_LEVEL: if (ConvertToGLint(params[0]) < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel); return false; } break; case GL_DEPTH_STENCIL_TEXTURE_MODE: if (context->getClientVersion() < Version(3, 1)) { ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumRequiresGLES31); return false; } switch (ConvertToGLenum(params[0])) { case GL_DEPTH_COMPONENT: case GL_STENCIL_INDEX: break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } break; case GL_TEXTURE_SRGB_DECODE_EXT: if (!ValidateTextureSRGBDecodeValue(context, params)) { return false; } break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } return true; } template bool ValidateTexParameterBase(Context *, GLenum, GLenum, GLsizei, const GLfloat *); template bool ValidateTexParameterBase(Context *, GLenum, GLenum, GLsizei, const GLint *); bool ValidateVertexAttribIndex(ValidationContext *context, GLuint index) { if (index >= MAX_VERTEX_ATTRIBS) { ANGLE_VALIDATION_ERR(context, InvalidValue(), IndexExceedsMaxVertexAttribute); return false; } return true; } bool ValidateGetActiveUniformBlockivBase(Context *context, GLuint program, GLuint uniformBlockIndex, GLenum pname, GLsizei *length) { if (length) { *length = 0; } if (context->getClientMajorVersion() < 3) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); return false; } Program *programObject = GetValidProgram(context, program); if (!programObject) { return false; } if (uniformBlockIndex >= programObject->getActiveUniformBlockCount()) { context->handleError(InvalidValue() << "uniformBlockIndex exceeds active uniform block count."); return false; } switch (pname) { case GL_UNIFORM_BLOCK_BINDING: case GL_UNIFORM_BLOCK_DATA_SIZE: case GL_UNIFORM_BLOCK_NAME_LENGTH: case GL_UNIFORM_BLOCK_ACTIVE_UNIFORMS: case GL_UNIFORM_BLOCK_ACTIVE_UNIFORM_INDICES: case GL_UNIFORM_BLOCK_REFERENCED_BY_VERTEX_SHADER: case GL_UNIFORM_BLOCK_REFERENCED_BY_FRAGMENT_SHADER: break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } if (length) { if (pname == GL_UNIFORM_BLOCK_ACTIVE_UNIFORM_INDICES) { const InterfaceBlock &uniformBlock = programObject->getUniformBlockByIndex(uniformBlockIndex); *length = static_cast(uniformBlock.memberIndexes.size()); } else { *length = 1; } } return true; } template bool ValidateSamplerParameterBase(Context *context, GLuint sampler, GLenum pname, GLsizei bufSize, ParamType *params) { if (context->getClientMajorVersion() < 3) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); return false; } if (!context->isSampler(sampler)) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidSampler); return false; } const GLsizei minBufSize = 1; if (bufSize >= 0 && bufSize < minBufSize) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize); return false; } switch (pname) { case GL_TEXTURE_WRAP_S: case GL_TEXTURE_WRAP_T: case GL_TEXTURE_WRAP_R: if (!ValidateTextureWrapModeValue(context, params, false)) { return false; } break; case GL_TEXTURE_MIN_FILTER: if (!ValidateTextureMinFilterValue(context, params, false)) { return false; } break; case GL_TEXTURE_MAG_FILTER: if (!ValidateTextureMagFilterValue(context, params)) { return false; } break; case GL_TEXTURE_MIN_LOD: case GL_TEXTURE_MAX_LOD: // any value is permissible break; case GL_TEXTURE_COMPARE_MODE: if (!ValidateTextureCompareModeValue(context, params)) { return false; } break; case GL_TEXTURE_COMPARE_FUNC: if (!ValidateTextureCompareFuncValue(context, params)) { return false; } break; case GL_TEXTURE_SRGB_DECODE_EXT: if (!ValidateTextureSRGBDecodeValue(context, params)) { return false; } break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } return true; } template bool ValidateSamplerParameterBase(Context *, GLuint, GLenum, GLsizei, GLfloat *); template bool ValidateSamplerParameterBase(Context *, GLuint, GLenum, GLsizei, GLint *); bool ValidateGetSamplerParameterBase(Context *context, GLuint sampler, GLenum pname, GLsizei *length) { if (length) { *length = 0; } if (context->getClientMajorVersion() < 3) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); return false; } if (!context->isSampler(sampler)) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidSampler); return false; } switch (pname) { case GL_TEXTURE_WRAP_S: case GL_TEXTURE_WRAP_T: case GL_TEXTURE_WRAP_R: case GL_TEXTURE_MIN_FILTER: case GL_TEXTURE_MAG_FILTER: case GL_TEXTURE_MIN_LOD: case GL_TEXTURE_MAX_LOD: case GL_TEXTURE_COMPARE_MODE: case GL_TEXTURE_COMPARE_FUNC: break; case GL_TEXTURE_SRGB_DECODE_EXT: if (!context->getExtensions().textureSRGBDecode) { context->handleError(InvalidEnum() << "GL_EXT_texture_sRGB_decode is not enabled."); return false; } break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } if (length) { *length = 1; } return true; } bool ValidateGetInternalFormativBase(Context *context, GLenum target, GLenum internalformat, GLenum pname, GLsizei bufSize, GLsizei *numParams) { if (numParams) { *numParams = 0; } if (context->getClientMajorVersion() < 3) { ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); return false; } const TextureCaps &formatCaps = context->getTextureCaps().get(internalformat); if (!formatCaps.renderable) { context->handleError(InvalidEnum() << "Internal format is not renderable."); return false; } switch (target) { case GL_RENDERBUFFER: break; case GL_TEXTURE_2D_MULTISAMPLE: if (context->getClientVersion() < ES_3_1) { context->handleError(InvalidOperation() << "Texture target requires at least OpenGL ES 3.1."); return false; } break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTarget); return false; } if (bufSize < 0) { ANGLE_VALIDATION_ERR(context, InvalidValue(), InsufficientBufferSize); return false; } GLsizei maxWriteParams = 0; switch (pname) { case GL_NUM_SAMPLE_COUNTS: maxWriteParams = 1; break; case GL_SAMPLES: maxWriteParams = static_cast(formatCaps.sampleCounts.size()); break; default: ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported); return false; } if (numParams) { // glGetInternalFormativ will not overflow bufSize *numParams = std::min(bufSize, maxWriteParams); } return true; } } // namespace gl