summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarc Mutz <marc.mutz@qt.io>2023-08-07 11:10:30 +0200
committerQt Cherry-pick Bot <cherrypick_bot@qt-project.org>2023-08-07 12:43:23 +0000
commit7a86eb38ced93f5b99ac9b903bc7bfdadc086a92 (patch)
treec2e54b273178f4d61b1c8f9729923be07e3618a3
parent2aee34b8ba15f2d43343f8d7cc99409e087fc891 (diff)
ChartWidgetTest MainWindow: fix overly complicated QStringList copy
There's no reason to use a for loop to copy one QStringList into another, so don't. In fact, the copy isn't needed at all, we can just use the original, so do that, too. Task-number: QTBUG-115824 Change-Id: I73553ed220f227fa5f38974b84d1c1cbeb13a450 Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io> (cherry picked from commit b8d6d994d0303e00c792c392721dc0d0ce8176ef) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
-rw-r--r--tests/manual/chartwidgettest/mainwidget.cpp9
1 files changed, 3 insertions, 6 deletions
diff --git a/tests/manual/chartwidgettest/mainwidget.cpp b/tests/manual/chartwidgettest/mainwidget.cpp
index 267d7941..d601dc52 100644
--- a/tests/manual/chartwidgettest/mainwidget.cpp
+++ b/tests/manual/chartwidgettest/mainwidget.cpp
@@ -271,25 +271,22 @@ void MainWidget::addSeries(QString seriesName, int columnCount, int rowCount, QS
} else if (seriesName == "Bar"
|| seriesName == "Stacked bar"
|| seriesName == "Percent bar") {
- QStringList category;
QStringList labels = generateLabels(rowCount);
- foreach (QString label, labels)
- category << label;
QAbstractBarSeries* series = 0;
if (seriesName == "Bar") {
series = new QBarSeries(this);
QBarCategoryAxis* axis = new QBarCategoryAxis();
- axis->append(category);
+ axis->append(labels);
m_chart->setAxisX(axis,series);
} else if (seriesName == "Stacked bar") {
series = new QStackedBarSeries(this);
QBarCategoryAxis* axis = new QBarCategoryAxis();
- axis->append(category);
+ axis->append(labels);
m_chart->setAxisX(axis,series);
} else {
series = new QPercentBarSeries(this);
QBarCategoryAxis* axis = new QBarCategoryAxis();
- axis->append(category);
+ axis->append(labels);
m_chart->setAxisX(axis,series);
}